Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806842/?format=api
{ "id": 806842, "url": "http://patchwork.ozlabs.org/api/patches/806842/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-42-git-send-email-mdroth@linux.vnet.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503965694-10794-42-git-send-email-mdroth@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-08-29T00:14:16", "name": "[41/79] blkdebug: Simplify override logic", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2e675bb375db18fe7ac87d647b4211777518f67b", "submitter": { "id": 5549, "url": "http://patchwork.ozlabs.org/api/people/5549/?format=api", "name": "Michael Roth", "email": "mdroth@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-42-git-send-email-mdroth@linux.vnet.ibm.com/mbox/", "series": [ { "id": 281, "url": "http://patchwork.ozlabs.org/api/series/281/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=281", "date": "2017-08-29T00:13:45", "name": "Patch Round-up for stable 2.9.1, freeze on 2017-09-04", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/281/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806842/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806842/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh8rK3xvJz9s4s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Aug 2017 10:38:25 +1000 (AEST)", "from localhost ([::1]:42007 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmUXv-00049m-9y\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 20:38:23 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:48134)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUCV-0001Ku-Sq\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:19 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUCS-0005VD-LI\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:15 -0400", "from mx0b-001b2d01.pphosted.com ([148.163.158.5]:53332\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <mdroth@linux.vnet.ibm.com>)\n\tid 1dmUCS-0005Ue-GS\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:12 -0400", "from pps.filterd (m0098421.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7T0E9gk081527\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:16:12 -0400", "from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cmurncrp0-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:16:11 -0400", "from localhost\n\tby e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;\n\tMon, 28 Aug 2017 20:16:11 -0400", "from b01cxnp22033.gho.pok.ibm.com (9.57.198.23)\n\tby e11.ny.us.ibm.com (146.89.104.198) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 20:16:08 -0400", "from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com\n\t[9.57.199.108])\n\tby b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v7T0G7ap12976144; Tue, 29 Aug 2017 00:16:07 GMT", "from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id C6DB2B2052;\n\tMon, 28 Aug 2017 20:13:31 -0400 (EDT)", "from localhost (unknown [9.80.85.217])\n\tby b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP id 8F952B204E;\n\tMon, 28 Aug 2017 20:13:31 -0400 (EDT)" ], "From": "Michael Roth <mdroth@linux.vnet.ibm.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 28 Aug 2017 19:14:16 -0500", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "References": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17082900-2213-0000-0000-00000210D364", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007630; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909027; UDB=6.00455849;\n\tIPR=6.00689279; \n\tBA=6.00005557; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016909;\n\tXFM=3.00000015; UTC=2017-08-29 00:16:10", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17082900-2214-0000-0000-0000575DED06", "Message-Id": "<1503965694-10794-42-git-send-email-mdroth@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_13:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=3\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708290001", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]", "X-Received-From": "148.163.158.5", "Subject": "[Qemu-devel] [PATCH 41/79] blkdebug: Simplify override logic", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "qemu-stable@nongnu.org, Max Reitz <mreitz@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Eric Blake <eblake@redhat.com>\n\nRather than store into a local variable, then copy to the struct\nif the value is valid, then reporting errors otherwise, it is\nsimpler to just store into the struct and report errors if the\nvalue is invalid. This however requires that the struct store\na 64-bit number, rather than a narrower type. Likewise, setting\na sane errno value in ret prior to the sequence of parsing and\njumping to out: on error makes it easier for the next patch to\nadd a chain of similar checks.\n\nSigned-off-by: Eric Blake <eblake@redhat.com>\nMessage-id: 20170429191419.30051-8-eblake@redhat.com\nReviewed-by: Max Reitz <mreitz@redhat.com>\nSigned-off-by: Max Reitz <mreitz@redhat.com>\n(cherry picked from commit 3dc834f8795a46f919d90b1e5369308628858601)\n* prereq for 81c219a\nSigned-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>\n---\n block/blkdebug.c | 16 ++++++----------\n 1 file changed, 6 insertions(+), 10 deletions(-)", "diff": "diff --git a/block/blkdebug.c b/block/blkdebug.c\nindex a3dc5f6..2b934ef 100644\n--- a/block/blkdebug.c\n+++ b/block/blkdebug.c\n@@ -38,7 +38,7 @@\n typedef struct BDRVBlkdebugState {\n int state;\n int new_state;\n- int align;\n+ uint64_t align;\n \n /* For blkdebug_refresh_filename() */\n char *config_file;\n@@ -353,7 +353,6 @@ static int blkdebug_open(BlockDriverState *bs, QDict *options, int flags,\n BDRVBlkdebugState *s = bs->opaque;\n QemuOpts *opts;\n Error *local_err = NULL;\n- uint64_t align;\n int ret;\n \n opts = qemu_opts_create(&runtime_opts, NULL, 0, &error_abort);\n@@ -387,20 +386,17 @@ static int blkdebug_open(BlockDriverState *bs, QDict *options, int flags,\n bs->file->bs->supported_write_flags;\n bs->supported_zero_flags = (BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP) &\n bs->file->bs->supported_zero_flags;\n+ ret = -EINVAL;\n \n /* Set request alignment */\n- align = qemu_opt_get_size(opts, \"align\", 0);\n- if (align < INT_MAX && is_power_of_2(align)) {\n- s->align = align;\n- } else if (align) {\n- error_setg(errp, \"Invalid alignment\");\n- ret = -EINVAL;\n+ s->align = qemu_opt_get_size(opts, \"align\", 0);\n+ if (s->align && (s->align >= INT_MAX || !is_power_of_2(s->align))) {\n+ error_setg(errp, \"Cannot meet constraints with align %\" PRIu64,\n+ s->align);\n goto out;\n }\n \n ret = 0;\n- goto out;\n-\n out:\n if (ret < 0) {\n g_free(s->config_file);\n", "prefixes": [ "41/79" ] }