Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806836/?format=api
{ "id": 806836, "url": "http://patchwork.ozlabs.org/api/patches/806836/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-28-git-send-email-mdroth@linux.vnet.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503965694-10794-28-git-send-email-mdroth@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-08-29T00:14:02", "name": "[27/79] target/xtensa: fix return value of read/write simcalls", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d66df7c849b83d8956c3959b5983481f9e2cb4e3", "submitter": { "id": 5549, "url": "http://patchwork.ozlabs.org/api/people/5549/?format=api", "name": "Michael Roth", "email": "mdroth@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-28-git-send-email-mdroth@linux.vnet.ibm.com/mbox/", "series": [ { "id": 281, "url": "http://patchwork.ozlabs.org/api/series/281/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=281", "date": "2017-08-29T00:13:45", "name": "Patch Round-up for stable 2.9.1, freeze on 2017-09-04", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/281/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806836/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806836/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh8nG0z80z9s4s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Aug 2017 10:35:46 +1000 (AEST)", "from localhost ([::1]:41986 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmUVL-0001ls-Vo\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 20:35:44 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:47727)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUCI-00012i-Dq\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:05 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUCF-0005Fl-54\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:02 -0400", "from mx0b-001b2d01.pphosted.com ([148.163.158.5]:60942\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <mdroth@linux.vnet.ibm.com>)\n\tid 1dmUCE-0005FJ-UY\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:15:59 -0400", "from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7T0EAdl044225\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:15:58 -0400", "from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cmu3kpe19-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:15:58 -0400", "from localhost\n\tby e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;\n\tMon, 28 Aug 2017 18:15:57 -0600", "from b03cxnp08027.gho.boulder.ibm.com (9.17.130.19)\n\tby e36.co.us.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 18:15:55 -0600", "from b03ledav004.gho.boulder.ibm.com\n\t(b03ledav004.gho.boulder.ibm.com [9.17.130.235])\n\tby b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7T0Ft3B64421986; Mon, 28 Aug 2017 17:15:55 -0700", "from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 5AB4A78038;\n\tMon, 28 Aug 2017 18:15:55 -0600 (MDT)", "from localhost (unknown [9.80.85.217])\n\tby b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP id 34FC778043;\n\tMon, 28 Aug 2017 18:15:55 -0600 (MDT)" ], "From": "Michael Roth <mdroth@linux.vnet.ibm.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 28 Aug 2017 19:14:02 -0500", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "References": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17082900-0020-0000-0000-00000CA0E9C0", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007630; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909028; UDB=6.00455849;\n\tIPR=6.00689279; \n\tBA=6.00005557; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016909;\n\tXFM=3.00000015; UTC=2017-08-29 00:15:57", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17082900-0021-0000-0000-00005DE89193", "Message-Id": "<1503965694-10794-28-git-send-email-mdroth@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_13:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708290001", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]", "X-Received-From": "148.163.158.5", "Subject": "[Qemu-devel] [PATCH 27/79] target/xtensa: fix return value of\n\tread/write simcalls", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Max Filippov <jcmvbkbc@gmail.com>, qemu-stable@nongnu.org", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Max Filippov <jcmvbkbc@gmail.com>\n\nReturn value of read/write simcalls is not calculated correctly in case\nof operations crossing page boundary and in case of short reads/writes.\nRead and write simcalls should return the size of data actually\nread/written or -1 in case of error.\n\nCc: qemu-stable@nongnu.org\nSigned-off-by: Max Filippov <jcmvbkbc@gmail.com>\n(cherry picked from commit 347ec03093f9668a379ef6b7fa1feb332fff039c)\nSigned-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>\n---\n target/xtensa/xtensa-semi.c | 25 ++++++++++++++++++++-----\n 1 file changed, 20 insertions(+), 5 deletions(-)", "diff": "diff --git a/target/xtensa/xtensa-semi.c b/target/xtensa/xtensa-semi.c\nindex 98ae28c..ffcaf8d 100644\n--- a/target/xtensa/xtensa-semi.c\n+++ b/target/xtensa/xtensa-semi.c\n@@ -166,6 +166,7 @@ void HELPER(simcall)(CPUXtensaState *env)\n uint32_t fd = regs[3];\n uint32_t vaddr = regs[4];\n uint32_t len = regs[5];\n+ uint32_t len_done = 0;\n \n while (len > 0) {\n hwaddr paddr = cpu_get_phys_page_debug(cs, vaddr);\n@@ -174,24 +175,38 @@ void HELPER(simcall)(CPUXtensaState *env)\n uint32_t io_sz = page_left < len ? page_left : len;\n hwaddr sz = io_sz;\n void *buf = cpu_physical_memory_map(paddr, &sz, !is_write);\n+ uint32_t io_done;\n+ bool error = false;\n \n if (buf) {\n vaddr += io_sz;\n len -= io_sz;\n- regs[2] = is_write ?\n+ io_done = is_write ?\n write(fd, buf, io_sz) :\n read(fd, buf, io_sz);\n regs[3] = errno_h2g(errno);\n- cpu_physical_memory_unmap(buf, sz, !is_write, sz);\n- if (regs[2] == -1) {\n- break;\n+ if (io_done == -1) {\n+ error = true;\n+ io_done = 0;\n }\n+ cpu_physical_memory_unmap(buf, sz, !is_write, io_done);\n } else {\n- regs[2] = -1;\n+ error = true;\n regs[3] = TARGET_EINVAL;\n break;\n }\n+ if (error) {\n+ if (!len_done) {\n+ len_done = -1;\n+ }\n+ break;\n+ }\n+ len_done += io_done;\n+ if (io_done < io_sz) {\n+ break;\n+ }\n }\n+ regs[2] = len_done;\n }\n break;\n \n", "prefixes": [ "27/79" ] }