Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806819/?format=api
{ "id": 806819, "url": "http://patchwork.ozlabs.org/api/patches/806819/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-34-git-send-email-mdroth@linux.vnet.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503965694-10794-34-git-send-email-mdroth@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-08-29T00:14:08", "name": "[33/79] virtio: allow broken device to notify guest", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "25b629e087da4a7f79f619304e5d2031c0940f28", "submitter": { "id": 5549, "url": "http://patchwork.ozlabs.org/api/people/5549/?format=api", "name": "Michael Roth", "email": "mdroth@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-34-git-send-email-mdroth@linux.vnet.ibm.com/mbox/", "series": [ { "id": 281, "url": "http://patchwork.ozlabs.org/api/series/281/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=281", "date": "2017-08-29T00:13:45", "name": "Patch Round-up for stable 2.9.1, freeze on 2017-09-04", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/281/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806819/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806819/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh8Ww5c6sz9s7v\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Aug 2017 10:24:12 +1000 (AEST)", "from localhost ([::1]:41919 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmUKA-00084S-Kr\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 20:24:10 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:47893)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUCO-0001Aj-DT\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:09 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUCM-0005PD-FM\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:08 -0400", "from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57452)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <mdroth@linux.vnet.ibm.com>)\n\tid 1dmUCM-0005Ok-79\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:06 -0400", "from pps.filterd (m0098394.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7T0ECLT041673\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:16:05 -0400", "from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cmsrsj1hu-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:16:05 -0400", "from localhost\n\tby e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;\n\tMon, 28 Aug 2017 20:16:03 -0400", "from b01cxnp22034.gho.pok.ibm.com (9.57.198.24)\n\tby e16.ny.us.ibm.com (146.89.104.203) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 20:16:01 -0400", "from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com\n\t[9.57.199.111])\n\tby b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v7T0G0bI20971546; Tue, 29 Aug 2017 00:16:00 GMT", "from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id AB7CCAC041;\n\tMon, 28 Aug 2017 20:16:24 -0400 (EDT)", "from localhost (unknown [9.80.85.217])\n\tby b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP id 73DE3AC03A;\n\tMon, 28 Aug 2017 20:16:24 -0400 (EDT)" ], "From": "Michael Roth <mdroth@linux.vnet.ibm.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 28 Aug 2017 19:14:08 -0500", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "References": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17082900-0024-0000-0000-000002C6D29E", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007630; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909028; UDB=6.00455849;\n\tIPR=6.00689279; \n\tBA=6.00005557; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016909;\n\tXFM=3.00000015; UTC=2017-08-29 00:16:02", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17082900-0025-0000-0000-0000453E6316", "Message-Id": "<1503965694-10794-34-git-send-email-mdroth@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_13:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708290001", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]", "X-Received-From": "148.163.156.1", "Subject": "[Qemu-devel] [PATCH 33/79] virtio: allow broken device to notify\n\tguest", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "\"Michael S . Tsirkin\" <mst@redhat.com>, qemu-stable@nongnu.org,\n\tGreg Kurz <groug@kaod.org>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Greg Kurz <groug@kaod.org>\n\nAccording to section 2.1.2 of the virtio-1 specification:\n\n\"The device SHOULD set DEVICE_NEEDS_RESET when it enters an error state that\na reset is needed. If DRIVER_OK is set, after it sets DEVICE_NEEDS_RESET,\nthe device MUST send a device configuration change notification to the\ndriver.\"\n\nCommit \"f5ed36635d8f virtio: stop virtqueue processing if device is broken\"\nintroduced a virtio_error() call that just does that:\n\n- internally mark the device as broken\n- set the DEVICE_NEEDS_RESET bit in the status\n- send a configuration change notification\n\nUnfortunately, virtio_notify_vector(), called by virtio_notify_config(),\nreturns right away when the device is marked as broken and the notification\nisn't sent in this case.\n\nThe spec doesn't say whether a broken device can send notifications\nin other situations or not. But since the driver isn't supposed to do\nanything but to reset the device, it makes sense to keep the check in\nvirtio_notify_config().\n\nMarking the device as broken AFTER the configuration change notification was\nsent is enough to fix the issue.\n\nSigned-off-by: Greg Kurz <groug@kaod.org>\nReviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>\nReviewed-by: Michael S. Tsirkin <mst@redhat.com>\nSigned-off-by: Michael S. Tsirkin <mst@redhat.com>\nReviewed-by: Stefan Hajnoczi <stefanha@redhat.com>\n(cherry picked from commit 66453cff9e5e75344c601cd7674c8ef5fefee8a6)\nSigned-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>\n---\n hw/virtio/virtio.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c\nindex 03592c5..890b4d7 100644\n--- a/hw/virtio/virtio.c\n+++ b/hw/virtio/virtio.c\n@@ -2451,12 +2451,12 @@ void GCC_FMT_ATTR(2, 3) virtio_error(VirtIODevice *vdev, const char *fmt, ...)\n error_vreport(fmt, ap);\n va_end(ap);\n \n- vdev->broken = true;\n-\n if (virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) {\n virtio_set_status(vdev, vdev->status | VIRTIO_CONFIG_S_NEEDS_RESET);\n virtio_notify_config(vdev);\n }\n+\n+ vdev->broken = true;\n }\n \n static void virtio_memory_listener_commit(MemoryListener *listener)\n", "prefixes": [ "33/79" ] }