Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806816/?format=api
{ "id": 806816, "url": "http://patchwork.ozlabs.org/api/patches/806816/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-17-git-send-email-mdroth@linux.vnet.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503965694-10794-17-git-send-email-mdroth@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-08-29T00:13:51", "name": "[16/79] qobject: Add helper macros for common scalar insertions", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4e4960bedc176c1f92d1adc4a9aa1f042a59e0c8", "submitter": { "id": 5549, "url": "http://patchwork.ozlabs.org/api/people/5549/?format=api", "name": "Michael Roth", "email": "mdroth@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-17-git-send-email-mdroth@linux.vnet.ibm.com/mbox/", "series": [ { "id": 281, "url": "http://patchwork.ozlabs.org/api/series/281/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=281", "date": "2017-08-29T00:13:45", "name": "Patch Round-up for stable 2.9.1, freeze on 2017-09-04", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/281/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806816/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806816/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh8Tv2fNYz9s65\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Aug 2017 10:22:27 +1000 (AEST)", "from localhost ([::1]:41908 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmUIT-0006aL-6E\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 20:22:25 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:47419)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUC8-0000rC-B8\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:15:53 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUC5-00056t-4n\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:15:52 -0400", "from mx0b-001b2d01.pphosted.com ([148.163.158.5]:60523\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <mdroth@linux.vnet.ibm.com>)\n\tid 1dmUC4-00056H-N8\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:15:48 -0400", "from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7T0E7Yu043799\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:15:48 -0400", "from e31.co.us.ibm.com (e31.co.us.ibm.com [32.97.110.149])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cmu3kpdsm-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:15:48 -0400", "from localhost\n\tby e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;\n\tMon, 28 Aug 2017 18:15:47 -0600", "from b03cxnp08025.gho.boulder.ibm.com (9.17.130.17)\n\tby e31.co.us.ibm.com (192.168.1.131) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 18:15:46 -0600", "from b03ledav004.gho.boulder.ibm.com\n\t(b03ledav004.gho.boulder.ibm.com [9.17.130.235])\n\tby b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7T0FjTg66519206; Mon, 28 Aug 2017 17:15:45 -0700", "from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 7EF2B78047;\n\tMon, 28 Aug 2017 18:15:45 -0600 (MDT)", "from localhost (unknown [9.80.85.217])\n\tby b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP id 48BEA7803F;\n\tMon, 28 Aug 2017 18:15:45 -0600 (MDT)" ], "From": "Michael Roth <mdroth@linux.vnet.ibm.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 28 Aug 2017 19:13:51 -0500", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "References": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17082900-8235-0000-0000-00000C2FE79F", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007630; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909028; UDB=6.00455849;\n\tIPR=6.00689279; \n\tBA=6.00005557; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016909;\n\tXFM=3.00000015; UTC=2017-08-29 00:15:47", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17082900-8236-0000-0000-00003D6C06C6", "Message-Id": "<1503965694-10794-17-git-send-email-mdroth@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_13:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708290001", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]", "X-Received-From": "148.163.158.5", "Subject": "[Qemu-devel] [PATCH 16/79] qobject: Add helper macros for common\n\tscalar insertions", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "qemu-stable@nongnu.org, Markus Armbruster <armbru@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Eric Blake <eblake@redhat.com>\n\nRather than making lots of callers wrap a scalar in a QInt, QString,\nor QBool, provide helper macros that do the wrapping automatically.\n\nUpdate the Coccinelle script to make mass conversions easy, although\nthe conversion itself will be done as a separate patches to ease\nreview and backport efforts.\n\nSigned-off-by: Eric Blake <eblake@redhat.com>\nReviewed-by: Markus Armbruster <armbru@redhat.com>\nMessage-Id: <20170427215821.19397-6-eblake@redhat.com>\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\n(cherry picked from commit a92c21591b5bb9543996538f14854ca6b528318b)\nSigned-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>\n---\n include/qapi/qmp/qdict.h | 8 ++++++++\n include/qapi/qmp/qlist.h | 8 ++++++++\n scripts/coccinelle/qobject.cocci | 22 ++++++++++++++++++++++\n 3 files changed, 38 insertions(+)", "diff": "diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h\nindex fe9a4c5..188440a 100644\n--- a/include/qapi/qmp/qdict.h\n+++ b/include/qapi/qmp/qdict.h\n@@ -52,6 +52,14 @@ void qdict_destroy_obj(QObject *obj);\n #define qdict_put(qdict, key, obj) \\\n qdict_put_obj(qdict, key, QOBJECT(obj))\n \n+/* Helpers for int, bool, and string */\n+#define qdict_put_int(qdict, key, value) \\\n+ qdict_put(qdict, key, qint_from_int(value))\n+#define qdict_put_bool(qdict, key, value) \\\n+ qdict_put(qdict, key, qbool_from_bool(value))\n+#define qdict_put_str(qdict, key, value) \\\n+ qdict_put(qdict, key, qstring_from_str(value))\n+\n /* High level helpers */\n double qdict_get_double(const QDict *qdict, const char *key);\n int64_t qdict_get_int(const QDict *qdict, const char *key);\ndiff --git a/include/qapi/qmp/qlist.h b/include/qapi/qmp/qlist.h\nindex a84117e..5dc4ed9 100644\n--- a/include/qapi/qmp/qlist.h\n+++ b/include/qapi/qmp/qlist.h\n@@ -29,6 +29,14 @@ typedef struct QList {\n #define qlist_append(qlist, obj) \\\n qlist_append_obj(qlist, QOBJECT(obj))\n \n+/* Helpers for int, bool, and string */\n+#define qlist_append_int(qlist, value) \\\n+ qlist_append(qlist, qint_from_int(value))\n+#define qlist_append_bool(qlist, value) \\\n+ qlist_append(qlist, qbool_from_bool(value))\n+#define qlist_append_str(qlist, value) \\\n+ qlist_append(qlist, qstring_from_str(value))\n+\n #define QLIST_FOREACH_ENTRY(qlist, var) \\\n for ((var) = ((qlist)->head.tqh_first); \\\n (var); \\\ndiff --git a/scripts/coccinelle/qobject.cocci b/scripts/coccinelle/qobject.cocci\nindex aa899e2..97703a4 100644\n--- a/scripts/coccinelle/qobject.cocci\n+++ b/scripts/coccinelle/qobject.cocci\n@@ -2,12 +2,34 @@\n @@\n expression Obj, Key, E;\n @@\n+(\n - qdict_put_obj(Obj, Key, QOBJECT(E));\n + qdict_put(Obj, Key, E);\n+|\n+- qdict_put(Obj, Key, qint_from_int(E));\n++ qdict_put_int(Obj, Key, E);\n+|\n+- qdict_put(Obj, Key, qbool_from_bool(E));\n++ qdict_put_bool(Obj, Key, E);\n+|\n+- qdict_put(Obj, Key, qstring_from_str(E));\n++ qdict_put_str(Obj, Key, E);\n+)\n \n // Use QList macros where they make sense\n @@\n expression Obj, E;\n @@\n+(\n - qlist_append_obj(Obj, QOBJECT(E));\n + qlist_append(Obj, E);\n+|\n+- qlist_append(Obj, qint_from_int(E));\n++ qlist_append_int(Obj, E);\n+|\n+- qlist_append(Obj, qbool_from_bool(E));\n++ qlist_append_bool(Obj, E);\n+|\n+- qlist_append(Obj, qstring_from_str(E));\n++ qlist_append_str(Obj, E);\n+)\n", "prefixes": [ "16/79" ] }