Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806808/?format=api
{ "id": 806808, "url": "http://patchwork.ozlabs.org/api/patches/806808/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-11-git-send-email-mdroth@linux.vnet.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503965694-10794-11-git-send-email-mdroth@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-08-29T00:13:45", "name": "[10/79] block: Do not unref bs->file on error in BD's open", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e35e2a4153f4fcc5610655f2d5bdfd23f1b93f5a", "submitter": { "id": 5549, "url": "http://patchwork.ozlabs.org/api/people/5549/?format=api", "name": "Michael Roth", "email": "mdroth@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-11-git-send-email-mdroth@linux.vnet.ibm.com/mbox/", "series": [ { "id": 281, "url": "http://patchwork.ozlabs.org/api/series/281/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=281", "date": "2017-08-29T00:13:45", "name": "Patch Round-up for stable 2.9.1, freeze on 2017-09-04", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/281/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806808/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806808/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh8ML591Xz9rxl\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Aug 2017 10:16:46 +1000 (AEST)", "from localhost ([::1]:41876 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmUCy-0000sT-FK\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 20:16:44 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:47244)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUC3-0000oo-6K\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:15:49 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUBz-00052H-W7\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:15:47 -0400", "from mx0b-001b2d01.pphosted.com ([148.163.158.5]:40825\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <mdroth@linux.vnet.ibm.com>)\n\tid 1dmUBz-00051Z-Q8\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:15:43 -0400", "from pps.filterd (m0098414.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7T0EEWB019727\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:15:42 -0400", "from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cmsfn2vqc-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:15:41 -0400", "from localhost\n\tby e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;\n\tMon, 28 Aug 2017 18:15:41 -0600", "from b03cxnp07028.gho.boulder.ibm.com (9.17.130.15)\n\tby e32.co.us.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 18:15:39 -0600", "from b03ledav006.gho.boulder.ibm.com\n\t(b03ledav006.gho.boulder.ibm.com [9.17.130.237])\n\tby b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7T0FcMM852374; Mon, 28 Aug 2017 17:15:39 -0700", "from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D7EEEC603C;\n\tMon, 28 Aug 2017 18:15:38 -0600 (MDT)", "from localhost (unknown [9.80.85.217])\n\tby b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP id A438CC6042;\n\tMon, 28 Aug 2017 18:15:38 -0600 (MDT)" ], "From": "Michael Roth <mdroth@linux.vnet.ibm.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 28 Aug 2017 19:13:45 -0500", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "References": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17082900-0004-0000-0000-000012D6D507", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007630; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909027; UDB=6.00455849;\n\tIPR=6.00689279; \n\tBA=6.00005557; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016909;\n\tXFM=3.00000015; UTC=2017-08-29 00:15:40", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17082900-0005-0000-0000-000080E59E37", "Message-Id": "<1503965694-10794-11-git-send-email-mdroth@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_13:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=3\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708290001", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]", "X-Received-From": "148.163.158.5", "Subject": "[Qemu-devel] [PATCH 10/79] block: Do not unref bs->file on error in\n\tBD's open", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Kevin Wolf <kwolf@redhat.com>, qemu-stable@nongnu.org,\n\tMax Reitz <mreitz@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Max Reitz <mreitz@redhat.com>\n\nThe block layer takes care of removing the bs->file child if the block\ndriver's bdrv_open()/bdrv_file_open() implementation fails. The block\ndriver therefore does not need to do so, and indeed should not unless it\nsets bs->file to NULL afterwards -- because if this is not done, the\nbdrv_unref_child() in bdrv_open_inherit() will dereference the freed\nmemory block at bs->file afterwards, which is not good.\n\nWe can now decide whether to add a \"bs->file = NULL;\" after each of the\noffending bdrv_unref_child() invocations, or just drop them altogether.\nThe latter is simpler, so let's do that.\n\nCc: qemu-stable <qemu-stable@nongnu.org>\nSigned-off-by: Max Reitz <mreitz@redhat.com>\nReviewed-by: Eric Blake <eblake@redhat.com>\nReviewed-by: Stefan Hajnoczi <stefanha@redhat.com>\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>\n(cherry picked from commit de234897b60e034ba94b307fc289e2dc692c9251)\nSigned-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>\n---\n block/blkdebug.c | 4 +---\n block/blkreplay.c | 3 ---\n block/blkverify.c | 3 ---\n 3 files changed, 1 insertion(+), 9 deletions(-)", "diff": "diff --git a/block/blkdebug.c b/block/blkdebug.c\nindex 67e8024..cc4a146 100644\n--- a/block/blkdebug.c\n+++ b/block/blkdebug.c\n@@ -389,14 +389,12 @@ static int blkdebug_open(BlockDriverState *bs, QDict *options, int flags,\n } else if (align) {\n error_setg(errp, \"Invalid alignment\");\n ret = -EINVAL;\n- goto fail_unref;\n+ goto out;\n }\n \n ret = 0;\n goto out;\n \n-fail_unref:\n- bdrv_unref_child(bs, bs->file);\n out:\n if (ret < 0) {\n g_free(s->config_file);\ndiff --git a/block/blkreplay.c b/block/blkreplay.c\nindex e110211..6aa5fd4 100755\n--- a/block/blkreplay.c\n+++ b/block/blkreplay.c\n@@ -37,9 +37,6 @@ static int blkreplay_open(BlockDriverState *bs, QDict *options, int flags,\n \n ret = 0;\n fail:\n- if (ret < 0) {\n- bdrv_unref_child(bs, bs->file);\n- }\n return ret;\n }\n \ndiff --git a/block/blkverify.c b/block/blkverify.c\nindex 9a1e21c..af23281 100644\n--- a/block/blkverify.c\n+++ b/block/blkverify.c\n@@ -142,9 +142,6 @@ static int blkverify_open(BlockDriverState *bs, QDict *options, int flags,\n \n ret = 0;\n fail:\n- if (ret < 0) {\n- bdrv_unref_child(bs, bs->file);\n- }\n qemu_opts_del(opts);\n return ret;\n }\n", "prefixes": [ "10/79" ] }