Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806807/?format=api
{ "id": 806807, "url": "http://patchwork.ozlabs.org/api/patches/806807/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1503965451-59498-1-git-send-email-f.fainelli@gmail.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503965451-59498-1-git-send-email-f.fainelli@gmail.com>", "list_archive_url": null, "date": "2017-08-29T00:10:51", "name": "[net] net: dsa: Don't dereference dst->cpu_dp->netdev", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "09f2d047ba402a627452ab1a75900ec7491d8967", "submitter": { "id": 2800, "url": "http://patchwork.ozlabs.org/api/people/2800/?format=api", "name": "Florian Fainelli", "email": "f.fainelli@gmail.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1503965451-59498-1-git-send-email-f.fainelli@gmail.com/mbox/", "series": [ { "id": 280, "url": "http://patchwork.ozlabs.org/api/series/280/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=280", "date": "2017-08-29T00:10:51", "name": "[net] net: dsa: Don't dereference dst->cpu_dp->netdev", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/280/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806807/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806807/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"isbFI5kV\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh8MK1CZXz9s7v\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 29 Aug 2017 10:16:45 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751236AbdH2AQn (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 28 Aug 2017 20:16:43 -0400", "from mail-qk0-f196.google.com ([209.85.220.196]:38799 \"EHLO\n\tmail-qk0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751194AbdH2AQm (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 28 Aug 2017 20:16:42 -0400", "by mail-qk0-f196.google.com with SMTP id o63so1772448qkb.5\n\tfor <netdev@vger.kernel.org>; Mon, 28 Aug 2017 17:16:42 -0700 (PDT)", "from stb-bld-04.irv.broadcom.com ([192.19.255.250])\n\tby smtp.gmail.com with ESMTPSA id\n\ts9sm1166465qki.34.2017.08.28.17.16.38\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 28 Aug 2017 17:16:40 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=Wp3Epk76SxxG/pCP7yGwNXtnon8grdLykcLQHaNtrl4=;\n\tb=isbFI5kVjdNXsX7f8Ah9frsRpeum/7M+ggBWrtBmrH61uFEg42Vqg0b6h4nznSujET\n\tgVYedq4gXjRqHDc8PbmDF9V69JD2vU32Q3bJoFx7wb2mPw4URvTUUrUFtyDWQVtil2NF\n\tBlut9VLUsPrq5vDmdFZMo7UQaS9oJhqvY18Sbi6kp4yO8vEXTryL/7igKFms82o3vaNo\n\tzWQ9cmv74hm/04kkkin6ld3cl11aX6zFD2ro9cqlV+cykM/6xYGS5GbiQ1ksCRprfOZz\n\tkCz1Fe2J3zgP0WoFCzMgD+8vankLlpBHK6VP6sfclVlmOyvGzV7+R3RUCCl/2qRDXXM4\n\t0djw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=Wp3Epk76SxxG/pCP7yGwNXtnon8grdLykcLQHaNtrl4=;\n\tb=MmJ0heh7RrBU4o8HPchS0oZNhgMLYHZUB3K6Hv8oeRQvCL/DT09kx7M4jHnzCkQO5V\n\tAHb4OjCXZoAI+IaiWCscbm93TRXdzGcI7JIuIsMhs7f1WhDcIQ4bOxMDzvH1ax7Q0aw4\n\tQd5VDziiAoM12LGcgdmyGd285iXCR0xILqSmipZ8n/Gp2IWMC7aeehOBmySWfaHusFHC\n\tfqwusKsOVG/zM6XFzFZd+2ER5Yh1FLNBMx4IWu3w+FFJ1wtopIIIkoN6ocNoYgw+W8ut\n\tHaShRp5/20NKiNpg2dkofWPiNaWmwQZK7JLHxr2i43KC6wzJGKMAYIT7Ie9VB4f5T44i\n\t14cQ==", "X-Gm-Message-State": "AHYfb5ipm10oZP+a+Dgt89GCZY4Ji4BnBgcJrqZkysxhVAD76Np9fW4+\n\ti/jnNL/0OiLIwC4z1zQ=", "X-Received": "by 10.55.5.133 with SMTP id 127mr3225024qkf.79.1503965801255;\n\tMon, 28 Aug 2017 17:16:41 -0700 (PDT)", "From": "Florian Fainelli <f.fainelli@gmail.com>", "To": "netdev@vger.kernel.org", "Cc": "davem@davemloft.net, andrew@lunn.ch,\n\tvivien.didelot@savoirfairelinux.com, dan.carpenter@oracle.com,\n\tFlorian Fainelli <f.fainelli@gmail.com>", "Subject": "[PATCH net] net: dsa: Don't dereference dst->cpu_dp->netdev", "Date": "Mon, 28 Aug 2017 17:10:51 -0700", "Message-Id": "<1503965451-59498-1-git-send-email-f.fainelli@gmail.com>", "X-Mailer": "git-send-email 1.9.1", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "If we do not have a master network device attached dst->cpu_dp will be\nNULL and accessing cpu_dp->netdev will create a trace similar to the one\nbelow. The correct check is on dst->cpu_dp period.\n\n[ 1.004650] DSA: switch 0 0 parsed\n[ 1.008078] Unable to handle kernel NULL pointer dereference at\nvirtual address 00000010\n[ 1.016195] pgd = c0003000\n[ 1.018918] [00000010] *pgd=80000000004003, *pmd=00000000\n[ 1.024349] Internal error: Oops: 206 [#1] SMP ARM\n[ 1.029157] Modules linked in:\n[ 1.032228] CPU: 0 PID: 1 Comm: swapper/0 Not tainted\n4.13.0-rc6-00071-g45b45afab9bd-dirty #7\n[ 1.040772] Hardware name: Broadcom STB (Flattened Device Tree)\n[ 1.046704] task: ee08f840 task.stack: ee090000\n[ 1.051258] PC is at dsa_register_switch+0x5e0/0x9dc\n[ 1.056234] LR is at dsa_register_switch+0x5d0/0x9dc\n[ 1.061211] pc : [<c08fb28c>] lr : [<c08fb27c>] psr: 60000213\n[ 1.067491] sp : ee091d88 ip : 00000000 fp : 0000000c\n[ 1.072728] r10: 00000000 r9 : 00000001 r8 : ee208010\n[ 1.077965] r7 : ee2b57b0 r6 : ee2b5780 r5 : 00000000 r4 :\nee208e0c\n[ 1.084506] r3 : 00000000 r2 : 00040d00 r1 : 2d1b2000 r0 :\n00000016\n[ 1.091050] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM\nSegment user\n[ 1.098199] Control: 32c5387d Table: 00003000 DAC: fffffffd\n[ 1.103957] Process swapper/0 (pid: 1, stack limit = 0xee090210)\n\nReported-by: Dan Carpenter <dan.carpenter@oracle.com>\nFixes: 6d3c8c0dd88a (\"net: dsa: Remove master_netdev and use dst->cpu_dp->netdev\")\nSigned-off-by: Florian Fainelli <f.fainelli@gmail.com>\n---\n net/dsa/dsa2.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c\nindex c442051d5a55..20bc9c56fca0 100644\n--- a/net/dsa/dsa2.c\n+++ b/net/dsa/dsa2.c\n@@ -577,7 +577,7 @@ static int dsa_dst_parse(struct dsa_switch_tree *dst)\n \t\t\treturn err;\n \t}\n \n-\tif (!dst->cpu_dp->netdev) {\n+\tif (!dst->cpu_dp) {\n \t\tpr_warn(\"Tree has no master device\\n\");\n \t\treturn -EINVAL;\n \t}\n", "prefixes": [ "net" ] }