Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806796/?format=api
{ "id": 806796, "url": "http://patchwork.ozlabs.org/api/patches/806796/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-arc/patch/1503957838-21505-2-git-send-email-vgupta@synopsys.com/", "project": { "id": 48, "url": "http://patchwork.ozlabs.org/api/projects/48/?format=api", "name": "Linux ARC development", "link_name": "linux-arc", "list_id": "linux-snps-arc.lists.infradead.org", "list_email": "linux-snps-arc@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503957838-21505-2-git-send-email-vgupta@synopsys.com>", "list_archive_url": null, "date": "2017-08-28T22:03:58", "name": "ARCv2: SMP: Mask only private-per-core IRQ lines on boot at core intc", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "69f14b76080fcbc6668dfb733b273d7d940b3c9d", "submitter": { "id": 26707, "url": "http://patchwork.ozlabs.org/api/people/26707/?format=api", "name": "Vineet Gupta", "email": "Vineet.Gupta1@synopsys.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-arc/patch/1503957838-21505-2-git-send-email-vgupta@synopsys.com/mbox/", "series": [ { "id": 269, "url": "http://patchwork.ozlabs.org/api/series/269/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-arc/list/?series=269", "date": "2017-08-28T22:03:58", "name": "ARCv2: SMP: Mask only private-per-core IRQ lines on boot at core intc", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/269/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806796/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806796/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"O4DFWozM\"; \n\tdkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh5Qv5yXZz9s72\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Aug 2017 08:04:39 +1000 (AEST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dmS98-0007xJ-CN; Mon, 28 Aug 2017 22:04:38 +0000", "from smtprelay2.synopsys.com ([198.182.60.111]\n\thelo=smtprelay.synopsys.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dmS94-0007m1-MF for linux-snps-arc@lists.infradead.org;\n\tMon, 28 Aug 2017 22:04:36 +0000", "from mailhost.synopsys.com (mailhost2.synopsys.com [10.13.184.66])\n\tby smtprelay.synopsys.com (Postfix) with ESMTP id 5920010C0BBB;\n\tMon, 28 Aug 2017 15:04:13 -0700 (PDT)", "from mailhost.synopsys.com (localhost [127.0.0.1])\n\tby mailhost.synopsys.com (Postfix) with ESMTP id 42655B8A;\n\tMon, 28 Aug 2017 15:04:13 -0700 (PDT)", "from US01WEHTC2.internal.synopsys.com\n\t(us01wehtc2.internal.synopsys.com [10.12.239.237])\n\tby mailhost.synopsys.com (Postfix) with ESMTP id 352EEB87;\n\tMon, 28 Aug 2017 15:04:13 -0700 (PDT)", "from IN01WEHTCB.internal.synopsys.com (10.144.199.106) by\n\tUS01WEHTC2.internal.synopsys.com (10.12.239.237) with Microsoft SMTP\n\tServer (TLS) id 14.3.266.1; Mon, 28 Aug 2017 15:04:13 -0700", "from IN01WEHTCA.internal.synopsys.com (10.144.199.104) by\n\tIN01WEHTCB.internal.synopsys.com (10.144.199.105) with Microsoft SMTP\n\tServer (TLS) id 14.3.266.1; Tue, 29 Aug 2017 03:34:11 +0530", "from vineetg-Latitude-E7450.internal.synopsys.com (10.10.161.108)\n\tby IN01WEHTCA.internal.synopsys.com (10.144.199.243) with Microsoft\n\tSMTP Server (TLS) id 14.3.266.1; Tue, 29 Aug 2017 03:34:11 +0530" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=d56U86NXLbP60tBRwyTmRXkST0qVGKdq8h9GDKlnjYI=;\n\tb=O4DFWozMkjfTAU\n\thL/67zlfFZO61piSGHm9l6f+yYCNMI4ntfSYJvesFAu7tCLuEpxkrlSFMViZ0fsAUqfrPB1S+khs4\n\tVXpTBZ4xAS9FoXMMSH9b+Atjb7zvWAVYWjULGZvhsrTSAkJOq3miOucOKDi7HCDqOzetI2VPmGoNc\n\tw0jUCI+qVOUBX9LkrdAOtMdyMwWMgvMVP6X4/QIc3Qp7uVoZv0QW6HXZB9jK+qPO77VG/hKY5UjZP\n\tJPYZY75EXAE/R7JumDMIXVLvKoen1B1su2jmQmF1mC/AVFIR/GbiX97abfkpas3/ovxjJJR30yQeS\n\tJT4bGyEm+aNE+irpkDDA==;", "From": "Vineet Gupta <Vineet.Gupta1@synopsys.com>", "To": "Linus Torvalds <torvalds@linux-foundation.org>", "Subject": "[PATCH] ARCv2: SMP: Mask only private-per-core IRQ lines on boot at\n\tcore intc", "Date": "Mon, 28 Aug 2017 15:03:58 -0700", "Message-ID": "<1503957838-21505-2-git-send-email-vgupta@synopsys.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1503957838-21505-1-git-send-email-vgupta@synopsys.com>", "References": "<1503957838-21505-1-git-send-email-vgupta@synopsys.com>", "MIME-Version": "1.0", "X-Originating-IP": "[10.10.161.108]", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20170828_150434_790334_364385B2 ", "X-CRM114-Status": "GOOD ( 11.41 )", "X-Spam-Score": "-1.9 (-)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [198.182.60.111 listed in list.dnswl.org]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]", "X-BeenThere": "linux-snps-arc@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "Linux on Synopsys ARC Processors\n\t<linux-snps-arc.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-snps-arc>, \n\t<mailto:linux-snps-arc-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-snps-arc/>", "List-Post": "<mailto:linux-snps-arc@lists.infradead.org>", "List-Help": "<mailto:linux-snps-arc-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-snps-arc>, \n\t<mailto:linux-snps-arc-request@lists.infradead.org?subject=subscribe>", "Cc": "Vineet Gupta <Vineet.Gupta1@synopsys.com>,\n\tlinux-snps-arc@lists.infradead.org, Alexey.Brodkin@synopsys.com,\n\tlinux-kernel@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-snps-arc\" <linux-snps-arc-bounces@lists.infradead.org>", "Errors-To": "linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "From: Alexey Brodkin <abrodkin@synopsys.com>\n\nRecent commit a8ec3ee861b6 \"arc: Mask individual IRQ lines during core INTC init\"\nbreaks interrupt handling on ARCv2 SMP systems.\n\nThat commit masked all interrupts at onset, as some controllers on some boards\n(customer as well as internal), would assert interrutps early before any handlers\nwere installed. For SMP systems, the masking was done at each cpu's core-intc.\nLater, when the IRQ was actually requested, it was unmasked, but only on the\nrequesting cpu. For \"common\" interrupts, which were wired up from the\n2nd level IDU intc, this was as issue as they needed to be enabled on ALL\nthe cpus (given that IDU IRQs are by default served Round Robin across\ncpus)\n\nSo fix that by NOT masking \"common\" interrupts at core-intc, but instead\nat the 2nd level IDU intc (latter already being done in idu_of_init())\n\nFixes: a8ec3ee861b6 (\"arc: Mask individual IRQ lines during core INTC init\")\nSigned-off-by: Alexey Brodkin <abrodkin@synopsys.com>\nSigned-off-by: Vineet Gupta <vgupta@synopsys.com>\n[vgupta: reworked changelog, removed the extraneous idu_irq_mask_raw()]\n\nSigned-off-by: Vineet Gupta <vgupta@synopsys.com>\n---\n arch/arc/kernel/intc-arcv2.c | 11 +++++++++--\n arch/arc/kernel/intc-compact.c | 2 +-\n 2 files changed, 10 insertions(+), 3 deletions(-)", "diff": "diff --git a/arch/arc/kernel/intc-arcv2.c b/arch/arc/kernel/intc-arcv2.c\nindex cf90714a676d..067ea362fb3e 100644\n--- a/arch/arc/kernel/intc-arcv2.c\n+++ b/arch/arc/kernel/intc-arcv2.c\n@@ -75,13 +75,20 @@ void arc_init_IRQ(void)\n \t * Set a default priority for all available interrupts to prevent\n \t * switching of register banks if Fast IRQ and multiple register banks\n \t * are supported by CPU.\n-\t * Also disable all IRQ lines so faulty external hardware won't\n+\t * Also disable private-per-core IRQ lines so faulty external HW won't\n \t * trigger interrupt that kernel is not ready to handle.\n \t */\n \tfor (i = NR_EXCEPTIONS; i < irq_bcr.irqs + NR_EXCEPTIONS; i++) {\n \t\twrite_aux_reg(AUX_IRQ_SELECT, i);\n \t\twrite_aux_reg(AUX_IRQ_PRIORITY, ARCV2_IRQ_DEF_PRIO);\n-\t\twrite_aux_reg(AUX_IRQ_ENABLE, 0);\n+\n+\t\t/*\n+\t\t * Only mask cpu private IRQs here.\n+\t\t * \"common\" interrupts are masked at IDU, otherwise it would\n+\t\t * need to be unmasked at each cpu, with IPIs\n+\t\t */\n+\t\tif (i < FIRST_EXT_IRQ)\n+\t\t\twrite_aux_reg(AUX_IRQ_ENABLE, 0);\n \t}\n \n \t/* setup status32, don't enable intr yet as kernel doesn't want */\ndiff --git a/arch/arc/kernel/intc-compact.c b/arch/arc/kernel/intc-compact.c\nindex cef388025adf..47b421fa0147 100644\n--- a/arch/arc/kernel/intc-compact.c\n+++ b/arch/arc/kernel/intc-compact.c\n@@ -27,7 +27,7 @@\n */\n void arc_init_IRQ(void)\n {\n-\tint level_mask = 0, i;\n+\tunsigned int level_mask = 0, i;\n \n /* Is timer high priority Interrupt (Level2 in ARCompact jargon) */\n \tlevel_mask |= IS_ENABLED(CONFIG_ARC_COMPACT_IRQ_LEVELS) << TIMER0_IRQ;\n", "prefixes": [] }