Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806791/?format=api
{ "id": 806791, "url": "http://patchwork.ozlabs.org/api/patches/806791/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1503956111-36652-20-git-send-email-keescook@chromium.org/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503956111-36652-20-git-send-email-keescook@chromium.org>", "list_archive_url": null, "date": "2017-08-28T21:35:00", "name": "[v2,19/30] ip: Define usercopy region in IP proto slab cache", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "c751b086183860d3a92f4fff7a33be227ca649fc", "submitter": { "id": 10641, "url": "http://patchwork.ozlabs.org/api/people/10641/?format=api", "name": "Kees Cook", "email": "keescook@chromium.org" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1503956111-36652-20-git-send-email-keescook@chromium.org/mbox/", "series": [ { "id": 266, "url": "http://patchwork.ozlabs.org/api/series/266/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=266", "date": "2017-08-28T21:35:01", "name": null, "version": 2, "mbox": "http://patchwork.ozlabs.org/series/266/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806791/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806791/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"KzjyIwiN\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh5620yy7z9t5g\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 29 Aug 2017 07:50:02 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751774AbdH1Vov (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 28 Aug 2017 17:44:51 -0400", "from mail-pg0-f41.google.com ([74.125.83.41]:33209 \"EHLO\n\tmail-pg0-f41.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751398AbdH1Vn4 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 28 Aug 2017 17:43:56 -0400", "by mail-pg0-f41.google.com with SMTP id t3so5074721pgt.0\n\tfor <netdev@vger.kernel.org>; Mon, 28 Aug 2017 14:43:55 -0700 (PDT)", "from www.outflux.net\n\t(173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133])\n\tby smtp.gmail.com with ESMTPSA id\n\tf17sm1999132pff.90.2017.08.28.14.43.52\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 28 Aug 2017 14:43:54 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=vxhon9t2UjiizQZuDjtE51VC0d5DMIosc49T7BwPFrA=;\n\tb=KzjyIwiNyDaebElkH5e2NUMCR+iKci+g9lzyVAbBGvZQ6ubvJSmIX626NYztERjj4J\n\tBTjIDWuDPAVB5cTwk5khZD2FZ5T+4VtoWBz1vvANmeW4T+bWXzfs366JK5siH0HRGNYg\n\tmZswoQIBaRUESV4i3oty/wdHWihgJeyEg86fk=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=vxhon9t2UjiizQZuDjtE51VC0d5DMIosc49T7BwPFrA=;\n\tb=bjvMVmvtpGuJnmHIWTOUqD26vEgOnR6QDq0us2kfbR9oZ/qkrOtPVvTIs5xaU71xBE\n\t4ckGyqgklmtW+amcJz+yfdkcBoC+JG+RFRT0H4PdreVvkJxeh/qGJ0knOEkJhiLVhdK1\n\t5N5rdMsS60+kaE2As5e8Vksx1hZlls9t84MRDMYrppEYMP/nD0ASD73oBVDZ3l9Q+yB5\n\tLynjLPbaep8wmuBpQm1Rzai6dS97cA4JEhNTtKcNRbfEzl7hrqoUtvxpNdFGQC2k9jEA\n\tu0WP4irmfOoI7GR82NKo+sH3G2dHVrPeWZ4yiSFPu5ciObp/lU2ny2X9itTq1wk4QQAP\n\tzE/g==", "X-Gm-Message-State": "AHYfb5iUtLRaOvg5QlazJDMQO7P/5cSQBxy8TGozY6/s6P/w+UcMK1Ks\n\tp4E1+4G4RqxdRIwLvrgHUA==", "X-Received": "by 10.84.211.137 with SMTP id c9mr2420469pli.356.1503956635648; \n\tMon, 28 Aug 2017 14:43:55 -0700 (PDT)", "From": "Kees Cook <keescook@chromium.org>", "To": "linux-kernel@vger.kernel.org", "Cc": "Kees Cook <keescook@chromium.org>, David Windsor <dave@nullcore.net>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tAlexey Kuznetsov <kuznet@ms2.inr.ac.ru>,\n\tHideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,\n\tnetdev@vger.kernel.org, linux-mm@kvack.org,\n\tkernel-hardening@lists.openwall.com", "Subject": "[PATCH v2 19/30] ip: Define usercopy region in IP proto slab cache", "Date": "Mon, 28 Aug 2017 14:35:00 -0700", "Message-Id": "<1503956111-36652-20-git-send-email-keescook@chromium.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1503956111-36652-1-git-send-email-keescook@chromium.org>", "References": "<1503956111-36652-1-git-send-email-keescook@chromium.org>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: David Windsor <dave@nullcore.net>\n\nThe ICMP filters for IPv4 and IPv6 raw sockets need to be copied to/from\nuserspace. In support of usercopy hardening, this patch defines a region\nin the struct proto slab cache in which userspace copy operations are\nallowed.\n\nexample usage trace:\n\n net/ipv4/raw.c:\n raw_seticmpfilter(...):\n ...\n copy_from_user(&raw_sk(sk)->filter, ..., optlen)\n\n raw_geticmpfilter(...):\n ...\n copy_to_user(..., &raw_sk(sk)->filter, len)\n\n net/ipv6/raw.c:\n rawv6_seticmpfilter(...):\n ...\n copy_from_user(&raw6_sk(sk)->filter, ..., optlen)\n\n rawv6_geticmpfilter(...):\n ...\n copy_to_user(..., &raw6_sk(sk)->filter, len)\n\nThis region is known as the slab cache's usercopy region. Slab caches can\nnow check that each copy operation involving cache-managed memory falls\nentirely within the slab's usercopy region.\n\nThis patch is modified from Brad Spengler/PaX Team's PAX_USERCOPY\nwhitelisting code in the last public patch of grsecurity/PaX based on my\nunderstanding of the code. Changes or omissions from the original code are\nmine and don't reflect the original grsecurity/PaX code.\n\nSigned-off-by: David Windsor <dave@nullcore.net>\n[kees: split from network patch, provide usage trace]\nCc: \"David S. Miller\" <davem@davemloft.net>\nCc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>\nCc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>\nCc: netdev@vger.kernel.org\nSigned-off-by: Kees Cook <keescook@chromium.org>\n---\n net/ipv4/raw.c | 2 ++\n net/ipv6/raw.c | 2 ++\n 2 files changed, 4 insertions(+)", "diff": "diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c\nindex b0bb5d0a30bd..6c7f8d2eb3af 100644\n--- a/net/ipv4/raw.c\n+++ b/net/ipv4/raw.c\n@@ -964,6 +964,8 @@ struct proto raw_prot = {\n \t.hash\t\t = raw_hash_sk,\n \t.unhash\t\t = raw_unhash_sk,\n \t.obj_size\t = sizeof(struct raw_sock),\n+\t.useroffset\t = offsetof(struct raw_sock, filter),\n+\t.usersize\t = sizeof_field(struct raw_sock, filter),\n \t.h.raw_hash\t = &raw_v4_hashinfo,\n #ifdef CONFIG_COMPAT\n \t.compat_setsockopt = compat_raw_setsockopt,\ndiff --git a/net/ipv6/raw.c b/net/ipv6/raw.c\nindex 60be012fe708..27dd9a5f71c6 100644\n--- a/net/ipv6/raw.c\n+++ b/net/ipv6/raw.c\n@@ -1265,6 +1265,8 @@ struct proto rawv6_prot = {\n \t.hash\t\t = raw_hash_sk,\n \t.unhash\t\t = raw_unhash_sk,\n \t.obj_size\t = sizeof(struct raw6_sock),\n+\t.useroffset\t = offsetof(struct raw6_sock, filter),\n+\t.usersize\t = sizeof_field(struct raw6_sock, filter),\n \t.h.raw_hash\t = &raw_v6_hashinfo,\n #ifdef CONFIG_COMPAT\n \t.compat_setsockopt = compat_rawv6_setsockopt,\n", "prefixes": [ "v2", "19/30" ] }