Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806718/?format=api
{ "id": 806718, "url": "http://patchwork.ozlabs.org/api/patches/806718/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/f9da8832eb2534b18fe228b736aac99e63279162.1503945861.git.pavel.belous@aquantia.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<f9da8832eb2534b18fe228b736aac99e63279162.1503945861.git.pavel.belous@aquantia.com>", "list_archive_url": null, "date": "2017-08-28T18:52:10", "name": "[net,v2,3/6] net:ethernet:aquantia: Workaround for HW checksum bug.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c366a1adbb53628277c5c29ed873a9d05c430ffd", "submitter": { "id": 70953, "url": "http://patchwork.ozlabs.org/api/people/70953/?format=api", "name": "Pavel Belous", "email": "Pavel.Belous@aquantia.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/f9da8832eb2534b18fe228b736aac99e63279162.1503945861.git.pavel.belous@aquantia.com/mbox/", "series": [ { "id": 240, "url": "http://patchwork.ozlabs.org/api/series/240/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=240", "date": "2017-08-28T18:52:07", "name": "net:ethernet:aquantia: Atlantic driver Update 2017-08-23", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/240/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806718/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806718/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=AQUANTIA1COM.onmicrosoft.com\n\theader.i=@AQUANTIA1COM.onmicrosoft.com header.b=\"eFEIJNMB\"; \n\tdkim-atps=neutral", "spf=none (sender IP is )\n\tsmtp.mailfrom=Pavel.Belous@aquantia.com; " ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh1B935M1z9s9Y\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 29 Aug 2017 04:53:21 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751422AbdH1SxT (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 28 Aug 2017 14:53:19 -0400", "from mail-sn1nam01on0065.outbound.protection.outlook.com\n\t([104.47.32.65]:55610\n\t\"EHLO NAM01-SN1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751306AbdH1SxS (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tMon, 28 Aug 2017 14:53:18 -0400", "from atltest07.rdc.aquantia.com (83.149.43.106) by\n\tCY1PR07MB2554.namprd07.prod.outlook.com (10.167.16.21) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1385.9; Mon, 28 Aug 2017 18:53:07 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=BtaUgbxUQaTA0hTX28uR1k1+CZzV+10k0W+kIEJ+4hg=;\n\tb=eFEIJNMBgAxDRjS5tnw8BvOraQRPaGGF0GeqFppOaQbE+5yAaQlZ3U0sPIxv7H7w8O5pN37F/Kz2lFASxJm42Egetu0tjpPYqqea0zL+WYUFsDlvkWb5rcajUHkEwF1lKxN37cytLw4KSiviib7DqRzz6xpIxk1qIIv+Z+hZO7I=", "From": "Pavel Belous <Pavel.Belous@aquantia.com>", "To": "\"David S . Miller\" <davem@davemloft.net>", "Cc": "netdev@vger.kernel.org, David Arcari <darcari@redhat.com>,\n\tIgor Russkikh <Igor.Russkikh@aquantia.com>,\n\tNadezhda Krupnina <Nadezhda.Krupnina@aquantia.com>,\n\tSimon Edelhaus <simon.edelhaus@aquantia.com>,\n\tPavel Belous <pavel.belous@aquantia.com>,\n\tPavel Belous <Pavel.Belous@aquantia.com>", "Subject": "[PATCH net v2 3/6] net:ethernet:aquantia: Workaround for HW\n\tchecksum bug.", "Date": "Mon, 28 Aug 2017 21:52:10 +0300", "Message-Id": "<f9da8832eb2534b18fe228b736aac99e63279162.1503945861.git.pavel.belous@aquantia.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<cover.1503945861.git.pavel.belous@aquantia.com>", "References": "<cover.1503945861.git.pavel.belous@aquantia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[83.149.43.106]", "X-ClientProxiedBy": "HE1PR0202CA0019.eurprd02.prod.outlook.com (10.168.182.29)\n\tTo CY1PR07MB2554.namprd07.prod.outlook.com (10.167.16.21)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "ea30b4d8-d2e3-414b-ff88-08d4ee4609d4", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:CY1PR07MB2554; ", "X-Microsoft-Exchange-Diagnostics": [ "1; CY1PR07MB2554;\n\t3:8XvT0vATn9sV41lS6L40E2iOazUf2fqrMmVbpnFzwrdZxLNfhlIF09lj90g/ykNlpfCIW6qa8EAWO3kJiRnQCHNdKf59t7bdLwTH+j1EzqrxyIJi8utVdHS2f0XlkyS1cyHKq6NANYqWjdqHpBPODszgh7KIlYYwpIaTkfXFZdJOj9OjFQo/hQ12SucnpKy8Wow5qr+fAAYWDVbqm4S8J6gKLceiVFvFkRyMA1bZUOvKXgjaXy5YbtlaWh5VNMKl;\n\t25:TITwk3vZDf50RuC2+IIUA8ICXiIYtdhuvsk3et9w3Df9Fv20Ymn+1XTkMKHIUUXxAzCVQp4EKjDlbKNFF+YWoFXBiOZwTBkhGXB8R1YlWyjKrSxYZ4Eqoi5wuF0G9TbXTqiTRqjuhvIru2mMRpFrw1fRZy+WSrGSTJZ0eiWlynNbJ2AvJEKD8ZBxxOm8WFyoGySzb0O/1VVY2atfKO/W6bATXiDK14nbxd22TvRENOKbkv/L5FKAmcVZhqBCy2Gx7rWTbP3waD89wryEQdup3hK9myG6ImD5IqiRkZ9FySjRWZ+Ya10dEUQ+/91guBjkyYwF0LVPJJh7bGa4VDTRiQ==;\n\t31:RQe8bUKYfF5fAlPIMwnWvw/XprlOzqq/UUxiOjIcAQ0P8Vn5jabtoykguc+yOA4E+rsVLScCoWaEG7ZXpxUdiqUs/1lH2uCgdW76RyZhrASx4npfonKh5qTXgxX/T8PQDv5m/WlQbEzNvRf0iGwfOjCRVysNrTfs3sV1Ow3czUYBoQNTAYsmsUW3teshqLFI/WYqSl+VYGLgGrYYZHQv9vyPqYrUe+4KUx4dtdmHG0k=", "1; CY1PR07MB2554;\n\t20:aHZFFPRcbZL76/7Eac7NmriOP/uAgDS9ZVOuSmmFWiUv8ZVMYAcaoIiLrR3uoHV1iaEM+916fIw2p/VhrX6Z0MOXoeEKrFSfxMk/bcleebU8Lnpys7kNtiY6lMhmvSwVjo0MeTg03kB9UMuyuy3zo2LN/gQAGhbO0dZqlxjz74zPsS2O/vee+aELvNZLbskjzrS6F1Im7tDowcpakirg4jzIY9l1lFFNue7xTKcSquhGFw5qBGCBSh8iwOpIbFpH3oF9J1Dvu/xUao/7olL9XtXjvKsKg76HQLZPXC9PXbxmMM7RAvyXwN1VFGTw572wLMLWE0U/xKiR0DYuj92+xrSeJw7Lf2+NneoGK0zlQ5sb6vqNc7LIbaNa2Qf/cdunPsWdam97OZ9JTr7dBqgXAPeqq2g4ZtDIaVRGfa8+piaaN8osxOtkoN5LG6p1vytsNYmQqjfK4Rblf2X0pYYPHCOm/3dACffEaTvXW9ej+Hi8YXNaGi/ySMtJd+qWyBxX;\n\t4:4D1verGgOQ8sns9CgXI7mtLLZBDFpHnSKo+o/pezMSf9G6lQlNWS7wpZnH3pmm3tqBIiPnW9ro7dzTdAQy7udfew1N1UdGUCHdzvkdM8liD+DennkZTTpZHwQnFXMlmcgeS/BIkM+DaJT6ZhsrWE9OUr1KDD2ndQexOscPOv4JtgQlDNv1R7lAkGoq4gu9kIHHVGxkuh9/Zc5Wnv/yjJUNLtIGs6rk8rLafrHSPAqzvT85Il0E4hB06EYaed27gN", "1; CY1PR07MB2554;\n\t23:mJCYKmFjUhEEAmEzM6esc2qVTTdIwvY5rjLe2yvWhVgxxcJrnLF+4ZhTd76kunu2DFUuH3crAzi3qus5fFC9o9pLYSDPNiWAuhqWFweyrxCoZuaBT82ngV2FPpFrLsELVsizaq12i/nFywp9MkVfrg3dITRi8iVcFbEx6fcntpfb1IKIGzXHNcEMO80blF+Xr0FWisFoAt2khhM6WQKhIPvN6i6HjUYpHgImjHzljLNACmg78Oa7fv1nWWrXZetWDI2JmgBcDyXDuOcQkMI/GFVv1vxITeZWW9J6YbumahLnpPCBjrnT2o4Moab/99Cwz8lZKKyP4I+Jikk+wj9akYB16+7gs9wXvagammxOmdubKehs9paZPY4Bau44+tVOdGVJD0g+/+Csh5K80yE4ps+QeF0JxtqbyMyufKgOiYsLjD3zrzQu47Bq+Nv1Q2QfRjPWLutFuM1mVVDkiumM+PUdk8ZsQl7eIiUjtZkizRVunMvMa83J0N+nTRWBK8A/8chLUu71bBunJtx/PzcL/pyobTnM9zLTBP3Xi8XgU0IGmCL3oSRUlWNiu8EPLTWZJPDE9ZuGzCgQXVutpOYsclayebnfDoJwBxbfrFIh6Bb7Ptv7nKMmrCYs8EX2w1X4uAt1SJAhDpnkne7x8z+GwjLzxGb+QgIC2guIr9J8hNrBiqhw8FP08MaopQ95rIvWkVy9nfpXTwN62Je0rOnpx+X4rkZz4EP++murbXkz5LiKNMu7DelM8EiPrWTPMVSxsJxJwgVzfwvi6e8uzbYc11FhCIg6Na9IhT+jhec0xvwH53VQbqNc0bQGqmwJFyIuEvNqQGPc/EApJrrbeiIIkov+GGxzrEh0fCRDawEVkywwsrX9vCrt9E1UHJ148pzf8Q8GRYCbwZEWtCrbZTJU5r4u5CilrVX13rcJ4I/q8ds0Y2YiAkxXoMT16Rwjfhsk4eWSNgskWhpPJbevYQ3PzXbxEQtHFqELeyzF7RwTolHeNDAmsvs+lXeWB7Wj4aLSnTcTmsH/Yi2HCs9YzkvoltQwvUtjdeuzGgWskCc8M4u909QLdX9NQRvBljPTtvW7JA2Pb2Dw+SML8pe5T3Gj2BlYCW+fyHBFd5nPljD7Kf7Q25IGUJL3E2Zvti+TzaJrnzPiVpk9BFjfBWdS9mhOdg==", "1; CY1PR07MB2554;\n\t6:R+bRtjGlBe9FfVdGR/oh4ds9ZmIDH4J7VrG01a7/TobmuPNq4UYWHuxzpDGlpGS3CQKyNOr8C3mWsaxZXwH8VPre2msqqHy81VrNkaOkwQyEDa/HGOKzkkFVTkrtRbaBtuGKLxiM58DY9YKEbQ6IApOCKX0HhrlmQiza6RNVHlFSFz6XtGsVzkbLgkQnYmoruM6qm60pVY8D+sI5xRWdZsMXr9S/NJFynjD2+MFSeZr+Sh4sJ8mr6LxDl6BAYcdcqLFT5ggmVBzo4FTbcIIVDhgR0E4eEdxIwf7hutmZ6Bh7jrzaDPq9omACqwOptUGysJfExJZ5HX/SLnayg54G8g==;\n\t5:FZ7D+qb7zpdIAb3MsmtotLCDkCzDt9KX83/EomEzfIGfTMn90CMf5+gXvlklLSxWmjOhsAuDq8m6kGbgjA7+fdzKkma1uRj4NozYk8j1hVATfck7SH0ZPOBBG1sjOU3llHkfjpHbos9TMk9Kuz1Fhg==;\n\t24:/ZOb8O6imaDwa5Yy5xmVn1c7odCRAKZD0VgGDPAG53AyHFjHjI2WcswEOggU4yac3Yv3sno2XW44dxtd+FSiyjc1E4y0sx28JHgmdJZh9Ak=;\n\t7:GYbASzUNFzSNcIYZBSyoeZAmmVbm2x/I5mHRVPpUnDF5hb3mn8QwEqVitTV2oqRkysAgcb6lMSgfETmAOzZnWgGXAgDJkFLrB+WJ7UfkvfhCUv30QoNDieAEJu8QZmjgsoi+3LW1/kYIPuEqY4AmFPou+ibQt1LR44Fqoh1T3U78a/KnofRre1rMeMLxmL4kOClkB0a+sJszctu76lgO4rh3MKjOOCWPtrXfBucJZ+w=" ], "X-MS-TrafficTypeDiagnostic": "CY1PR07MB2554:", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-Microsoft-Antispam-PRVS": "<CY1PR07MB255483E83A3610E100BDDFFFE19E0@CY1PR07MB2554.namprd07.prod.outlook.com>", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:CY1PR07MB2554; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:CY1PR07MB2554; ", "X-Forefront-PRVS": "0413C9F1ED", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(7370300001)(4630300001)(6009001)(189002)(199003)(54906002)(6916009)(50226002)(189998001)(36756003)(2950100002)(5003940100001)(106356001)(575784001)(25786009)(86362001)(33646002)(7736002)(8676002)(66066001)(81156014)(305945005)(81166006)(50466002)(48376002)(47776003)(53936002)(478600001)(118296001)(72206003)(107886003)(76176999)(50986999)(2906002)(68736007)(6486002)(105586002)(6116002)(110136004)(6666003)(5660300001)(3846002)(7350300001)(4326008)(101416001)(97736004)(42186005);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2554;\n\tH:atltest07.rdc.aquantia.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ", "Received-SPF": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Aug 2017 18:53:07.4438\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY1PR07MB2554", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Pavel Belous <pavel.belous@aquantia.com>\n\nThe hardware has the HW Checksum Offload bug when small\nTCP patckets (with length <= 60 bytes) has wrong \"checksum valid\" bit.\n\nThe solution is - ignore checksum valid bit for small packets\n(with length <= 60 bytes) and mark this as CHECKSUM_NONE to allow\nnetwork stack recalculate checksum itself.\n\nFixes: ccf9a5ed14be (\"net: ethernet: aquantia: Atlantic A0 and B0 specific functions.\")\nSigned-off-by: Pavel Belous <Pavel.Belous@aquantia.com>\n---\n drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c | 6 ++++++\n drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c | 6 ++++++\n 2 files changed, 12 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c\nindex faeb493..c5a02df 100644\n--- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c\n+++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c\n@@ -629,6 +629,12 @@ static int hw_atl_a0_hw_ring_rx_receive(struct aq_hw_s *self,\n \t\t\t\tbuff->is_udp_cso = (is_err & 0x10U) ? 0 : 1;\n \t\t\telse if (0x0U == (pkt_type & 0x1CU))\n \t\t\t\tbuff->is_tcp_cso = (is_err & 0x10U) ? 0 : 1;\n+\n+\t\t\t/* Checksum offload workaround for small packets */\n+\t\t\tif (rxd_wb->pkt_len <= 60) {\n+\t\t\t\tbuff->is_ip_cso = 0U;\n+\t\t\t\tbuff->is_cso_err = 0U;\n+\t\t\t}\n \t\t}\n \n \t\tis_err &= ~0x18U;\ndiff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c\nindex 1bceb73..21784cc 100644\n--- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c\n+++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c\n@@ -645,6 +645,12 @@ static int hw_atl_b0_hw_ring_rx_receive(struct aq_hw_s *self,\n \t\t\t\tbuff->is_udp_cso = buff->is_cso_err ? 0U : 1U;\n \t\t\telse if (0x0U == (pkt_type & 0x1CU))\n \t\t\t\tbuff->is_tcp_cso = buff->is_cso_err ? 0U : 1U;\n+\n+\t\t\t/* Checksum offload workaround for small packets */\n+\t\t\tif (rxd_wb->pkt_len <= 60) {\n+\t\t\t\tbuff->is_ip_cso = 0U;\n+\t\t\t\tbuff->is_cso_err = 0U;\n+\t\t\t}\n \t\t}\n \n \t\tis_err &= ~0x18U;\n", "prefixes": [ "net", "v2", "3/6" ] }