Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806680/?format=api
{ "id": 806680, "url": "http://patchwork.ozlabs.org/api/patches/806680/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1503942035-24924-9-git-send-email-michael.chan@broadcom.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503942035-24924-9-git-send-email-michael.chan@broadcom.com>", "list_archive_url": null, "date": "2017-08-28T17:40:32", "name": "[net-next,08/11] bnxt_en: fix clearing devlink ptr from bnxt struct", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e9cdb2ac02048cebd9602abf4e8a1a744b309b9e", "submitter": { "id": 68365, "url": "http://patchwork.ozlabs.org/api/people/68365/?format=api", "name": "Michael Chan", "email": "michael.chan@broadcom.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1503942035-24924-9-git-send-email-michael.chan@broadcom.com/mbox/", "series": [ { "id": 225, "url": "http://patchwork.ozlabs.org/api/series/225/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=225", "date": "2017-08-28T17:40:24", "name": "bnxt_en: Updates.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/225/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806680/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806680/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=broadcom.com header.i=@broadcom.com\n\theader.b=\"B6BVeq14\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgzZp0Wk0z9sP5\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 29 Aug 2017 03:41:06 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751595AbdH1RlE (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 28 Aug 2017 13:41:04 -0400", "from mail-qt0-f175.google.com ([209.85.216.175]:36292 \"EHLO\n\tmail-qt0-f175.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751493AbdH1Rk7 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 28 Aug 2017 13:40:59 -0400", "by mail-qt0-f175.google.com with SMTP id v29so5266456qtv.3\n\tfor <netdev@vger.kernel.org>; Mon, 28 Aug 2017 10:40:59 -0700 (PDT)", "from localhost.dhcp.broadcom.net ([192.19.255.250])\n\tby smtp.gmail.com with ESMTPSA id\n\t20sm592006qtu.52.2017.08.28.10.40.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 28 Aug 2017 10:40:58 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=broadcom.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=W0KnfY7DtOoJ9sT3p/eBXkxqkuJyPMQfO5BCguYK0aU=;\n\tb=B6BVeq14whl0Wfactl6faHADJY/+Xk7pSUnnn4rWcHFx7fP8BkPvEsAcWK9s0fV5zD\n\ttrOUwcWal8yzUyxcIa+Py2qgIsuUe05ckTe7ImjpPv80wl7L3R7ad0+Tfwa9XzbH5/H2\n\tY8OrIsxBqw3OH5p4si8RBazcY0lXQzhbywTCs=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=W0KnfY7DtOoJ9sT3p/eBXkxqkuJyPMQfO5BCguYK0aU=;\n\tb=CsUKUeAhJtjpmfT1VztSRgylPOaiEkjTxnRmPK6eB86yBRIqt3Jn3vXiyqH4oiCD1p\n\t1doOkCchEM8+HrKrcVRLB+vOzkT8lcnpmPZKeNgUlyC5XgufLK4QqFcmKuiJZNQSBz3/\n\tK9Z6RHrR81ZaPp6PWTolKP0UelvP7cPwxoPraFNxas5hJ6qfse4ID6Rab5+82WgN+1xn\n\tQwSgWE3A01Ik5bs2JRkVqlnHNMeuwCxmxvERR5ecH9H/76vrbYyIEYU9UX3VCDRqjPMz\n\tFHI6Wu8gl/0AQ+ca3Mdmi5uLoJcdjJhGcABFTA+fYb+qraPskzp5rwecrEXPm5TdhdFx\n\tqK/w==", "X-Gm-Message-State": "AHPjjUhPGb0LIyn5LO30NEJoQUpCDxNWiRA5bWB7UlxHOTtgsNkJ/x7O\n\tVT26r8Y/JCUgPZhW", "X-Received": "by 10.237.35.220 with SMTP id k28mr1830355qtc.337.1503942058627; \n\tMon, 28 Aug 2017 10:40:58 -0700 (PDT)", "From": "Michael Chan <michael.chan@broadcom.com>", "To": "davem@davemloft.net", "Cc": "netdev@vger.kernel.org, Sathya Perla <sathya.perla@broadcom.com>", "Subject": "[PATCH net-next 08/11] bnxt_en: fix clearing devlink ptr from bnxt\n\tstruct", "Date": "Mon, 28 Aug 2017 13:40:32 -0400", "Message-Id": "<1503942035-24924-9-git-send-email-michael.chan@broadcom.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1503942035-24924-1-git-send-email-michael.chan@broadcom.com>", "References": "<1503942035-24924-1-git-send-email-michael.chan@broadcom.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Sathya Perla <sathya.perla@broadcom.com>\n\nThe routine bnxt_link_bp_to_dl() is used to set the devlink ptr\nin bnxt struct (bp) and also to set the bnxt back ptr in\nthe devlink struct. If devlink_register() fails, bp->dl must\nbe cleared which is not happening currently. This patch fixes\nbnxt_link_bp_to_dl() to clear bp->dl by passing a NULL dl ptr.\n\nFixes: 4ab0c6a8ffd7 (\"bnxt_en: add support to enable VF-representors\")\nSigned-off-by: Sathya Perla <sathya.perla@broadcom.com>\nSigned-off-by: Michael Chan <michael.chan@broadcom.com>\n---\n drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 4 ++--\n drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.h | 14 +++++++++-----\n 2 files changed, 11 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c\nindex 86cce6f..c365d3c 100644\n--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c\n+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c\n@@ -468,11 +468,11 @@ int bnxt_dl_register(struct bnxt *bp)\n \t\treturn -ENOMEM;\n \t}\n \n-\tbnxt_link_bp_to_dl(dl, bp);\n+\tbnxt_link_bp_to_dl(bp, dl);\n \tbp->eswitch_mode = DEVLINK_ESWITCH_MODE_LEGACY;\n \trc = devlink_register(dl, &bp->pdev->dev);\n \tif (rc) {\n-\t\tbnxt_link_bp_to_dl(dl, NULL);\n+\t\tbnxt_link_bp_to_dl(bp, NULL);\n \t\tdevlink_free(dl);\n \t\tnetdev_warn(bp->dev, \"devlink_register failed. rc=%d\", rc);\n \t\treturn rc;\ndiff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.h b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.h\nindex e55a3b6..3e997c9 100644\n--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.h\n+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.h\n@@ -24,13 +24,17 @@ static inline struct bnxt *bnxt_get_bp_from_dl(struct devlink *dl)\n \treturn ((struct bnxt_dl *)devlink_priv(dl))->bp;\n }\n \n-static inline void bnxt_link_bp_to_dl(struct devlink *dl, struct bnxt *bp)\n+/* To clear devlink pointer from bp, pass NULL dl */\n+static inline void bnxt_link_bp_to_dl(struct bnxt *bp, struct devlink *dl)\n {\n-\tstruct bnxt_dl *bp_dl = devlink_priv(dl);\n+\tbp->dl = dl;\n \n-\tbp_dl->bp = bp;\n-\tif (bp)\n-\t\tbp->dl = dl;\n+\t/* add a back pointer in dl to bp */\n+\tif (dl) {\n+\t\tstruct bnxt_dl *bp_dl = devlink_priv(dl);\n+\n+\t\tbp_dl->bp = bp;\n+\t}\n }\n \n int bnxt_dl_register(struct bnxt *bp);\n", "prefixes": [ "net-next", "08/11" ] }