Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 806679,
    "url": "http://patchwork.ozlabs.org/api/patches/806679/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1503942035-24924-7-git-send-email-michael.chan@broadcom.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1503942035-24924-7-git-send-email-michael.chan@broadcom.com>",
    "list_archive_url": null,
    "date": "2017-08-28T17:40:30",
    "name": "[net-next,06/11] bnxt_en: Improve -ENOMEM logic in NAPI poll loop.",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "799c5f16cee8308eeb295e8ecd8703a617a1fd42",
    "submitter": {
        "id": 68365,
        "url": "http://patchwork.ozlabs.org/api/people/68365/?format=api",
        "name": "Michael Chan",
        "email": "michael.chan@broadcom.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1503942035-24924-7-git-send-email-michael.chan@broadcom.com/mbox/",
    "series": [
        {
            "id": 225,
            "url": "http://patchwork.ozlabs.org/api/series/225/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=225",
            "date": "2017-08-28T17:40:24",
            "name": "bnxt_en: Updates.",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/225/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/806679/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/806679/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=broadcom.com header.i=@broadcom.com\n\theader.b=\"eRQKRjfR\"; dkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgzZj5BtPz9sP5\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 29 Aug 2017 03:41:01 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751547AbdH1Rk7 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 28 Aug 2017 13:40:59 -0400",
            "from mail-qt0-f182.google.com ([209.85.216.182]:33373 \"EHLO\n\tmail-qt0-f182.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751304AbdH1Rk5 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 28 Aug 2017 13:40:57 -0400",
            "by mail-qt0-f182.google.com with SMTP id e2so5349035qta.0\n\tfor <netdev@vger.kernel.org>; Mon, 28 Aug 2017 10:40:56 -0700 (PDT)",
            "from localhost.dhcp.broadcom.net ([192.19.255.250])\n\tby smtp.gmail.com with ESMTPSA id\n\t20sm592006qtu.52.2017.08.28.10.40.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 28 Aug 2017 10:40:56 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=broadcom.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=fj1bzEd4DxARxrzstNc1+VvOj/VgGzSyGz31r6VnE4A=;\n\tb=eRQKRjfRAt0aejUOIIazcma64sJl5ccDwQ+FTLg6UThhkLBpozvdmTzYrBKfjh6QxB\n\taylJTjdLzaQ4TAXsNvnpeaPlZO/RAbVlpHjHyq0f3GM5tQQMcXMSF6u3VaE1g5sVum6A\n\tPODu7Ce7liuq+CbfZ4uk8Qm3otLLJB92RyIyA=",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=fj1bzEd4DxARxrzstNc1+VvOj/VgGzSyGz31r6VnE4A=;\n\tb=ZXzuXPppspgFUsFsRe9kahrHf4U/dPrYKQc7OSn2W8uqUSLNlfEQKMySTAGbOoRhHf\n\t/0DHnDGv161rntsm1He2DtRZ7BjAzkYD21f+nRziI+MavdFsgAJ2G3vHWrfTSlceWUZ6\n\talEUurx98BgavKuv+G5fYfD3OG14VFdaU1mbQ/txlGQ47d1k865tHspdKchxNz75XPAO\n\tHibEc4Y/QJCNYig+GxBmPRVEqSYQ25xC2vOyITRYvkSZJS5lJ0UkUoFHfzRbefJhJUso\n\tAJJvJAERnDZLBFvqXMFa+c5XAPpNYDp1soiyLRAMmBL6P8uIFGrWZk4oTti4p4Q4zEwt\n\tPr/g==",
        "X-Gm-Message-State": "AHYfb5g1Uv1kKq6p5hR0xAXBkaa3OYV1+FR+RNxOo2I7bQ8PPNs7wfku\n\tIAjhgGjToMXk9H73Yxg=",
        "X-Received": "by 10.237.48.241 with SMTP id 104mr1925572qtf.210.1503942056361; \n\tMon, 28 Aug 2017 10:40:56 -0700 (PDT)",
        "From": "Michael Chan <michael.chan@broadcom.com>",
        "To": "davem@davemloft.net",
        "Cc": "netdev@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>",
        "Subject": "[PATCH net-next 06/11] bnxt_en: Improve -ENOMEM logic in NAPI poll\n\tloop.",
        "Date": "Mon, 28 Aug 2017 13:40:30 -0400",
        "Message-Id": "<1503942035-24924-7-git-send-email-michael.chan@broadcom.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1503942035-24924-1-git-send-email-michael.chan@broadcom.com>",
        "References": "<1503942035-24924-1-git-send-email-michael.chan@broadcom.com>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "If we cannot allocate RX buffers in the NAPI poll loop when processing\nan RX event, the current code does not count that event towards the NAPI\nbudget.  This can cause us to potentially loop forever in NAPI if we\nconsistently cannot allocate new buffers.  Improve it by counting\n-ENOMEM event as 1 towards the NAPI budget.\n\nCc: Martin KaFai Lau <kafai@fb.com>\nSigned-off-by: Michael Chan <michael.chan@broadcom.com>\n---\n drivers/net/ethernet/broadcom/bnxt/bnxt.c | 7 +++++++\n 1 file changed, 7 insertions(+)",
    "diff": "diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c\nindex 1afb408..a34fcdd 100644\n--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c\n+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c\n@@ -1850,6 +1850,13 @@ static int bnxt_poll_work(struct bnxt *bp, struct bnxt_napi *bnapi, int budget)\n \t\t\t\t\t\t\t   &event);\n \t\t\tif (likely(rc >= 0))\n \t\t\t\trx_pkts += rc;\n+\t\t\t/* Increment rx_pkts when rc is -ENOMEM to count towards\n+\t\t\t * the NAPI budget.  Otherwise, we may potentially loop\n+\t\t\t * here forever if we consistently cannot allocate\n+\t\t\t * buffers.\n+\t\t\t */\n+\t\t\telse if (rc == -ENOMEM)\n+\t\t\t\trx_pkts++;\n \t\t\telse if (rc == -EBUSY)\t/* partial completion */\n \t\t\t\tbreak;\n \t\t} else if (unlikely((TX_CMP_TYPE(txcmp) ==\n",
    "prefixes": [
        "net-next",
        "06/11"
    ]
}