Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806672/?format=api
{ "id": 806672, "url": "http://patchwork.ozlabs.org/api/patches/806672/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/20170828171459.16228-1-aserdean@ovn.org/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170828171459.16228-1-aserdean@ovn.org>", "list_archive_url": null, "date": "2017-08-28T17:14:59", "name": "[ovs-dev,RFC] tests: Add a default timeout for control utilities", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "888e73e0c4440370b4dd174e833c88e815872a61", "submitter": { "id": 72181, "url": "http://patchwork.ozlabs.org/api/people/72181/?format=api", "name": "Alin-Gabriel Serdean", "email": "aserdean@ovn.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/20170828171459.16228-1-aserdean@ovn.org/mbox/", "series": [ { "id": 221, "url": "http://patchwork.ozlabs.org/api/series/221/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=221", "date": "2017-08-28T17:14:59", "name": "[ovs-dev,RFC] tests: Add a default timeout for control utilities", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/221/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806672/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806672/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgz1G3vwGz9s03\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Aug 2017 03:15:30 +1000 (AEST)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id DF4B4ACC;\n\tMon, 28 Aug 2017 17:15:26 +0000 (UTC)", "from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id E0788AB8\n\tfor <dev@openvswitch.org>; Mon, 28 Aug 2017 17:15:25 +0000 (UTC)", "from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 374AA1D7\n\tfor <dev@openvswitch.org>; Mon, 28 Aug 2017 17:15:25 +0000 (UTC)", "from localhost.localdomain (unknown [79.114.23.207])\n\t(Authenticated sender: aserdean@ovn.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 9A4BE41C08F;\n\tMon, 28 Aug 2017 19:15:23 +0200 (CEST)" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Originating-IP": "79.114.23.207", "From": "Alin Gabriel Serdean <aserdean@ovn.org>", "To": "dev@openvswitch.org", "Date": "Mon, 28 Aug 2017 20:14:59 +0300", "Message-Id": "<20170828171459.16228-1-aserdean@ovn.org>", "X-Mailer": "git-send-email 2.10.2.windows.1", "X-Spam-Status": "No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org", "Cc": "Alin Gabriel Serdean <aserdean@ovn.org>", "Subject": "[ovs-dev] [PATCH,\n\tRFC] tests: Add a default timeout for control utilities", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "Let's suppose that ovsdb-server is running properly, but ovs-vswitchd\nis not responsive/crashed. We try to add a port via ovs-vsctl and it will\nhang.\nThis patch aims at that scenario and tries to make life easier when\ndebugging hanging tests.\n\nSome shells do not allow dashes in function names (default behavior),\nwe shall try to define an alias to overcome dashes if the shell allows it.\n\nSigned-off-by: Alin Gabriel Serdean <aserdean@ovn.org>\nSuggested-by: Ben Pfaff <blp@ovn.org>\n---\n tests/ovs-macros.at | 37 +++++++++++++++++++++++++++++++++++++\n 1 file changed, 37 insertions(+)", "diff": "diff --git a/tests/ovs-macros.at b/tests/ovs-macros.at\nindex dbce0a5..afe4032 100644\n--- a/tests/ovs-macros.at\n+++ b/tests/ovs-macros.at\n@@ -100,6 +100,43 @@ if test \"$IS_WIN32\" = \"yes\"; then\n }\n fi\n \n+# Try to add a default timeout for the following control utilities:\n+# - ovs-vsctl\n+# - ovs-ofctl\n+# - ovs-appctl\n+# - ovn-sbctl\n+# - ovn-nbctl\n+# - vtep-ctl\n+# Set default timeout for 30 seconds.\n+# This should be sufficient on all platforms.\n+OVS_TIMEOUT=30\n+alias ovs-vsctl='OVS_VSCTL_TIMEOUT' >/dev/null 2>&1\n+if [ $? -eq 0 ]; then\n+ OVS_VSCTL_TIMEOUT () {\n+ command ovs-vsctl --timeout=$OVS_TIMEOUT \"$@\"\n+ }\n+ alias ovs-ofctl='OVS_OFCTL_TIMEOUT'\n+ alias ovs-appctl='OVS_APPCTL_TIMEOUT'\n+ alias ovn-sbctl='OVS_SBCTL_TIMEOUT'\n+ alias ovn-nbctl='OVN_NBCTL_TIMEOUT'\n+ alias vtep-ctl='VTEP_CTL_TIMEOUT'\n+ OVS_OFCTL_TIMEOUT () {\n+ command ovs-ofctl --timeout=$OVS_TIMEOUT \"$@\"\n+ }\n+ OVS_APPCTL_TIMEOUT () {\n+ command ovs-appctl --timeout=$OVS_TIMEOUT \"$@\"\n+ }\n+ OVS_SBCTL_TIMEOUT () {\n+ command ovn-sbctl --timeout=$OVS_TIMEOUT \"$@\"\n+ }\n+ OVN_NBCTL_TIMEOUT () {\n+ command ovn-nbctl --timeout=$OVS_TIMEOUT \"$@\"\n+ }\n+ VTEP_CTL_TIMEOUT () {\n+ command vtep-ctl --timeout=$OVS_TIMEOUT \"$@\"\n+ }\n+fi\n+\n # parent_pid PID\n #\n # Prints the PID of the parent of process PID.\n", "prefixes": [ "ovs-dev", "RFC" ] }