Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 806576,
    "url": "http://patchwork.ozlabs.org/api/patches/806576/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1503927503-29065-3-git-send-email-tariqt@mellanox.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1503927503-29065-3-git-send-email-tariqt@mellanox.com>",
    "list_archive_url": null,
    "date": "2017-08-28T13:38:21",
    "name": "[net-next,2/4] net/mlx4_core: Make explicit conversion to 64bit value",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "b9a8401a46dda9881f3e556d78e892bf2d94c68a",
    "submitter": {
        "id": 68926,
        "url": "http://patchwork.ozlabs.org/api/people/68926/?format=api",
        "name": "Tariq Toukan",
        "email": "tariqt@mellanox.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1503927503-29065-3-git-send-email-tariqt@mellanox.com/mbox/",
    "series": [
        {
            "id": 170,
            "url": "http://patchwork.ozlabs.org/api/series/170/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=170",
            "date": "2017-08-28T13:38:21",
            "name": "mlx4 misc patches",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/170/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/806576/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/806576/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgtCm3pMsz9sNq\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 28 Aug 2017 23:39:16 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751280AbdH1NjO (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 28 Aug 2017 09:39:14 -0400",
            "from mail-il-dmz.mellanox.com ([193.47.165.129]:38594 \"EHLO\n\tmellanox.co.il\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1751189AbdH1NjM (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 28 Aug 2017 09:39:12 -0400",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n\ttariqt@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 28 Aug 2017 16:39:08 +0300",
            "from dev-l-vrt-206-006.mtl.labs.mlnx\n\t(dev-l-vrt-206-006.mtl.labs.mlnx [10.134.206.6])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v7SDd79H014764;\n\tMon, 28 Aug 2017 16:39:07 +0300"
        ],
        "From": "Tariq Toukan <tariqt@mellanox.com>",
        "To": "\"David S. Miller\" <davem@davemloft.net>",
        "Cc": "netdev@vger.kernel.org, Eran Ben Elisha <eranbe@mellanox.com>,\n\tLeon Romanovsky <leonro@mellanox.com>, Tariq Toukan <tariqt@mellanox.com>",
        "Subject": "[PATCH net-next 2/4] net/mlx4_core: Make explicit conversion to\n\t64bit value",
        "Date": "Mon, 28 Aug 2017 16:38:21 +0300",
        "Message-Id": "<1503927503-29065-3-git-send-email-tariqt@mellanox.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1503927503-29065-1-git-send-email-tariqt@mellanox.com>",
        "References": "<1503927503-29065-1-git-send-email-tariqt@mellanox.com>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "From: Leon Romanovsky <leonro@mellanox.com>\n\nThe \"lg\" variable is declared as int so in all places where this variable\nis used as a shift operand, the output will be int too.\n\nThis produces the following smatch warning:\ndrivers/net/ethernet/mellanox/mlx4/fw.c:1532 mlx4_map_cmd() warn:\n\tshould '1 << lg' be a 64 bit type?\n\nSimple declaration of \"1\" to be \"1ULL\" will fix the issue.\n\nFixes: 225c7b1feef1 (\"IB/mlx4: Add a driver Mellanox ConnectX InfiniBand adapters\")\nSigned-off-by: Leon Romanovsky <leonro@mellanox.com>\nSigned-off-by: Tariq Toukan <tariqt@mellanox.com>\n---\n drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c\nindex f76cac01d564..10cfb058a9de 100644\n--- a/drivers/net/ethernet/mellanox/mlx4/fw.c\n+++ b/drivers/net/ethernet/mellanox/mlx4/fw.c\n@@ -1534,7 +1534,7 @@ int mlx4_map_cmd(struct mlx4_dev *dev, u16 op, struct mlx4_icm *icm, u64 virt)\n \t\tfor (i = 0; i < mlx4_icm_size(&iter) >> lg; ++i) {\n \t\t\tif (virt != -1) {\n \t\t\t\tpages[nent * 2] = cpu_to_be64(virt);\n-\t\t\t\tvirt += 1 << lg;\n+\t\t\t\tvirt += 1ULL << lg;\n \t\t\t}\n \n \t\t\tpages[nent * 2 + 1] =\n",
    "prefixes": [
        "net-next",
        "2/4"
    ]
}