Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806573/?format=api
{ "id": 806573, "url": "http://patchwork.ozlabs.org/api/patches/806573/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503924917-12687-1-git-send-email-s1seetee@linux.vnet.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503924917-12687-1-git-send-email-s1seetee@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-08-28T12:55:17", "name": "[v2] qemu crashes when a negative number used for 'maxcpus'", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a546d7473a3dd0f4bf0d723098e4f628297222b1", "submitter": { "id": 72241, "url": "http://patchwork.ozlabs.org/api/people/72241/?format=api", "name": "seeteena", "email": "s1seetee@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503924917-12687-1-git-send-email-s1seetee@linux.vnet.ibm.com/mbox/", "series": [ { "id": 167, "url": "http://patchwork.ozlabs.org/api/series/167/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=167", "date": "2017-08-28T12:55:17", "name": "[v2] qemu crashes when a negative number used for 'maxcpus'", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/167/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806573/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806573/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgsb10npsz9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 28 Aug 2017 23:10:53 +1000 (AEST)", "from localhost ([::1]:39801 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmJoY-0007fg-O8\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 09:10:50 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:47551)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <s1seetee@linux.vnet.ibm.com>) id 1dmJaz-0004VC-VI\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 08:56:50 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <s1seetee@linux.vnet.ibm.com>) id 1dmJaw-0000un-2J\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 08:56:50 -0400", "from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38469)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <s1seetee@linux.vnet.ibm.com>)\n\tid 1dmJav-0000uT-PX\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 08:56:45 -0400", "from pps.filterd (m0098399.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7SCt165002299\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 08:56:44 -0400", "from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cmg3tmvu9-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 08:56:44 -0400", "from localhost\n\tby e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <s1seetee@linux.vnet.ibm.com>;\n\tMon, 28 Aug 2017 22:56:41 +1000", "from d23relay09.au.ibm.com (202.81.31.228)\n\tby e23smtp06.au.ibm.com (202.81.31.212) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 22:56:39 +1000", "from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97])\n\tby d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv7SCtNsR31588532\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 22:55:23 +1000", "from d23av03.au.ibm.com (localhost [127.0.0.1])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv7SCtFaL026641\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 22:55:15 +1000", "from oc1548405160.ibm.com ([9.79.182.7])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv7SCtAvw026428\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NO); Mon, 28 Aug 2017 22:55:14 +1000" ], "From": "Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>", "To": "qemu-devel@nongnu.org, pbonzini@redhat.com", "Date": "Mon, 28 Aug 2017 18:25:17 +0530", "X-Mailer": "git-send-email 1.8.3.1", "X-TM-AS-MML": "disable", "x-cbid": "17082812-0040-0000-0000-00000351C5A8", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17082812-0041-0000-0000-00000CCFBCBD", "Message-Id": "<1503924917-12687-1-git-send-email-s1seetee@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_07:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708280209", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]", "X-Received-From": "148.163.156.1", "X-Mailman-Approved-At": "Mon, 28 Aug 2017 09:10:07 -0400", "Subject": "[Qemu-devel] [PATCH v2] qemu crashes when a negative number used\n\tfor 'maxcpus'", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "s1seetee@linux.vnet.ibm.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "---Steps to Reproduce---\n\nWhen passed a negative number to 'maxcpus' parameter, Qemu aborts\nwith a core dump.\n\nRun the following command with maxcpus argument as negative number\n\nppc64-softmmu/qemu-system-ppc64 --nographic -vga none -machine\npseries,accel=kvm,kvm-type=HV -m size=200g -device virtio-blk-pci,\ndrive=rootdisk -drive file=/home/images/pegas-1.0-ppc64le.qcow2,\nif=none,cache=none,id=rootdisk,format=qcow2 -monitor telnet\n:127.0.0.1:1234,server,nowait -net nic,model=virtio -net\nuser -redir tcp:2000::22 -device nec-usb-xhci -smp 8,cores=1,\nthreads=1,maxcpus=-12\n\n(process:12149): GLib-ERROR **: gmem.c:130: failed to allocate\n 18446744073709550568 bytes\n\nTrace/breakpoint trap\n\nReported-by: R.Nageswara Sastry <rnsastry@linux.vnet.ibm.com>\nSigned-off-by: Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>\nReviewed-by: Bharata B Rao <bharata@linux.vnet.ibm.com>\n---\n vl.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/vl.c b/vl.c\nindex 8e247cc..042714f 100644\n--- a/vl.c\n+++ b/vl.c\n@@ -1244,6 +1244,11 @@ static void smp_parse(QemuOpts *opts)\n }\n \n max_cpus = qemu_opt_get_number(opts, \"maxcpus\", cpus);\n+\n+\tif (max_cpus < 0) {\n+\t\terror_report(\"Invalid max_cpus : %d\", max_cpus);\n+\t\texit(1);\n+\t}\n \n if (max_cpus < cpus) {\n error_report(\"maxcpus must be equal to or greater than smp\");\n", "prefixes": [ "v2" ] }