Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806562/?format=api
{ "id": 806562, "url": "http://patchwork.ozlabs.org/api/patches/806562/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170828123501.22317-2-kraxel@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170828123501.22317-2-kraxel@redhat.com>", "list_archive_url": null, "date": "2017-08-28T12:34:59", "name": "[v2,1/3] qxl: drop mono cursor support", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5aa31260d7b33320d53578c1a5a991c453ad0758", "submitter": { "id": 589, "url": "http://patchwork.ozlabs.org/api/people/589/?format=api", "name": "Gerd Hoffmann", "email": "kraxel@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170828123501.22317-2-kraxel@redhat.com/mbox/", "series": [ { "id": 159, "url": "http://patchwork.ozlabs.org/api/series/159/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=159", "date": "2017-08-28T12:35:01", "name": "qxl: add support for chunked cursors.", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/159/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806562/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806562/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kraxel@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgrsz4xGHz9sDB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 28 Aug 2017 22:38:47 +1000 (AEST)", "from localhost ([::1]:39678 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmJJV-0007pQ-KZ\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 08:38:45 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:42568)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <kraxel@redhat.com>) id 1dmJG5-0005XZ-VM\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 08:35:19 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <kraxel@redhat.com>) id 1dmJG2-0007eA-Ch\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 08:35:13 -0400", "from mx1.redhat.com ([209.132.183.28]:59152)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <kraxel@redhat.com>) id 1dmJG2-0007dU-7O\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 08:35:10 -0400", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2547C267DF;\n\tMon, 28 Aug 2017 12:35:09 +0000 (UTC)", "from sirius.home.kraxel.org (ovpn-116-70.ams2.redhat.com\n\t[10.36.116.70])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 647C583DA9;\n\tMon, 28 Aug 2017 12:35:03 +0000 (UTC)", "by sirius.home.kraxel.org (Postfix, from userid 1000)\n\tid 92E09204A3; Mon, 28 Aug 2017 14:35:01 +0200 (CEST)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 2547C267DF", "From": "Gerd Hoffmann <kraxel@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 28 Aug 2017 14:34:59 +0200", "Message-Id": "<20170828123501.22317-2-kraxel@redhat.com>", "In-Reply-To": "<20170828123501.22317-1-kraxel@redhat.com>", "References": "<20170828123501.22317-1-kraxel@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tMon, 28 Aug 2017 12:35:09 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v2 1/3] qxl: drop mono cursor support", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "=?utf-8?q?Ren=C3=A9_Rebe?= <rene@exactcode.com>,\n\tGerd Hoffmann <kraxel@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "The chunk size sanity check in qxl_render_cursor works for\nSPICE_CURSOR_TYPE_ALPHA cursors only. So support for\nSPICE_CURSOR_TYPE_MONO cursors must be broken for ages without anyone\nnoticing. Most likely it simply isn't used any more by guest drivers.\nDrop the dead code.\n\nSigned-off-by: Gerd Hoffmann <kraxel@redhat.com>\n---\n hw/display/qxl-render.c | 9 ---------\n 1 file changed, 9 deletions(-)", "diff": "diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c\nindex 9ad9d9e0f5..e1b3f05ecb 100644\n--- a/hw/display/qxl-render.c\n+++ b/hw/display/qxl-render.c\n@@ -207,7 +207,6 @@ void qxl_render_update_area_done(PCIQXLDevice *qxl, QXLCookie *cookie)\n static QEMUCursor *qxl_cursor(PCIQXLDevice *qxl, QXLCursor *cursor)\n {\n QEMUCursor *c;\n- uint8_t *image, *mask;\n size_t size;\n \n c = cursor_alloc(cursor->header.width, cursor->header.height);\n@@ -221,14 +220,6 @@ static QEMUCursor *qxl_cursor(PCIQXLDevice *qxl, QXLCursor *cursor)\n cursor_print_ascii_art(c, \"qxl/alpha\");\n }\n break;\n- case SPICE_CURSOR_TYPE_MONO:\n- mask = cursor->chunk.data;\n- image = mask + cursor_get_mono_bpl(c) * c->width;\n- cursor_set_mono(c, 0xffffff, 0x000000, image, 1, mask);\n- if (qxl->debug > 2) {\n- cursor_print_ascii_art(c, \"qxl/mono\");\n- }\n- break;\n default:\n fprintf(stderr, \"%s: not implemented: type %d\\n\",\n __FUNCTION__, cursor->header.type);\n", "prefixes": [ "v2", "1/3" ] }