Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806560/?format=api
{ "id": 806560, "url": "http://patchwork.ozlabs.org/api/patches/806560/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170828123501.22317-3-kraxel@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170828123501.22317-3-kraxel@redhat.com>", "list_archive_url": null, "date": "2017-08-28T12:35:00", "name": "[v2,2/3] qxl: add support for chunked cursors.", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "30376bba4e6472e3ec5c60fb02267f7bab6f5236", "submitter": { "id": 589, "url": "http://patchwork.ozlabs.org/api/people/589/?format=api", "name": "Gerd Hoffmann", "email": "kraxel@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170828123501.22317-3-kraxel@redhat.com/mbox/", "series": [ { "id": 159, "url": "http://patchwork.ozlabs.org/api/series/159/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=159", "date": "2017-08-28T12:35:01", "name": "qxl: add support for chunked cursors.", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/159/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806560/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806560/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kraxel@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgrpp0wm4z9sDB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 28 Aug 2017 22:36:02 +1000 (AEST)", "from localhost ([::1]:39670 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmJGq-0005ig-1S\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 08:36:00 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:42619)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <kraxel@redhat.com>) id 1dmJGA-0005gu-Cf\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 08:35:19 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <kraxel@redhat.com>) id 1dmJG9-0007j7-Jb\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 08:35:18 -0400", "from mx1.redhat.com ([209.132.183.28]:55452)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <kraxel@redhat.com>) id 1dmJG9-0007ig-ED\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 08:35:17 -0400", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 677AC769E0;\n\tMon, 28 Aug 2017 12:35:16 +0000 (UTC)", "from sirius.home.kraxel.org (ovpn-116-70.ams2.redhat.com\n\t[10.36.116.70])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 6039481884;\n\tMon, 28 Aug 2017 12:35:04 +0000 (UTC)", "by sirius.home.kraxel.org (Postfix, from userid 1000)\n\tid 99670204A4; Mon, 28 Aug 2017 14:35:01 +0200 (CEST)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 677AC769E0", "From": "Gerd Hoffmann <kraxel@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 28 Aug 2017 14:35:00 +0200", "Message-Id": "<20170828123501.22317-3-kraxel@redhat.com>", "In-Reply-To": "<20170828123501.22317-1-kraxel@redhat.com>", "References": "<20170828123501.22317-1-kraxel@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tMon, 28 Aug 2017 12:35:16 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v2 2/3] qxl: add support for chunked cursors.", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "=?utf-8?q?Ren=C3=A9_Rebe?= <rene@exactcode.com>,\n\tGerd Hoffmann <kraxel@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>\n---\n hw/display/qxl-render.c | 33 ++++++++++++++++++++++++++-------\n 1 file changed, 26 insertions(+), 7 deletions(-)", "diff": "diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c\nindex e1b3f05ecb..b2c98f90c0 100644\n--- a/hw/display/qxl-render.c\n+++ b/hw/display/qxl-render.c\n@@ -204,7 +204,30 @@ void qxl_render_update_area_done(PCIQXLDevice *qxl, QXLCookie *cookie)\n g_free(cookie);\n }\n \n-static QEMUCursor *qxl_cursor(PCIQXLDevice *qxl, QXLCursor *cursor)\n+static void qxl_unpack_chunks(void *dest, size_t size, PCIQXLDevice *qxl,\n+ QXLDataChunk *chunk, uint32_t group_id)\n+{\n+ uint32_t max_chunks = 32;\n+ size_t offset = 0;\n+ size_t bytes;\n+\n+ for (;;) {\n+ bytes = MIN(size - offset, chunk->data_size);\n+ memcpy(dest + offset, chunk->data, bytes);\n+ offset += bytes;\n+ if (offset == size)\n+ return;\n+ chunk = qxl_phys2virt(qxl, chunk->next_chunk, group_id);\n+ if (!chunk)\n+ return;\n+ max_chunks--;\n+ if (max_chunks == 0)\n+ return;\n+ }\n+}\n+\n+static QEMUCursor *qxl_cursor(PCIQXLDevice *qxl, QXLCursor *cursor,\n+ uint32_t group_id)\n {\n QEMUCursor *c;\n size_t size;\n@@ -215,7 +238,7 @@ static QEMUCursor *qxl_cursor(PCIQXLDevice *qxl, QXLCursor *cursor)\n switch (cursor->header.type) {\n case SPICE_CURSOR_TYPE_ALPHA:\n size = sizeof(uint32_t) * cursor->header.width * cursor->header.height;\n- memcpy(c->data, cursor->chunk.data, size);\n+ qxl_unpack_chunks(c->data, size, qxl, &cursor->chunk, group_id);\n if (qxl->debug > 2) {\n cursor_print_ascii_art(c, \"qxl/alpha\");\n }\n@@ -259,11 +282,7 @@ int qxl_render_cursor(PCIQXLDevice *qxl, QXLCommandExt *ext)\n if (!cursor) {\n return 1;\n }\n- if (cursor->chunk.data_size != cursor->data_size) {\n- fprintf(stderr, \"%s: multiple chunks\\n\", __FUNCTION__);\n- return 1;\n- }\n- c = qxl_cursor(qxl, cursor);\n+ c = qxl_cursor(qxl, cursor, ext->group_id);\n if (c == NULL) {\n c = cursor_builtin_left_ptr();\n }\n", "prefixes": [ "v2", "2/3" ] }