Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806518/?format=api
{ "id": 806518, "url": "http://patchwork.ozlabs.org/api/patches/806518/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20170828105301.8511-9-Zhiqiang.Hou@nxp.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170828105301.8511-9-Zhiqiang.Hou@nxp.com>", "list_archive_url": null, "date": "2017-08-28T10:53:00", "name": "[PATCHv5,8/9] PCI: designware: enable write permission before updating DBI RO registers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fd38ad2d34c76f280e40e0e8351bc59acd04a47b", "submitter": { "id": 67929, "url": "http://patchwork.ozlabs.org/api/people/67929/?format=api", "name": "Z.Q. Hou", "email": "zhiqiang.hou@nxp.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20170828105301.8511-9-Zhiqiang.Hou@nxp.com/mbox/", "series": [ { "id": 133, "url": "http://patchwork.ozlabs.org/api/series/133/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=133", "date": "2017-08-28T10:52:52", "name": "PCI: dwc: refactor ls-pcie ->host_init() and fix bug for dw_pcie_setup_rc", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/133/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806518/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806518/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "spf=fail (sender IP is 192.88.168.50)\n\tsmtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed)\n\theader.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com;" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgpw942rbz9s8J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 28 Aug 2017 21:10:33 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751269AbdH1LKc (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tMon, 28 Aug 2017 07:10:32 -0400", "from mail-dm3nam03on0086.outbound.protection.outlook.com\n\t([104.47.41.86]:15360\n\t\"EHLO NAM03-DM3-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751234AbdH1LKc (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tMon, 28 Aug 2017 07:10:32 -0400", "from MWHPR03CA0009.namprd03.prod.outlook.com (10.175.133.147) by\n\tCO2PR03MB2261.namprd03.prod.outlook.com (10.166.92.142) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1385.9; Mon, 28 Aug 2017 11:10:30 +0000", "from BN1AFFO11FD044.protection.gbl (2a01:111:f400:7c10::127) by\n\tMWHPR03CA0009.outlook.office365.com (2603:10b6:300:117::19) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.9 via\n\tFrontend Transport; Mon, 28 Aug 2017 11:10:29 +0000", "from tx30smr01.am.freescale.net (192.88.168.50) by\n\tBN1AFFO11FD044.mail.protection.outlook.com (10.58.52.191) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1341.15\n\tvia Frontend Transport; Mon, 28 Aug 2017 11:10:29 +0000", "from titan.ap.freescale.net ([10.192.208.233])\n\tby tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id\n\tv7SB9vXP006251; Mon, 28 Aug 2017 04:10:25 -0700" ], "Received-SPF": "Fail (protection.outlook.com: domain of nxp.com does not\n\tdesignate 192.88.168.50 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=192.88.168.50; helo=tx30smr01.am.freescale.net;", "From": "Zhiqiang Hou <Zhiqiang.Hou@nxp.com>", "To": "<linux-pci@vger.kernel.org>, <bhelgaas@google.com>,\n\t<jingoohan1@gmail.com>, <Joao.Pinto@synopsys.com>", "CC": "<minghuan.lian@nxp.com>, <mingkai.hu@nxp.com>, <roy.zang@nxp.com>,\n\t<niklas.cassel@axis.com>, <jesper.nilsson@axis.com>,\n\tHou Zhiqiang <Zhiqiang.Hou@nxp.com>", "Subject": "[PATCHv5 8/9] PCI: designware: enable write permission before\n\tupdating DBI RO registers", "Date": "Mon, 28 Aug 2017 18:53:00 +0800", "Message-ID": "<20170828105301.8511-9-Zhiqiang.Hou@nxp.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170828105301.8511-1-Zhiqiang.Hou@nxp.com>", "References": "<20170828105301.8511-1-Zhiqiang.Hou@nxp.com>", "X-EOPAttributedMessage": "0", "X-Matching-Connectors": "131483922297291169;\n\t(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()", "X-Forefront-Antispam-Report": "CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(6009001)(336005)(39860400002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(97736004)(4326008)(5003940100001)(626005)(6666003)(2950100002)(5660300001)(50226002)(8656003)(81166006)(72206003)(2906002)(50466002)(81156014)(8676002)(7416002)(48376002)(8936002)(356003)(106466001)(305945005)(105606002)(189998001)(39060400002)(86362001)(104016004)(76176999)(50986999)(498600001)(53936002)(2201001)(47776003)(68736007)(77096006)(36756003)(1076002)(54906002)(85426001)(2101003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2261;\n\tH:tx30smr01.am.freescale.net; FPR:; SPF:Fail;\n\tPTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; ", "X-Microsoft-Exchange-Diagnostics": [ "1; BN1AFFO11FD044;\n\t1:LRNVAcVo0NtqUftDdO2lq6KdwjRisuhNg7irENd0dI2Sx8Mzw07QNDkIXFQ+aHW3LrflsnjYKasdLtKcH3JJSBqMkcYRsO/2ZZlIYpItV8toDDK0ggS2PwQXOmjTWpJB", "1; CO2PR03MB2261;\n\t3:qItMMxdY/1UmoiAsflSZ4f7QXee9rCOW2JPS1IgBipVqNJ3wWYDzLzCv+VeOcz2lKCRZlxRM6mPH9BYG1oYuEx/yLqFTmCqTUOujeOdPxIaaDj1VbRGrNwQuuPqO8FfUT3h2wQzH2vPwVEHPlqFkUvWOc1gwTORegAnih6cVjwu/9WKXmvS7q/fiffKNenk2HsF+klAUOXvSJnkMIvBLpzO8YhRGeO7qILg6dAgmVwqVcZH7AHG2bAHCf/8OoIdg7qDxpSJnLmU8z0otfbAgTyL91H2rQ/C2UjX8lFZVg5JQSNV4thEoLmBW9tgamMONx/wblByX6uwRGTH21+JEx8oIF5T7NkaZmLsefXCoDTA=;\n\t25:SHtCZ14VInQnJp59qkfeQWDdJK+UcZebT3TbrYFnO5S9hWPuPhZaKhFHr6Eqxnvg4ITqWaruy40o20QJmPDDStiH++gR1LPwv5YtCf6anSy5d0/YK28olkZBFMlW3Bs5RiKEtG5vdqHKx4xyTsdLOh+wcYmaDn9ZqKPWutx3EEVZ2VS0HAqYepRjvYYC9+PBbc2+SE33vWSE5b4mchugsvWzK0QdC8Ixd3BmSAhh/1SbXcOl9C2jtLnWH307OsPA65zB6smAYW/OpiEc+TpfSa1bdKDbLTqqQCmA5C0j3vqBO2HdRAojOOWo0rAJsPncvv4ObwNMcchkB3nnIOaVQQ==", "1; CO2PR03MB2261;\n\t31:8xTxH5PBf3g87vLc7WCZO1wA1l4/3oly1PBwIizNy7pbbyiskL/6YbvbcEkYgdoZZVxP7tlmpHfvCQ1gNTOcV1W7vJFL7e6d5ugCrfuj5sEJMroK/dZkAQMqiVEiuvfh8k7omv8vzAxGbU/5HTQ2595jrO7Cleth2BeeNE0hxD+/XtRUGsdVdoGL5gv4V86c3EY8aPAKGJ8VsWDmrUZYXL+goPMwKr6u0XKMIqdjTUE=;\n\t4:veX4bUWGWXEowOj1xrE0L6Y2/j02skCkQau3kOzTc97DzV80YqBzooTDXAMzMTGevcYvr2/n4ltIWnXxi3pnQSnuQ6UoUQVO2bFCE5nQ0zAMTpkESnfrfgwGkJy0RJdTNFxDx0O+b+WIGDj7GyqEB2V4BTAWoOQKv98At5o7YsIQV/aFzv1DrPA1RYYX7Ky/0kHcQBwaoCm7wGyla56baCjjEih4mZ+EQORRz/gFkBWp0IltGbp3eaO/nMSaj7KWC4W/kuhx99x1TkJVLolyohh3F/W+oKZZbtr9quI8d95x2QTnac4XDB6Jgl8byLtZTIjZM3pQ/yjXasLmgyWYbQ==", "1; CO2PR03MB2261;\n\t23:DTmWuxt5A9BAtN+lRZpmpwDvymNvLSwKIC6u4HUqfYdx9TgQZ8WmUe5ZRh+0ATgkY7faE/yrdJTAkEFRE620f3MooLYwvUyfK09P6mh23lgrJjEl4y9eDxRtyww7v3cVehnrbbvrKFVxcqu3vDsdVu/ZIHwdZYbhirirtfEcX0ON9XXiHipmcNsVSd3ozhMgghxYzUVW+GGymBYGbo4dWohn4nEbL0PRPscNKhxkZjgzdQrpo7ETPplOPyhwfWkWo8H3OztJjTdC3uxGvdhajqWnC94Zz3aJ6lJmCo16hWzaQPFQaKGjl0eB81CCZCLJL3AjuCE49DDQtbPdWyPDtWZBJq3AVGMkoVS0NVnST12tuLhbKPcZCuQytM6TlGxW3EYN/Wy1xo/FmD9McrYwXLm1z1XTsfcJmTlZWI0zw5Gy5FLzLIHiNayQRz5OX/mIi85mLJlvBGbTEUrq2farHBUyB8ogf6k8djdB3OdnIBlctknDT7gwF/pDut39tGdKACM2aUQZpbc5X6ck3nmvG+e4mO1hpPY4Na4/tQKCwyhSMqjehhd2ZG7YK//zB5ZGeP/jZgeK3g2DE6/UDvWDmfCuhm98hP5yNadTAgmn7IzKa7/PcI370/qMaKiju1Z7a0fEV6997Rkc8tXkiFTPXcOkKGO3UCkI989xkcbjWd5WkdqnATywA8AU2/wznWFbgPnPxoVLOM7ZnVAapsXeEIZmrcWqK+hX7n2LFDLra9vaF6ND28j2eNcJ6MRKWPzI4Nad3phN/cDkw881pth84VFZGGMH0tAo6vM1Ia7OgiLfoeRN/nI1/YR+7Wg7s+/jXhSUN0IuQUG64fzM/FETajY2FiBYulTONmbdhD+Op1SKlTm0/9ubOj2u6rxyTIDjpjVNBt9SY7dX30gcbhnhoIbbK0ZDfz0lGGAKp/gcDIAPN6Phsl/2yl7ldxwnX8l0X7qIe14pBo6j5wPt2/RZikQR+58Txmo+oEMHfGidYQv37APitn5u7HF5iyjwNUbHis5Z2oSTR7mOQ7SL8luDLBMSMpIuGQcFTM1hM7RtpUfsheWSpEXc/jJYHBntSY5aWNdW1M4/AykmTDc2psjpILxF6BzrHxUfVr84H065V0CRNFLCEVrO+B+4w3vhyqdAZs2vuXHxj8G6rTHP2ZzHwij2PpYVPmv+s1YTY1EI4ns=", "1; CO2PR03MB2261;\n\t6:dQq9UlDUD4tHT2LtdHVbSOYiqG+H3PJKeVvabP4UZIObux4w3xeOTTTJHWbr7zlBY8rKoF2p23KDKUyvQs59O+xt0eyy1r/r7e2yFb7KKyPivx2B4gAxXwikJp11Gk7AKXu58D4navFXmSARhw4tkpkVUazfH7rIhoFeAUB8hkv1bVo6NG6E6hxM2osBMs5fjM5DIehFEtLQgjEmysuKro+gUd1qn1dj3zPm2XCS4gHRU1DtWU0tWru75m5RLqgVv3zkz6REKgk6addV75De2q3a/BBzjT1jJM/X18mRR3FeBHU+Dm87bW9ac9+oSfP1sqh7HSENJQJ5S980LHhXnQ==;\n\t5:/lJYZahPs6QLq1iYUCJhnAMVGCLeu8t/BGh8SuNo//ACOSbQauuOre5qt5eMRsJcJNNoGvZ9QTpHarHjYu4/3KC8xnCkIVDGMWAvqa51Q1HNDTesOPQYdlTpgsjbIkq1zkX3w4lsMPJsMQiMqS4ViQ==;\n\t24:54x/6g3gWvWMiT9TgN4gbHweNjWUyLqJm0B6sMyesKlZI0MgDr2CHpP42Zpv6HmteUuGnxKO0CxRkG0SpVgywfacJySHN6dVYXyL/9VXY00=;\n\t7:03JgrPJQMnQdwgvXuaMgS4REJTdGdjruay7lzgXN//x7kmJ4V9aT5YvSgcodPfTiXBv10YmyjZBUh06vpdAuz1lTsQ1qwIs9K0RndX8OW8CHJb2zlyvUGhdS5zi9Io2YzVJ87q7v+0Ix29Lg7BcwsDkhx6I9iCfgHBPMIWQmsjVTWqC1x18vMr18igeFODuOWMeSXpkhqthNoyFlcDsBQ4ZUSusc5TM9LjFKTRhb47Q=" ], "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "2466035d-c48e-416f-203f-08d4ee0564a9", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:CO2PR03MB2261; ", "X-MS-TrafficTypeDiagnostic": "CO2PR03MB2261:", "X-Exchange-Antispam-Report-Test": "UriScan:(185117386973197)(101931422205132); ", "X-Microsoft-Antispam-PRVS": "<CO2PR03MB22613C0F3B9020260D5A4EA7849E0@CO2PR03MB2261.namprd03.prod.outlook.com>", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(13016025)(13018025)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6096035)(20161123561025)(20161123556025)(20161123563025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123565025)(20161123559100)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:CO2PR03MB2261; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:CO2PR03MB2261; ", "X-Forefront-PRVS": "0413C9F1ED", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Aug 2017 11:10:29.5419\n\t(UTC)", "X-MS-Exchange-CrossTenant-Id": "5afe0b00-7697-4969-b663-5eab37d5f47e", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;\n\tIp=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CO2PR03MB2261", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" }, "content": "From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>\n\nThe existing fix doesn't actually work because the Class register and\ninterrupt PIN register are read-only, so it must enable the write\npermission before writing the correct value to these registers.\n\nSigned-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>\nAcked-by: Joao Pinto <jpinto@synopsys.com>\nAcked-by: Roy Zang <tie-fei.zang@freescale.com>\n---\nV5:\n - No change\n\n drivers/pci/dwc/pcie-designware-host.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/pci/dwc/pcie-designware-host.c b/drivers/pci/dwc/pcie-designware-host.c\nindex 157621175147..582f5cc3cd96 100644\n--- a/drivers/pci/dwc/pcie-designware-host.c\n+++ b/drivers/pci/dwc/pcie-designware-host.c\n@@ -597,10 +597,12 @@ void dw_pcie_setup_rc(struct pcie_port *pp)\n \tdw_pcie_writel_dbi(pci, PCI_BASE_ADDRESS_1, 0x00000000);\n \n \t/* setup interrupt pins */\n+\tdw_pcie_dbi_ro_wr_en(pci);\n \tval = dw_pcie_readl_dbi(pci, PCI_INTERRUPT_LINE);\n \tval &= 0xffff00ff;\n \tval |= 0x00000100;\n \tdw_pcie_writel_dbi(pci, PCI_INTERRUPT_LINE, val);\n+\tdw_pcie_dbi_ro_wr_dis(pci);\n \n \t/* setup bus numbers */\n \tval = dw_pcie_readl_dbi(pci, PCI_PRIMARY_BUS);\n@@ -637,8 +639,12 @@ void dw_pcie_setup_rc(struct pcie_port *pp)\n \n \tdw_pcie_wr_own_conf(pp, PCI_BASE_ADDRESS_0, 4, 0);\n \n+\t/* Enable write permission for the DBI read-only register */\n+\tdw_pcie_dbi_ro_wr_en(pci);\n \t/* program correct class for RC */\n \tdw_pcie_wr_own_conf(pp, PCI_CLASS_DEVICE, 2, PCI_CLASS_BRIDGE_PCI);\n+\t/* Better disable write permission right after the update */\n+\tdw_pcie_dbi_ro_wr_dis(pci);\n \n \tdw_pcie_rd_own_conf(pp, PCIE_LINK_WIDTH_SPEED_CONTROL, 4, &val);\n \tval |= PORT_LOGIC_SPEED_CHANGE;\n", "prefixes": [ "PATCHv5", "8/9" ] }