Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806440/?format=api
{ "id": 806440, "url": "http://patchwork.ozlabs.org/api/patches/806440/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1503909582.2455.2.camel@spectralink.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503909582.2455.2.camel@spectralink.com>", "list_archive_url": null, "date": "2017-08-28T08:39:44", "name": "PTP: PHY timestamping when MAC is PTP capable", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "d4171c6831461aefb28446b706f79212606e740b", "submitter": { "id": 47916, "url": "http://patchwork.ozlabs.org/api/people/47916/?format=api", "name": "Sørensen, Stefan", "email": "stefan.sorensen@spectralink.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1503909582.2455.2.camel@spectralink.com/mbox/", "series": [ { "id": 105, "url": "http://patchwork.ozlabs.org/api/series/105/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=105", "date": "2017-08-28T08:39:44", "name": "PTP: PHY timestamping when MAC is PTP capable", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/105/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806440/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806440/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=spectralink.onmicrosoft.com\n\theader.i=@spectralink.onmicrosoft.com header.b=\"fL/h8G5r\"; \n\tdkim-atps=neutral", "spf=none (sender IP is )\n\tsmtp.mailfrom=Stefan.Sorensen@spectralink.com; " ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xglZG6pr1z9sNq\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 28 Aug 2017 18:39:50 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752744AbdH1Ijs (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 28 Aug 2017 04:39:48 -0400", "from mail-cys01nam02on0120.outbound.protection.outlook.com\n\t([104.47.37.120]:45242\n\t\"EHLO NAM02-CY1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751198AbdH1Ijp (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tMon, 28 Aug 2017 04:39:45 -0400", "from BN6PR07MB3473.namprd07.prod.outlook.com (10.161.153.24) by\n\tBN6PR07MB3155.namprd07.prod.outlook.com (10.172.105.137) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1385.9; Mon, 28 Aug 2017 08:39:44 +0000", "from BN6PR07MB3473.namprd07.prod.outlook.com ([10.161.153.24]) by\n\tBN6PR07MB3473.namprd07.prod.outlook.com ([10.161.153.24]) with\n\tmapi id 15.01.1385.013; Mon, 28 Aug 2017 08:39:44 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=spectralink.onmicrosoft.com; s=selector1-spectralink-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=79djeHeMH86Riw4JTmcnlxhTsPJ8PjH0K6qsg0ZbwLM=;\n\tb=fL/h8G5r6hZucii/vA41cfoVQEbvg/VenxdfY4T022HYCk7x20SdcYbf0q4kYKFGHKdcqDgl7UuTmxgZLSeGdNx6y0OsMbiQnwKqnxpdYXIyh0Yc5/p61q7lRf8D/nSeHp2gZBu8UKJi6PgmF5yvEbXgMAxO9NGSM6pLbmynD7Q=", "From": "=?utf-8?q?S=C3=B8rensen=2C_Stefan?= <Stefan.Sorensen@spectralink.com>", "To": "\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n\t\"richardcochran@gmail.com\" <richardcochran@gmail.com>", "Subject": "PTP: PHY timestamping when MAC is PTP capable", "Thread-Topic": "PHY timestamping when MAC is PTP capable", "Thread-Index": "AQHTH9kys6yHNxihEEaGXzX0RaV+KA==", "Date": "Mon, 28 Aug 2017 08:39:44 +0000", "Message-ID": "<1503909582.2455.2.camel@spectralink.com>", "Accept-Language": "en-GB, de-DE, da-DK, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-mailer": "Evolution 3.24.5 (3.24.5-1.fc26) ", "authentication-results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=spectralink.onmicrosoft.com\n\theader.i=@spectralink.onmicrosoft.com header.b=\"fL/h8G5r\"; \n\tdkim-atps=neutral", "spf=none (sender IP is )\n\tsmtp.mailfrom=Stefan.Sorensen@spectralink.com; " ], "x-originating-ip": "[213.83.164.162]", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; BN6PR07MB3155;\n\t6:jGUmwNHDz4lKqm8/Pw2kxHnT5IDVAfD6vTQP/vorNU31k5UoPpfxeRNWS4SiWsilMErUvq/BTZe5lvMSsRCTA6yiWnyFRyWCoZbWkxnBZXg7dGBPm0c1uKUw7myptiHFsHPmMNG6BNL8bCze5iY4s2tief+Z49NhLUxYIJe/DOzp5fMzClqeQMSx6pCHEfZSCawmfYQ+BmwQ20JKDB6EMueRZgl5JtCniAIsDGE35fjoxTvx+vHbNXb9VhBsUXw8cFFLyRzyanC3RPUpH5tfcGVlKkiNS8/n747fQSVwj+wEWWqgBW0UvNVdoxuog0a7f17fZCZ2c0JptLk/QGt2yw==;\n\t5:HObmITu9T0td2/ocEeJTD4iW7uh9J0EqBvMdHem+hilcjR6rM2JjAnoUiH22pbIl0+o8e1xYHItVeuqFKHms625jHAh+W9w0sbXlwR/MXqIF9ARXqNWICQmsAwRBawhz/49XpGJmObBEmu39zWNmnw==;\n\t24:OKgKvCrMSTaIhsQgYHpbT/l9U2cLlR5VYbGgQEHPIbDSrf1Y/xFe5xJDFmGeIj3pKjW+bjlytjygUHfKqOq08lmeZXNYLV+S/1rptuIgdDo=;\n\t7:jzXbUkF2/QcjVUdv/9FGn2IC5ttzCWM8E0iCkJ19GA/S9hGqBr/8uqXXWfTAttA+6JxfPh6KUPmWe+Ji8BwKng0JMzUjE6obqrcDAC+p0nTQNrL6XZiqs/fVy9ODCQPbIw6Ot3w+slQkxoHbLbJhGGbnk+98Ik3Mk8yGsiuxiX2luoobvNJgL//KJRVH8i1Jy/K/3b/VuBtM7JEUDajULi/DGtgsRCA2DmsVLGtMPmw=", "x-ms-exchange-antispam-srfa-diagnostics": "SSOS;", "x-ms-office365-filtering-correlation-id": "cffd525c-5200-4855-eeab-08d4edf0552a", "x-microsoft-antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BN6PR07MB3155; ", "x-ms-traffictypediagnostic": "BN6PR07MB3155:", "x-exchange-antispam-report-test": "UriScan:;", "x-microsoft-antispam-prvs": "<BN6PR07MB3155E614E617B9684CF633B1EF9E0@BN6PR07MB3155.namprd07.prod.outlook.com>", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BN6PR07MB3155; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BN6PR07MB3155; ", "x-forefront-prvs": "0413C9F1ED", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10019020)(6009001)(39830400002)(189002)(199003)(50986999)(101416001)(86362001)(53936002)(66066001)(3280700002)(14454004)(2900100001)(68736007)(103116003)(102836003)(3846002)(72206003)(2906002)(2501003)(106356001)(33646002)(85202003)(105586002)(6116002)(81166006)(36756003)(5660300001)(77096006)(6486002)(25786009)(7736002)(305945005)(81156014)(8676002)(6506006)(189998001)(6436002)(97736004)(3660700001)(39060400002)(85182001)(478600001)(50226002)(6512007)(99286003)(8936002)(99106002)(777600001);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR07MB3155;\n\tH:BN6PR07MB3473.namprd07.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ", "received-spf": "None (protection.outlook.com: spectralink.com does not\n\tdesignate permitted sender hosts)", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-ID": "<98448B6AB97C134FB83BC10D8CBB280C@namprd07.prod.outlook.com>", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "spectralink.com", "X-MS-Exchange-CrossTenant-originalarrivaltime": "28 Aug 2017 08:39:44.0705\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "c45ba920-5298-4256-8585-360096d02150", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN6PR07MB3155", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Hi,\r\n\r\nI have run into a problem with packet timestamping on a platform (cpsw\r\n+ dp83640) where both the PHY and the MAC is PTP capable and I need\r\nthe PHY to perform the timestamping. In the current code,\r\nSIOCGHWTSTAMP is passed to the MAC driver and only if it does not\r\nsupport PTP itself will it pass it on to the PHY driver.\r\n\r\nI see two ways to fix this:\r\n\r\n 1. Prefer PHY timestamping by passing SIOCGHWTSTAMP to the PHY\r\n driver first, and only if it does not support PTP, pass is on to\r\n the MAC driver. To me this seems reasonable as PHY timestamps\r\n will usually be of better quality, and with a hardware design\r\n using a PTP capable PHY you will most likely want to utilize\r\n it. Note that the ethtool get_ts_info op takes this route and as\r\n such may currently return incorrect info when both MAC and PHY is\r\n PTP capable.\r\n\r\n 2. Let the user decide, by e.g. a new ethtool op.\r\n\r\nFor now I am using the patch below, but it does not seem quite right\r\nto me.\r\n\r\nAny suggestions on the best way forward?\r\n\r\nRegards,\r\n Stefan\r\n\r\n---\r\n\r\n */", "diff": "diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c\r\nindex 709a4e6fb447..52f4d2dfad11 100644\r\n--- a/net/core/dev_ioctl.c\r\n+++ b/net/core/dev_ioctl.c\r\n@@ -4,6 +4,7 @@\r\n #include <linux/rtnetlink.h>\r\n #include <linux/net_tstamp.h>\r\n #include <linux/wireless.h>\r\n+#include <linux/phy.h>\r\n #include <net/wext.h>\r\n \r\n /*\r\n@@ -316,6 +317,14 @@ static int dev_ifsioc(struct net *net, struct\r\nifreq *ifr, unsigned int cmd)\r\n return err;\r\n /* fall through */\r\n \r\n+ case SIOCGHWTSTAMP:\r\n+ if (dev->phydev) {\r\n+ err = phy_mii_ioctl(dev->phydev, ifr, cmd);\r\n+ if (err != -EOPNOTSUPP)\r\n+ return err;\r\n+ }\r\n+ /* fall through */\r\n+\r\n /*\r\n * Unknown or private ioctl\r\n", "prefixes": [] }