Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806377/?format=api
{ "id": 806377, "url": "http://patchwork.ozlabs.org/api/patches/806377/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/patch/20170828061843.24349-2-sam@mendozajonas.com/", "project": { "id": 56, "url": "http://patchwork.ozlabs.org/api/projects/56/?format=api", "name": "OpenBMC development", "link_name": "openbmc", "list_id": "openbmc.lists.ozlabs.org", "list_email": "openbmc@lists.ozlabs.org", "web_url": "http://github.com/openbmc/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170828061843.24349-2-sam@mendozajonas.com>", "list_archive_url": null, "date": "2017-08-28T06:18:41", "name": "[net-next,v3,1/3] net/ncsi: Fix several packet definitions", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "e024956889065b6cc76671d8814b29e5ac10c778", "submitter": { "id": 68013, "url": "http://patchwork.ozlabs.org/api/people/68013/?format=api", "name": "Sam Mendoza-Jonas", "email": "sam@mendozajonas.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openbmc/patch/20170828061843.24349-2-sam@mendozajonas.com/mbox/", "series": [ { "id": 79, "url": "http://patchwork.ozlabs.org/api/series/79/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/list/?series=79", "date": "2017-08-28T06:18:40", "name": "NCSI VLAN Filtering Support", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/79/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806377/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806377/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "openbmc@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "openbmc@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xghSl5h3Pz9s7m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 28 Aug 2017 16:19:51 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xghSl3VFwzDqM1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 28 Aug 2017 16:19:51 +1000 (AEST)", "from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com\n\t[66.111.4.26])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xghRp0l0fzDq5m\n\tfor <openbmc@lists.ozlabs.org>; Mon, 28 Aug 2017 16:19:01 +1000 (AEST)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n\tby mailout.nyi.internal (Postfix) with ESMTP id CCF4120D7A;\n\tMon, 28 Aug 2017 02:18:59 -0400 (EDT)", "from frontend1 ([10.202.2.160])\n\tby compute2.internal (MEProxy); Mon, 28 Aug 2017 02:18:59 -0400", "from v4.ozlabs.ibm.com (unknown [122.99.82.10])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 0AFDF7E271;\n\tMon, 28 Aug 2017 02:18:56 -0400 (EDT)" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=mendozajonas.com header.i=@mendozajonas.com\n\theader.b=\"DbNIJZSU\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"f0EoIR9z\"; \n\tdkim-atps=neutral", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=mendozajonas.com header.i=@mendozajonas.com\n\theader.b=\"DbNIJZSU\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"f0EoIR9z\"; \n\tdkim-atps=neutral", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=mendozajonas.com header.i=@mendozajonas.com\n\theader.b=\"DbNIJZSU\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"f0EoIR9z\"; dkim-atps=neutral" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmendozajonas.com; h=cc:date:from:in-reply-to:message-id\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc\n\t:x-sasl-enc; s=fm1; bh=hD3fJANsQ6JKbuDu8M2wjyaLPLMzwDRi8SOeZxzuM\n\t20=; b=DbNIJZSUNRm/R6Ov1D7s2CZ20weLYPJ5tNJ7QbgMK739/hZOfo/fteUbL\n\tH3LH7322FE/wxgsUoZqwr5Q9s/Oi2EjuHdtOtI0Gj9fx+IxvA6j783gP0Yy3IrIw\n\trFewz2lwElKkBiQN9+fg9FctS7HVxgiRXTJjN3ELY7T6OH6gF55Jjv/Nw0TSyyLM\n\tjHKJyr6tuBJXdADazZ9Lsi++CsjI2RxHkmxllKgb9aDwBGS9wm9drjHNsusZbK8M\n\t9PXTBzPXgpN4BKwVLVVDrpB3Dohs55X7vQOB6OubezcmVOoAqKmJT8/uwEG3Rff5\n\tiuVvYsuBlQq0Zd6m5E9p6T3EvRseg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:date:from:in-reply-to:message-id\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc\n\t:x-sasl-enc; s=fm1; bh=hD3fJANsQ6JKbuDu8M2wjyaLPLMzwDRi8SOeZxzuM\n\t20=; b=f0EoIR9zypmEFUkKGvSy6wfQLMmVGeOxaGGbvK3U66VLLS/6fSsOGE554\n\tkKmP+LZXigBg2+hkeWIJkmVqzbqLl7Ncv3lzTWJVbuWJJ9mPnqhLwuakJo/+6cnr\n\t5xuU76OkbAQ9ZXZalcWFAXnOviaXivHUo5W4FfzWsCjtbNQ68El/4e7ucZ8n6r/k\n\tsmXYa8oV2aTU8S/s1NH6q8Uhh3FLKC6UB4HJvfkfaDLNzDk9GxgN+/W++zBz5kHw\n\tNjjPsfaIgU+17E3KeHIEoCyb4m8xgVSKtXq5fWYW9jRnNgMDF/YWk5Wp4TWzOlpz\n\tgbGSZY6rrpe6JUl/5nA1GMz2KEiug==" ], "X-ME-Sender": "<xms:07WjWf5sIuymwH8hM0DmWUSvC1gF5JdUNH2DOGxNPMtjrSmzbJ7Nnw>", "X-Sasl-enc": "XclAxYspnVAYFcMwUAB80FSV0flgAX1UDGN4y+O9jSBp 1503901139", "From": "Samuel Mendoza-Jonas <sam@mendozajonas.com>", "To": "\"David S . Miller\" <davem@davemloft.net>, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, OpenBMC Maillist <openbmc@lists.ozlabs.org>", "Subject": "[PATCH net-next v3 1/3] net/ncsi: Fix several packet definitions", "Date": "Mon, 28 Aug 2017 16:18:41 +1000", "Message-Id": "<20170828061843.24349-2-sam@mendozajonas.com>", "X-Mailer": "git-send-email 2.14.0", "In-Reply-To": "<20170828061843.24349-1-sam@mendozajonas.com>", "References": "<20170828061843.24349-1-sam@mendozajonas.com>", "X-BeenThere": "openbmc@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Development list for OpenBMC <openbmc.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/openbmc/>", "List-Post": "<mailto:openbmc@lists.ozlabs.org>", "List-Help": "<mailto:openbmc-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Samuel Mendoza-Jonas <sam@mendozajonas.com>,\n\tGavin Shan <gwshan@linux.vnet.ibm.com>", "Errors-To": "openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"openbmc\"\n\t<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>\n---\nv2: Rebased on latest net-next\n\n net/ncsi/ncsi-cmd.c | 10 +++++-----\n net/ncsi/ncsi-pkt.h | 2 +-\n net/ncsi/ncsi-rsp.c | 3 ++-\n 3 files changed, 8 insertions(+), 7 deletions(-)", "diff": "diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c\nindex 5e03ed190e18..7567ca63aae2 100644\n--- a/net/ncsi/ncsi-cmd.c\n+++ b/net/ncsi/ncsi-cmd.c\n@@ -139,9 +139,9 @@ static int ncsi_cmd_handler_svf(struct sk_buff *skb,\n \tstruct ncsi_cmd_svf_pkt *cmd;\n \n \tcmd = skb_put_zero(skb, sizeof(*cmd));\n-\tcmd->vlan = htons(nca->words[0]);\n-\tcmd->index = nca->bytes[2];\n-\tcmd->enable = nca->bytes[3];\n+\tcmd->vlan = htons(nca->words[1]);\n+\tcmd->index = nca->bytes[6];\n+\tcmd->enable = nca->bytes[7];\n \tncsi_cmd_build_header(&cmd->cmd.common, nca);\n \n \treturn 0;\n@@ -153,7 +153,7 @@ static int ncsi_cmd_handler_ev(struct sk_buff *skb,\n \tstruct ncsi_cmd_ev_pkt *cmd;\n \n \tcmd = skb_put_zero(skb, sizeof(*cmd));\n-\tcmd->mode = nca->bytes[0];\n+\tcmd->mode = nca->bytes[3];\n \tncsi_cmd_build_header(&cmd->cmd.common, nca);\n \n \treturn 0;\n@@ -228,7 +228,7 @@ static struct ncsi_cmd_handler {\n \t{ NCSI_PKT_CMD_AE, 8, ncsi_cmd_handler_ae },\n \t{ NCSI_PKT_CMD_SL, 8, ncsi_cmd_handler_sl },\n \t{ NCSI_PKT_CMD_GLS, 0, ncsi_cmd_handler_default },\n-\t{ NCSI_PKT_CMD_SVF, 4, ncsi_cmd_handler_svf },\n+\t{ NCSI_PKT_CMD_SVF, 8, ncsi_cmd_handler_svf },\n \t{ NCSI_PKT_CMD_EV, 4, ncsi_cmd_handler_ev },\n \t{ NCSI_PKT_CMD_DV, 0, ncsi_cmd_handler_default },\n \t{ NCSI_PKT_CMD_SMA, 8, ncsi_cmd_handler_sma },\ndiff --git a/net/ncsi/ncsi-pkt.h b/net/ncsi/ncsi-pkt.h\nindex 3ea49ed0a935..91b4b66438df 100644\n--- a/net/ncsi/ncsi-pkt.h\n+++ b/net/ncsi/ncsi-pkt.h\n@@ -104,7 +104,7 @@ struct ncsi_cmd_svf_pkt {\n \tunsigned char index; /* VLAN table index */\n \tunsigned char enable; /* Enable or disable */\n \t__be32 checksum; /* Checksum */\n-\tunsigned char pad[14];\n+\tunsigned char pad[18];\n };\n \n /* Enable VLAN */\ndiff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c\nindex 087db775b3dc..c1a191d790e2 100644\n--- a/net/ncsi/ncsi-rsp.c\n+++ b/net/ncsi/ncsi-rsp.c\n@@ -354,7 +354,8 @@ static int ncsi_rsp_handler_svf(struct ncsi_request *nr)\n \n \t/* Add or remove the VLAN filter */\n \tif (!(cmd->enable & 0x1)) {\n-\t\tret = ncsi_remove_filter(nc, NCSI_FILTER_VLAN, cmd->index);\n+\t\t/* HW indexes from 1 */\n+\t\tret = ncsi_remove_filter(nc, NCSI_FILTER_VLAN, cmd->index - 1);\n \t} else {\n \t\tvlan = ntohs(cmd->vlan);\n \t\tret = ncsi_add_filter(nc, NCSI_FILTER_VLAN, &vlan);\n", "prefixes": [ "net-next", "v3", "1/3" ] }