Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 806349,
    "url": "http://patchwork.ozlabs.org/api/patches/806349/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/4cfe77b4a829c0d6134b842fe2ea7c41b6b210ff.1503888301.git.lucien.xin@gmail.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<4cfe77b4a829c0d6134b842fe2ea7c41b6b210ff.1503888301.git.lucien.xin@gmail.com>",
    "list_archive_url": null,
    "date": "2017-08-28T02:45:01",
    "name": "[net] ipv6: do not set sk_destruct in IPV6_ADDRFORM sockopt",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "28e8b0466e15b524450d7acbcb34ff8da4b009a9",
    "submitter": {
        "id": 61073,
        "url": "http://patchwork.ozlabs.org/api/people/61073/?format=api",
        "name": "Xin Long",
        "email": "lucien.xin@gmail.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/4cfe77b4a829c0d6134b842fe2ea7c41b6b210ff.1503888301.git.lucien.xin@gmail.com/mbox/",
    "series": [
        {
            "id": 59,
            "url": "http://patchwork.ozlabs.org/api/series/59/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=59",
            "date": "2017-08-28T02:45:01",
            "name": "[net] ipv6: do not set sk_destruct in IPV6_ADDRFORM sockopt",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/59/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/806349/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/806349/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"E6Pue9mg\"; dkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgblC3jSGz9sP1\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 28 Aug 2017 12:47:03 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751829AbdH1CpL (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSun, 27 Aug 2017 22:45:11 -0400",
            "from mail-pf0-f193.google.com ([209.85.192.193]:37125 \"EHLO\n\tmail-pf0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751768AbdH1CpK (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sun, 27 Aug 2017 22:45:10 -0400",
            "by mail-pf0-f193.google.com with SMTP id r187so3205505pfr.4\n\tfor <netdev@vger.kernel.org>; Sun, 27 Aug 2017 19:45:10 -0700 (PDT)",
            "from localhost ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id\n\tr2sm20300431pfk.180.2017.08.27.19.45.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 27 Aug 2017 19:45:09 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=15y1FAaKQcreyF3FyjLrMy22GyyWJYa/41UoyuJpOYk=;\n\tb=E6Pue9mgdcAU1SKfH+Tn/LQJV5D1yT+98psNI1GBglmUEtyFV9+qbk0E0dCmBzCtZ3\n\tUfqoAguOZ+Zule8o9mMwAwKYMpYL91xHDURZb8LlQTsPDgXuJWoxIlPWjLz+WecD7wo2\n\t48yZmam/ui6dSVzA18mf5BS8nVPuG2ZaUmN31gq2eEDhp2BDKQ9ph91EA8cFFiVpes49\n\tQdZ4T4JBux4Iuwja4kaRj8ytgCvRKkrAa9V+oCGOFEGSEp8X/TkL38Mw0Pxu31bRSt7R\n\tYhXOaFA43qGi7p+bj4IKV/ktQ5yqGhv8h7tiq53GKzgU/K5eCMcYEquoEz6TR3Yox+g8\n\tmgzA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=15y1FAaKQcreyF3FyjLrMy22GyyWJYa/41UoyuJpOYk=;\n\tb=PS3GJmQ7RDROQuz4P4bb19sQ8XzqewVkflI5hEVA00UWu7kdOn6quA6FYf5MHkNg6p\n\t4g4DdOB3uy7ZccEj7q+9o1tM8u78xpVMnA2aW4glY9wBZtC80pFNZ+8mM1br+BdbyVZ/\n\tMACQS3Z0AIs/QQsrob1eF0a9g46bih0HOkRqyATYh4QMTxN8PPbOipapTBBQcWMjFYsN\n\t1xzTk5jzTjdd0RHA+Rk8T0v4hDDDgxMWhz9TmrcICG8n9fPdKU6wNrs+qJ3L1Kcz8PJQ\n\tIwFXRnFRaZi4BQuwZmIp0VqUktxVluCSQ0I/cAyjFjpUV6MmBdU306BxGvUUYuM5cS6o\n\t59aw==",
        "X-Gm-Message-State": "AHYfb5har+fwxWFDEaAE2B+MJ5HDJnW5ERhPhPcRYQJisEH6gC3e3ugW\n\tnqd6HEh7Ta1G4llaZSc=",
        "X-Received": "by 10.84.167.2 with SMTP id c2mr6836588plb.365.1503888309746;\n\tSun, 27 Aug 2017 19:45:09 -0700 (PDT)",
        "From": "Xin Long <lucien.xin@gmail.com>",
        "To": "network dev <netdev@vger.kernel.org>",
        "Cc": "davem@davemloft.net, pabeni@redhat.com, chunwang@redhat.com,\n\tsyzkaller@googlegroups.com",
        "Subject": "[PATCH net] ipv6: do not set sk_destruct in IPV6_ADDRFORM sockopt",
        "Date": "Mon, 28 Aug 2017 10:45:01 +0800",
        "Message-Id": "<4cfe77b4a829c0d6134b842fe2ea7c41b6b210ff.1503888301.git.lucien.xin@gmail.com>",
        "X-Mailer": "git-send-email 2.1.0",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "ChunYu found a kernel warn_on during syzkaller fuzzing:\n\n[40226.038539] WARNING: CPU: 5 PID: 23720 at net/ipv4/af_inet.c:152 inet_sock_destruct+0x78d/0x9a0\n[40226.144849] Call Trace:\n[40226.147590]  <IRQ>\n[40226.149859]  dump_stack+0xe2/0x186\n[40226.176546]  __warn+0x1a4/0x1e0\n[40226.180066]  warn_slowpath_null+0x31/0x40\n[40226.184555]  inet_sock_destruct+0x78d/0x9a0\n[40226.246355]  __sk_destruct+0xfa/0x8c0\n[40226.290612]  rcu_process_callbacks+0xaa0/0x18a0\n[40226.336816]  __do_softirq+0x241/0x75e\n[40226.367758]  irq_exit+0x1f6/0x220\n[40226.371458]  smp_apic_timer_interrupt+0x7b/0xa0\n[40226.376507]  apic_timer_interrupt+0x93/0xa0\n\nThe warn_on happned when sk->sk_rmem_alloc wasn't 0 in inet_sock_destruct.\nAs after commit f970bd9e3a06 (\"udp: implement memory accounting helpers\"),\nudp has changed to use udp_destruct_sock as sk_destruct where it would\nudp_rmem_release all rmem.\n\nBut IPV6_ADDRFORM sockopt sets sk_destruct with inet_sock_destruct after\nchanging family to PF_INET. If rmem is not 0 at that time, and there is\nno place to release rmem before calling inet_sock_destruct, the warn_on\nwill be triggered.\n\nThis patch is to fix it by not setting sk_destruct in IPV6_ADDRFORM sockopt\nany more. As IPV6_ADDRFORM sockopt only works for tcp and udp. TCP sock has\nalready set it's sk_destruct with inet_sock_destruct and UDP has set with\nudp_destruct_sock since they're created.\n\nFixes: f970bd9e3a06 (\"udp: implement memory accounting helpers\")\nReported-by: ChunYu Wang <chunwang@redhat.com>\nSigned-off-by: Xin Long <lucien.xin@gmail.com>\n---\n net/ipv6/ipv6_sockglue.c | 1 -\n 1 file changed, 1 deletion(-)",
    "diff": "diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c\nindex 02d795f..a5e466d 100644\n--- a/net/ipv6/ipv6_sockglue.c\n+++ b/net/ipv6/ipv6_sockglue.c\n@@ -242,7 +242,6 @@ static int do_ipv6_setsockopt(struct sock *sk, int level, int optname,\n \t\t\tpktopt = xchg(&np->pktoptions, NULL);\n \t\t\tkfree_skb(pktopt);\n \n-\t\t\tsk->sk_destruct = inet_sock_destruct;\n \t\t\t/*\n \t\t\t * ... and add it to the refcnt debug socks count\n \t\t\t * in the new family. -acme\n",
    "prefixes": [
        "net"
    ]
}