Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806316/?format=api
{ "id": 806316, "url": "http://patchwork.ozlabs.org/api/patches/806316/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170828001603.75876-10-jeffrey.t.kirsher@intel.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170828001603.75876-10-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2017-08-28T00:15:57", "name": "[net-next,09/15] i40e: Fix for unused value issue found by static analysis", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "11de938f0a23dc45d91975e5402af0e930f8eb34", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170828001603.75876-10-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 52, "url": "http://patchwork.ozlabs.org/api/series/52/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=52", "date": "2017-08-28T00:15:49", "name": "40GbE Intel Wired LAN Driver Updates 2017-08-27", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/52/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806316/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806316/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgXPl05fRz9s82\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 28 Aug 2017 10:16:43 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751707AbdH1AQV (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSun, 27 Aug 2017 20:16:21 -0400", "from mga14.intel.com ([192.55.52.115]:55214 \"EHLO mga14.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751613AbdH1AQU (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tSun, 27 Aug 2017 20:16:20 -0400", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Aug 2017 17:16:19 -0700", "from davidpwo-mobl1.amr.corp.intel.com (HELO\n\tjtkirshe-DESK.amr.corp.intel.com.com) ([10.254.22.134])\n\tby fmsmga004.fm.intel.com with ESMTP; 27 Aug 2017 17:16:19 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.41,439,1498546800\"; d=\"scan'208\";a=\"304981083\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "davem@davemloft.net", "Cc": "Carolyn Wyborny <carolyn.wyborny@intel.com>,\n\tnetdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,\n\tjogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Subject": "[net-next 09/15] i40e: Fix for unused value issue found by static\n\tanalysis", "Date": "Sun, 27 Aug 2017 17:15:57 -0700", "Message-Id": "<20170828001603.75876-10-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170828001603.75876-1-jeffrey.t.kirsher@intel.com>", "References": "<20170828001603.75876-1-jeffrey.t.kirsher@intel.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Carolyn Wyborny <carolyn.wyborny@intel.com>\n\nThis patch fixes an issue where an error return value is\nset, but without an immediate exit, the value can be overwritten\nby the following code execution. The condition at this point\nis not fatal, so remove the error assignment and comment the\nintent for future code maintainers\n\nSigned-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>\nTested-by: Andrew Bowers <andrewx.bowers@intel.com>\nSigned-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 5a06cd23b9e6..0962b85ef6f3 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -9884,13 +9884,15 @@ static int i40e_add_vsi(struct i40e_vsi *vsi)\n \t\t\t */\n \t\t\tret = i40e_vsi_config_tc(vsi, enabled_tc);\n \t\t\tif (ret) {\n+\t\t\t\t/* Single TC condition is not fatal,\n+\t\t\t\t * message and continue\n+\t\t\t\t */\n \t\t\t\tdev_info(&pf->pdev->dev,\n \t\t\t\t\t \"failed to configure TCs for main VSI tc_map 0x%08x, err %s aq_err %s\\n\",\n \t\t\t\t\t enabled_tc,\n \t\t\t\t\t i40e_stat_str(&pf->hw, ret),\n \t\t\t\t\t i40e_aq_str(&pf->hw,\n \t\t\t\t\t\t pf->hw.aq.asq_last_status));\n-\t\t\t\tret = -ENOENT;\n \t\t\t}\n \t\t}\n \t\tbreak;\n", "prefixes": [ "net-next", "09/15" ] }