Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 806312,
    "url": "http://patchwork.ozlabs.org/api/patches/806312/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170828001603.75876-11-jeffrey.t.kirsher@intel.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170828001603.75876-11-jeffrey.t.kirsher@intel.com>",
    "list_archive_url": null,
    "date": "2017-08-28T00:15:58",
    "name": "[net-next,10/15] i40e: remove workaround for resetting XPS",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "ea77fda3c03d7eefc0ce47fd753686e42119ac2c",
    "submitter": {
        "id": 473,
        "url": "http://patchwork.ozlabs.org/api/people/473/?format=api",
        "name": "Kirsher, Jeffrey T",
        "email": "jeffrey.t.kirsher@intel.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170828001603.75876-11-jeffrey.t.kirsher@intel.com/mbox/",
    "series": [
        {
            "id": 52,
            "url": "http://patchwork.ozlabs.org/api/series/52/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=52",
            "date": "2017-08-28T00:15:49",
            "name": "40GbE Intel Wired LAN Driver Updates 2017-08-27",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/52/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/806312/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/806312/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgXPS11Fhz9s82\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 28 Aug 2017 10:16:28 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751745AbdH1AQX (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSun, 27 Aug 2017 20:16:23 -0400",
            "from mga14.intel.com ([192.55.52.115]:47467 \"EHLO mga14.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751623AbdH1AQU (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tSun, 27 Aug 2017 20:16:20 -0400",
            "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Aug 2017 17:16:20 -0700",
            "from davidpwo-mobl1.amr.corp.intel.com (HELO\n\tjtkirshe-DESK.amr.corp.intel.com.com) ([10.254.22.134])\n\tby fmsmga004.fm.intel.com with ESMTP; 27 Aug 2017 17:16:19 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.41,439,1498546800\"; d=\"scan'208\";a=\"304981088\"",
        "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>",
        "To": "davem@davemloft.net",
        "Cc": "Jacob Keller <jacob.e.keller@intel.com>, netdev@vger.kernel.org,\n\tnhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com,\n\tJeff Kirsher <jeffrey.t.kirsher@intel.com>",
        "Subject": "[net-next 10/15] i40e: remove workaround for resetting XPS",
        "Date": "Sun, 27 Aug 2017 17:15:58 -0700",
        "Message-Id": "<20170828001603.75876-11-jeffrey.t.kirsher@intel.com>",
        "X-Mailer": "git-send-email 2.14.1",
        "In-Reply-To": "<20170828001603.75876-1-jeffrey.t.kirsher@intel.com>",
        "References": "<20170828001603.75876-1-jeffrey.t.kirsher@intel.com>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nSince commit 3ffa037d7f78 (\"i40e: Set XPS bit mask to zero in DCB mode\")\nwe've tried to reset the XPS settings by building a custom\nempty CPU mask.\n\nThis workaround is not necessary because we're not really removing the\nXPS setting, but simply setting it so that no CPU is valid.\n\nSecond, we shorten the code further by using zalloc_cpumask_var instead\nof a separate call to bitmap_zero().\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nTested-by: Andrew Bowers <andrewx.bowers@intel.com>\nSigned-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 17 +++++------------\n 1 file changed, 5 insertions(+), 12 deletions(-)",
    "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 0962b85ef6f3..7366e7c7f399 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -2874,22 +2874,15 @@ static void i40e_vsi_free_rx_resources(struct i40e_vsi *vsi)\n static void i40e_config_xps_tx_ring(struct i40e_ring *ring)\n {\n \tstruct i40e_vsi *vsi = ring->vsi;\n-\tcpumask_var_t mask;\n \n \tif (!ring->q_vector || !ring->netdev)\n \t\treturn;\n \n-\t/* Single TC mode enable XPS */\n-\tif (vsi->tc_config.numtc <= 1) {\n-\t\tif (!test_and_set_bit(__I40E_TX_XPS_INIT_DONE, &ring->state))\n-\t\t\tnetif_set_xps_queue(ring->netdev,\n-\t\t\t\t\t    &ring->q_vector->affinity_mask,\n-\t\t\t\t\t    ring->queue_index);\n-\t} else if (alloc_cpumask_var(&mask, GFP_KERNEL)) {\n-\t\t/* Disable XPS to allow selection based on TC */\n-\t\tbitmap_zero(cpumask_bits(mask), nr_cpumask_bits);\n-\t\tnetif_set_xps_queue(ring->netdev, mask, ring->queue_index);\n-\t\tfree_cpumask_var(mask);\n+\tif ((vsi->tc_config.numtc <= 1) &&\n+\t    !test_and_set_bit(__I40E_TX_XPS_INIT_DONE, &ring->state)) {\n+\t\tnetif_set_xps_queue(ring->netdev,\n+\t\t\t\t    &ring->q_vector->affinity_mask,\n+\t\t\t\t    ring->queue_index);\n \t}\n \n \t/* schedule our worker thread which will take care of\n",
    "prefixes": [
        "net-next",
        "10/15"
    ]
}