Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806277/?format=api
{ "id": 806277, "url": "http://patchwork.ozlabs.org/api/patches/806277/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20170827164850.31986-1-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170827164850.31986-1-sjg@chromium.org>", "list_archive_url": null, "date": "2017-08-27T16:48:47", "name": "[U-Boot] env: Fix operation of 'make environ'", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8f08364f69ea46c0521bff0b6d9daf0b3320e16e", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20170827164850.31986-1-sjg@chromium.org/mbox/", "series": [ { "id": 31, "url": "http://patchwork.ozlabs.org/api/series/31/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=31", "date": "2017-08-27T16:48:47", "name": "[U-Boot] env: Fix operation of 'make environ'", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/31/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806277/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806277/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"d4/sldYt\"; dkim-atps=neutral" ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgLTg1SFHz9sD9\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 28 Aug 2017 02:49:25 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid 773B4C2226D; Sun, 27 Aug 2017 16:49:06 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 51EABC22233;\n\tSun, 27 Aug 2017 16:49:04 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 872DCC22233; Sun, 27 Aug 2017 16:49:02 +0000 (UTC)", "from mail-oi0-f49.google.com (mail-oi0-f49.google.com\n\t[209.85.218.49])\n\tby lists.denx.de (Postfix) with ESMTPS id D03FAC2222B\n\tfor <u-boot@lists.denx.de>; Sun, 27 Aug 2017 16:49:01 +0000 (UTC)", "by mail-oi0-f49.google.com with SMTP id g127so15711940oic.1\n\tfor <u-boot@lists.denx.de>; Sun, 27 Aug 2017 09:49:01 -0700 (PDT)", "from kaki.bld.corp.google.com\n\t([2620:0:10f2:12:f00e:676f:b9cf:8415])\n\tby smtp.gmail.com with ESMTPSA id\n\tp65sm11948929oia.49.2017.08.27.09.48.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 27 Aug 2017 09:48:59 -0700 (PDT)", "by kaki.bld.corp.google.com (Postfix, from userid 121222)\n\tid 4DD5B4001F; Sun, 27 Aug 2017 10:48:58 -0600 (MDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=sender:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Hd3aAavKJ7a9HZYfa3dP+766UF5LsRRNP1uFvSMY4a8=;\n\tb=d4/sldYtMfQdZmdwjxDS++11cCkhZsHe1X0cjN31Xv5Nvy0+omKejzLw0VZ3qSbRSw\n\t33I8tSFKbHh1VIJDC0K4N3HqcnjI2esovqOQjweQrd1qFXF35Jo5jfagU+KYS3qs9RHT\n\tX2Dh204Rzl9bwsXE/vRCdjg7ApsdiXdSCdiqzERPFEo4RgLH//9/x3Cg9pwAvyYyEpJD\n\ttUtqUDr3IQFh8EuncjkMOL80wACo0t3tXA3tHgHjO4Q8g4Ht/4kBmotEmHuGLxPMzXCv\n\tmRcftivGC4qOvk3SsuJASGG8syb+i0Hv1JfWKQLA7O3bI49KRboYi6/myRZsvVFoUreX\n\tzjow==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:mime-version:content-transfer-encoding;\n\tbh=Hd3aAavKJ7a9HZYfa3dP+766UF5LsRRNP1uFvSMY4a8=;\n\tb=trQ1tRH6NL9s4H9+rvU06LOfKdF7iSnTSSRORYRo8Jz/mE0v/sDXjc/0n3CXW0/bLf\n\tgcGR72ib5/ZzpXg8yrCS/oxWsy0PAnGIOwl9nlxTzHIYjDNneaKzKmlDrN2eT8Ks2wYO\n\tVYz5gNny7ETa61ClWWzc8jXZRx043D7iFwsrKr38QvsQh1BR63dgv004Ac/ZEfNopNB3\n\tw94B0hy309iDhB4Os+ee0cJHqVjewbxs/tbJn1soZ6MUcoxU8gaG18Xj6b90u1+fjbo6\n\tn/hmqknqexx1v4ZyNOz6I61cStxaulzoxJojdVAODhpNVW4fTxruWAN7WumRENusZHZH\n\tv1hA==", "X-Gm-Message-State": "AHYfb5jSsVgQAkcn2w5+R9pGDmknf8ILfMPSPRuzU0P9DVb+wjhgSFA+\n\t5VMLITX66276kF6k", "X-Google-Smtp-Source": "ADKCNb6M4SpUj4RBRYWvhDIrObQ+Dt4g0ocLjxz2CFmW4diM09kjFi7VaD3y67XABBGUf4gKE26M3g==", "X-Received": "by 10.202.48.195 with SMTP id w186mr3228303oiw.143.1503852539976;\n\tSun, 27 Aug 2017 09:48:59 -0700 (PDT)", "From": "Simon Glass <sjg@chromium.org>", "To": "U-Boot Mailing List <u-boot@lists.denx.de>", "Date": "Sun, 27 Aug 2017 10:48:47 -0600", "Message-Id": "<20170827164850.31986-1-sjg@chromium.org>", "X-Mailer": "git-send-email 2.14.1.342.g6490525c54-goog", "MIME-Version": "1.0", "Cc": "Tom Rini <trini@konsulko.com>, =?utf-8?b?TcOlbnMgUnVsbGfDpXJk?=\n\t<mans@mansr.com>, Joe Hershberger <joe.hershberger@ni.com>,\n\tAndre Przywara <andre.przywara@arm.com>, \"Jr.\"@kaki.bld.corp.google.com, \n\tCooper@kaki.bld.corp.google.com, Franklin <fcooper@ti.com>", "Subject": "[U-Boot] [PATCH] env: Fix operation of 'make environ'", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "This was broken by the recent environment refactoring. Specifically:\n\n$ make environ\nscripts/Makefile.build:59: tools/environ/Makefile: No such file or directory\nmake[1]: *** No rule to make target 'tools/environ/Makefile'. Stop.\nmake: *** [Makefile:1469: environ] Error 2\n\nFix this by updating the Makefile and adjusting the #include filesnames in\ntwo C files.\n\nFixes: ec74f5f (Makefile: Rename 'env' target to 'environ')\nReported-by: Måns Rullgård <mans@mansr.com>\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\n Makefile | 2 +-\n tools/env/env_attr.c | 2 +-\n tools/env/env_flags.c | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/Makefile b/Makefile\nindex a0f3bfd2a52..dd9d5678118 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1466,7 +1466,7 @@ checkarmreloc: u-boot\n \tfi\n \n environ: scripts_basic\n-\t$(Q)$(MAKE) $(build)=tools/$@\n+\t$(Q)$(MAKE) $(build)=tools/env\n \n tools-only: scripts_basic $(version_h) $(timestamp_h)\n \t$(Q)$(MAKE) $(build)=tools\ndiff --git a/tools/env/env_attr.c b/tools/env/env_attr.c\nindex 502d4c900bf..4d8536335c3 100644\n--- a/tools/env/env_attr.c\n+++ b/tools/env/env_attr.c\n@@ -1 +1 @@\n-#include \"../../common/env_attr.c\"\n+#include \"../../env/attr.c\"\ndiff --git a/tools/env/env_flags.c b/tools/env/env_flags.c\nindex b261cb8e390..71e13e2021f 100644\n--- a/tools/env/env_flags.c\n+++ b/tools/env/env_flags.c\n@@ -1 +1 @@\n-#include \"../../common/env_flags.c\"\n+#include \"../../env/flags.c\"\n", "prefixes": [ "U-Boot" ] }