Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806209/?format=api
{ "id": 806209, "url": "http://patchwork.ozlabs.org/api/patches/806209/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/patch/20170827110920.15579-1-aleksander@aleksander.es/", "project": { "id": 27, "url": "http://patchwork.ozlabs.org/api/projects/27/?format=api", "name": "Buildroot development", "link_name": "buildroot", "list_id": "buildroot.buildroot.org", "list_email": "buildroot@buildroot.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170827110920.15579-1-aleksander@aleksander.es>", "list_archive_url": null, "date": "2017-08-27T11:09:20", "name": "autoconf: use host-gettext's autopoint if available in autoreconf", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "b99ecf343c1fd3a75fe23fb6a95907ba0d09f17b", "submitter": { "id": 48681, "url": "http://patchwork.ozlabs.org/api/people/48681/?format=api", "name": "Aleksander Morgado", "email": "aleksander@aleksander.es" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/buildroot/patch/20170827110920.15579-1-aleksander@aleksander.es/mbox/", "series": [ { "id": 9, "url": "http://patchwork.ozlabs.org/api/series/9/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/list/?series=9", "date": "2017-08-27T11:09:20", "name": "autoconf: use host-gettext's autopoint if available in autoreconf", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/9/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806209/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806209/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<buildroot-bounces@busybox.net>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "buildroot@lists.busybox.net" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "buildroot@osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aleksander-es.20150623.gappssmtp.com\n\theader.i=@aleksander-es.20150623.gappssmtp.com\n\theader.b=\"XBuoFPdj\"; dkim-atps=neutral" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgBxt1RKQz9sMN\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 27 Aug 2017 21:09:53 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4CF2388D6B;\n\tSun, 27 Aug 2017 11:09:49 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dTmGSBFmxl8U; Sun, 27 Aug 2017 11:09:47 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B9EE3888B5;\n\tSun, 27 Aug 2017 11:09:47 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id E459B1C0C39\n\tfor <buildroot@lists.busybox.net>;\n\tSun, 27 Aug 2017 11:09:46 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id DD6E42F487\n\tfor <buildroot@lists.busybox.net>;\n\tSun, 27 Aug 2017 11:09:46 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id oQ3ANPS7WSOE for <buildroot@lists.busybox.net>;\n\tSun, 27 Aug 2017 11:09:46 +0000 (UTC)", "from mail-wm0-f66.google.com (mail-wm0-f66.google.com\n\t[74.125.82.66])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 033842C305\n\tfor <buildroot@buildroot.org>; Sun, 27 Aug 2017 11:09:45 +0000 (UTC)", "by mail-wm0-f66.google.com with SMTP id m85so607793wma.4\n\tfor <buildroot@buildroot.org>; Sun, 27 Aug 2017 04:09:45 -0700 (PDT)", "from localhost.localdomain\n\t(232.red-83-34-121.dynamicip.rima-tde.net. [83.34.121.232])\n\tby smtp.gmail.com with ESMTPSA id\n\tn71sm4850104wmg.13.2017.08.27.04.09.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 27 Aug 2017 04:09:43 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=aleksander-es.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=eEijJSo2UJMo2rrUfJvLPCAPa26gXOwqA24cRqN6Qew=;\n\tb=XBuoFPdjJRxlpM7n9fTWTN4RrzePboC3tXxfsxHYb8aWwDD/8UwKa2GaIur4RmsmA1\n\tuPRF73h2Tt3kzqRREeRsHU6MwMd4wsK4Rd0c4TTf/i6ZMp7TlY3YJTMcaSJMxBfCmRrr\n\tYkYhhGE/elYeSTj6Hk48i0znjuQD4i+1+f3bV+EtA2fC8ZhN3bjYrGJSumjOUr4x2pwY\n\t7VTOLbofVD5YRJxwqmrSBB6MTjfjy+S+rbaOq3+R5yXUJRVYilAw16rTxqp0VSttI+TW\n\tIMPjFj4fyRQeK9e4TsHsT3P0rgPfkPltbZQoJ76+/X9Z+3YEmQgV01ajR6Q/DrsGclKI\n\tzY0g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=eEijJSo2UJMo2rrUfJvLPCAPa26gXOwqA24cRqN6Qew=;\n\tb=P6Jej9+t6rQTYEMV7Y2kO6+XtZekPsn9E+V1hc+3q/1UMOxmOLaI/qA5WQXMg1G/h2\n\tDc4B31iqqRSZBTfi9zbiRnkF+7OrKlTwfUfYLkWglZndZyhgXUXvp4vZ5Tr7OIvgf+JV\n\tTGNYX2VNyBeZNFXUP14Zv+kHDWd7G+3GHO4CSad5c7SLGups25VjwfiCkgXopIBS3S+P\n\tevj6zEyk6J+t4Oscd64y3j9PE4eop7IcYyKqp2UpnnMn/un/AV1f6vB3aWZoeqSBEudJ\n\t4R9uJIfQWd3mejv3QKeRC0MMh4d5X7iAzadNzVndN4fCce5nH87CtHqvdydIC1HRVgYJ\n\tj7EA==", "X-Gm-Message-State": "AHYfb5hFEANhqHgGw6gRwRgWH/aubBdQ8KPyz6ZhN2A5nW8R9AR/DjgX\n\tkOiNmglY4enzF0qvK1WiQA==", "X-Received": "by 10.28.185.16 with SMTP id j16mr1827096wmf.122.1503832184357; \n\tSun, 27 Aug 2017 04:09:44 -0700 (PDT)", "From": "Aleksander Morgado <aleksander@aleksander.es>", "To": "buildroot@buildroot.org", "Date": "Sun, 27 Aug 2017 13:09:20 +0200", "Message-Id": "<20170827110920.15579-1-aleksander@aleksander.es>", "X-Mailer": "git-send-email 2.14.1", "Cc": "Aleksander Morgado <aleksander@aleksander.es>", "Subject": "[Buildroot] [PATCH] autoconf: use host-gettext's autopoint if\n\tavailable in autoreconf", "X-BeenThere": "buildroot@busybox.net", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Discussion and development of buildroot <buildroot.busybox.net>", "List-Unsubscribe": "<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>", "List-Archive": "<http://lists.busybox.net/pipermail/buildroot/>", "List-Post": "<mailto:buildroot@busybox.net>", "List-Help": "<mailto:buildroot-request@busybox.net?subject=help>", "List-Subscribe": "<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "buildroot-bounces@busybox.net", "Sender": "\"buildroot\" <buildroot-bounces@busybox.net>" }, "content": "Commit 7ee8ebbd813ad0a6d2392ef628c17241 explicitly disabled autopoint\ncalls during autoreconf, to avoid having the host autopoint called, as\nthere was no host-gettext package.\n\nCommit 3a188b578e490f2a8b5922329b7abfae introduced the host-gettext\npackage support.\n\nThis commit recovers the support for automatically calling autopoint\nduring autoreconf.\n\nSigned-off-by: Aleksander Morgado <aleksander@aleksander.es>\n---\n\nHey,\n\nI see this is a recurring issue when a package that builds from git (bootstrapping using autoreconf before configure) requires gettext processing. automake would fail as autopoint wasn't being run (disabled in buildroot's autoconf package) and therefore not creating config.rpath and ABOUT-NLS (among other things, although these are the ones automake complains about). Specifying $(PKG)_GETTEXTIZE isn't an option as that may actually update the gnulib-imported files in a non-expected way, and \"touch\"-ing the missing files just seems a bit of a hack...\n\nCalling autopoint from autoreconf was disabled back in 2011 because no host-gettext package was available, but this package was added in 2013, so how about removing that limitation?\n\nCheers!\n\n---\n package/autoconf/autoconf.mk | 2 +-\n package/gettext/gettext.mk | 1 +\n 2 files changed, 2 insertions(+), 1 deletion(-)\n\n--\n2.14.1", "diff": "diff --git a/package/autoconf/autoconf.mk b/package/autoconf/autoconf.mk\nindex e5f474c72..f1c60224f 100644\n--- a/package/autoconf/autoconf.mk\n+++ b/package/autoconf/autoconf.mk\n@@ -23,4 +23,4 @@ $(eval $(host-autotools-package))\n # variables used by other packages\n AUTOCONF = $(HOST_DIR)/bin/autoconf\n AUTOHEADER = $(HOST_DIR)/bin/autoheader\n-AUTORECONF = $(HOST_CONFIGURE_OPTS) ACLOCAL=\"$(ACLOCAL)\" AUTOCONF=\"$(AUTOCONF)\" AUTOHEADER=\"$(AUTOHEADER)\" AUTOMAKE=\"$(AUTOMAKE)\" AUTOPOINT=/bin/true $(HOST_DIR)/bin/autoreconf -f -i -I \"$(ACLOCAL_DIR)\" -I \"$(ACLOCAL_HOST_DIR)\"\n+AUTORECONF = $(HOST_CONFIGURE_OPTS) ACLOCAL=\"$(ACLOCAL)\" AUTOCONF=\"$(AUTOCONF)\" AUTOHEADER=\"$(AUTOHEADER)\" AUTOMAKE=\"$(AUTOMAKE)\" AUTOPOINT=\"$(AUTOPOINT)\" $(HOST_DIR)/bin/autoreconf -f -i -I \"$(ACLOCAL_DIR)\" -I \"$(ACLOCAL_HOST_DIR)\" --verbose\ndiff --git a/package/gettext/gettext.mk b/package/gettext/gettext.mk\nindex ec9588f8a..08afc8fc3 100644\n--- a/package/gettext/gettext.mk\n+++ b/package/gettext/gettext.mk\n@@ -95,6 +95,7 @@ endef\n HOST_GETTEXT_POST_INSTALL_HOOKS += HOST_GETTEXT_ADD_ABOUT_NLS\n\n GETTEXTIZE = $(HOST_CONFIGURE_OPTS) AUTOM4TE=$(HOST_DIR)/bin/autom4te $(HOST_DIR)/bin/gettextize -f\n+AUTOPOINT = $(HOST_DIR)/bin/autopoint\n\n $(eval $(autotools-package))\n $(eval $(host-autotools-package))\n", "prefixes": [] }