Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806197/?format=api
{ "id": 806197, "url": "http://patchwork.ozlabs.org/api/patches/806197/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/1503800579-19321-1-git-send-email-bmeng.cn@gmail.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503800579-19321-1-git-send-email-bmeng.cn@gmail.com>", "list_archive_url": null, "date": "2017-08-27T02:22:58", "name": "[U-Boot,1/2] x86: ich-spi: Remove useless assignment in ich_spi_xfer()", "commit_ref": "52dd56ba847acd048205e6412e779fda991c95d3", "pull_url": null, "state": "accepted", "archived": false, "hash": "c7f52675edcbf15e4ea83f3fd8db09846797e896", "submitter": { "id": 64981, "url": "http://patchwork.ozlabs.org/api/people/64981/?format=api", "name": "Bin Meng", "email": "bmeng.cn@gmail.com" }, "delegate": { "id": 56520, "url": "http://patchwork.ozlabs.org/api/users/56520/?format=api", "username": "bmeng", "first_name": "Bin", "last_name": "Meng", "email": "bmeng.cn@gmail.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/1503800579-19321-1-git-send-email-bmeng.cn@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/806197/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806197/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"bCIoqOP2\"; dkim-atps=neutral" ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xfz951Q21z9sRm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 27 Aug 2017 12:18:47 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid 019D4C22265; Sun, 27 Aug 2017 02:18:41 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 6EF5CC221AB;\n\tSun, 27 Aug 2017 02:18:39 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 6D4E6C221AB; Sun, 27 Aug 2017 02:18:37 +0000 (UTC)", "from mail-io0-f194.google.com (mail-io0-f194.google.com\n\t[209.85.223.194])\n\tby lists.denx.de (Postfix) with ESMTPS id 77EA0C22194\n\tfor <u-boot@lists.denx.de>; Sun, 27 Aug 2017 02:18:36 +0000 (UTC)", "by mail-io0-f194.google.com with SMTP id c18so1564138ioj.2\n\tfor <u-boot@lists.denx.de>; Sat, 26 Aug 2017 19:18:36 -0700 (PDT)", "from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com.\n\t[147.11.156.139]) by smtp.gmail.com with ESMTPSA id\n\tw135sm2385424itc.42.2017.08.26.19.18.33\n\t(version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSat, 26 Aug 2017 19:18:34 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:subject:date:message-id;\n\tbh=I/0AHrKBG3RrwzoJtTMmQGAnPiUSwoz73s5ChnMCBrI=;\n\tb=bCIoqOP2s/QUZWjXiyyrvGruwXxmuufcZY/ZwE+XqYXZVuO2RufY0MwSqoILLm2Kr+\n\tjFsPOo4MDJuQhbl1ZgeO5fpTGxFaI4FzWDmcpG2ur9VAa1CUZ/7o1eTE5BQSS6EY6qXZ\n\t7krmj1bQsetdKTwroPzGcYRsV1dX1JKOdA94G2PIWvRK2Drd5M+C42IMlwz5Xs4D4VkP\n\taGwDpFtB/uQRwGtxC8pbhlVs6ooIE59uat5CiL47Td+BxSSdITZtXu19Zxx9T+07/Yzl\n\tQjAu7k6bw3otaxUJ+W1J1BmMgMPKfoMK857jWCzszxV+4zTclvZ1kCiavH+LbEVq6gLi\n\tsnBw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id;\n\tbh=I/0AHrKBG3RrwzoJtTMmQGAnPiUSwoz73s5ChnMCBrI=;\n\tb=ZC+BGPnE+Xyp3YkVWZOeB5DyWbDj/+oRdaUEffniOuhTPuFHkdONksMixmHZkmKWek\n\tk3SO/cf4PFLPbMwNOpdF1bFC2oTbqfeFDEYKHpubTvoZwVw7q2b0gfBmvGGsH2brcOhj\n\tkVQXW8eqnfBuCehcrzaB0kUnsGXuFpdw1+hTgKaBFdcEbNAgfBRlB7q6Szy8V1DqIWFX\n\tDfBeYgqkouZZ1WOUgbtL8eCk1DFqagnqgtmBBn0h8pSe8a/IQTPiKF9uMko6bJOQ2DWd\n\tMwfjk2bXbJooJc7XZD7gsCRobwqqZX6s9K5SSDovXIeLpMx+lNbIxIWsaq5dxCfjIFlX\n\t3glQ==", "X-Gm-Message-State": "AHYfb5jllmL2KKDGsL95O2w+FUoAHneZiuORMV5k/l/0yhHAG9iM56AB\n\t6tY35jtD7TIDUg==", "X-Received": "by 10.107.161.7 with SMTP id k7mr2310241ioe.189.1503800315117;\n\tSat, 26 Aug 2017 19:18:35 -0700 (PDT)", "From": "Bin Meng <bmeng.cn@gmail.com>", "To": "Simon Glass <sjg@chromium.org>, Stefan Roese <sr@denx.de>,\n\tU-Boot Mailing List <u-boot@lists.denx.de>", "Date": "Sat, 26 Aug 2017 19:22:58 -0700", "Message-Id": "<1503800579-19321-1-git-send-email-bmeng.cn@gmail.com>", "X-Mailer": "git-send-email 1.7.9.5", "Subject": "[U-Boot] [PATCH 1/2] x86: ich-spi: Remove useless assignment in\n\tich_spi_xfer()", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "In ich_spi_xfer() when the driver presets control fields, control\nvariable gets assigned twice. Apparently only the last assignment\ntakes effect. Remove the other one.\n\nSigned-off-by: Bin Meng <bmeng.cn@gmail.com>\n---\n\n drivers/spi/ich.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/drivers/spi/ich.c b/drivers/spi/ich.c\nindex 373bc26..5a3d690 100644\n--- a/drivers/spi/ich.c\n+++ b/drivers/spi/ich.c\n@@ -468,8 +468,6 @@ static int ich_spi_xfer(struct udevice *dev, unsigned int bitlen,\n \t}\n \n \t/* Preset control fields */\n-\tcontrol = ich_readw(ctlr, ctlr->control);\n-\tcontrol &= ~SSFC_RESERVED;\n \tcontrol = SPIC_SCGO | ((opcode_index & 0x07) << 4);\n \n \t/* Issue atomic preop cycle if needed */\n", "prefixes": [ "U-Boot", "1/2" ] }