Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806171/?format=api
{ "id": 806171, "url": "http://patchwork.ozlabs.org/api/patches/806171/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20170826225110.7381-8-xypron.glpk@gmx.de/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170826225110.7381-8-xypron.glpk@gmx.de>", "list_archive_url": null, "date": "2017-08-26T22:51:08", "name": "[U-Boot,07/23] efi_loader: simplify efi_install_protocol_interface", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "19c73d1c949a79b8934f5b1c4ff2cc35daad87da", "submitter": { "id": 61270, "url": "http://patchwork.ozlabs.org/api/people/61270/?format=api", "name": "Heinrich Schuchardt", "email": "xypron.glpk@gmx.de" }, "delegate": { "id": 3400, "url": "http://patchwork.ozlabs.org/api/users/3400/?format=api", "username": "agraf", "first_name": "Alexander", "last_name": "Graf", "email": "agraf@suse.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20170826225110.7381-8-xypron.glpk@gmx.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/806171/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806171/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xftkG3zx2z9s78\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 27 Aug 2017 08:58:46 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid E237BC221DF; Sat, 26 Aug 2017 22:54:00 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 2F534C2216B;\n\tSat, 26 Aug 2017 22:52:44 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 45FABC221BA; Sat, 26 Aug 2017 22:52:11 +0000 (UTC)", "from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lists.denx.de (Postfix) with ESMTPS id AEBDBC2218C\n\tfor <u-boot@lists.denx.de>; Sat, 26 Aug 2017 22:52:07 +0000 (UTC)", "from localhost.localdomain ([84.118.154.110]) by mail.gmx.com\n\t(mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id\n\t0MUCTO-1duz294At8-00R0GS; Sun, 27 Aug 2017 00:51:24 +0200" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable\n\tautolearn_force=no version=3.4.0", "From": "Heinrich Schuchardt <xypron.glpk@gmx.de>", "To": "Alexander Graf <agraf@suse.de>", "Date": "Sun, 27 Aug 2017 00:51:08 +0200", "Message-Id": "<20170826225110.7381-8-xypron.glpk@gmx.de>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170826225110.7381-1-xypron.glpk@gmx.de>", "References": "<20170826225110.7381-1-xypron.glpk@gmx.de>", "X-Provags-ID": "V03:K0:+KYgr/EQIGq3EwtLk/Aav55PfOfY7WXBOApTQCSZbFw0y8/qFFa\n\treJl25DVO9YzgaG28UmZPCiVTAO3ZgXyobldTyz63tdD2qQg/+wq1NMlj31YCnHlRAsX/Fk\n\t+7LI9/RqHHeqV937BbhD6C39YCW0QRA6rzq3/7K/oMoAblbYCky8SleJ5RNObeuTpP8FAfp\n\ty4hdaXVrjlDrHCOI9Z8mw==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:aZOmpa9LCS4=:FVCKmKxQ2euZG4hs0z36uz\n\tFSNTWHY+HI+PKG8769knFjT3jLivJS5EzoR4otw7PAbW9qoCWMCmAUQFVkxCKsk/QEKElqTZM\n\tc6Q9zhJAR7aWzW9MRe95MddGhasVgMGmqrku8lca+DZiZ+WNMLJH+v9SEBYRug2kUoLD26ttm\n\tZSTBGke6w5kQ8HQjl/hfTYoiNsnS7Wzjs48zp1BoU7QVfJIG1mP9lZTu0IwbmKzs52uh6VPLL\n\tvUJCy/1bJnLiwYahBHpltx+4GJLcvKRBzsgIwMAukXaLOmhyIbu/1RNU7eqvi7NA3zeAN74Q4\n\t+XYu71tu1oETbhXX9Z6EIog1BFB5NsddKDW5MBYPqPBMR3/NipnFryRMNuUsoMkqle3/auE11\n\tvD8VDWequmKjKLRsRGbGZ9EEtfE5JhagAsTkgrJMr8kDv7/5x/8rIu5QlKGIsSsLeK4IB/kn8\n\tKBso/f7cU5/PZK9h45476+ljvPYy+aNjFZJhUujHS5vbaDyql3zCLn8MyhIzJk/0lfONSCyOr\n\taQBJKauIY6jrTfok6LK7/pPuorLkBJfhBg45EuYxhSgQtSS9WkmWVuVjBqz+htRwWaqDf5Oq6\n\tc91z6bUrcefx7O7xxFnNnrSYmccU7RrmGnmOPGaw+IIDW4SL/YGiKB3JPVIsdYIJrDPceBNml\n\tMdtzd8TkWSmkfl7sPBoSv6AHpEoi8cgMH1ohSNUp0XMYY4BiDf3Eb+u4cfxs8eG21elMUh9WN\n\tFa9AGVLvsYX2odK2HS3quToMjoRY46UMQrua6mm5/av8pmxSR3RtfiVCMaIR61BuiIGctD7ni\n\twweRjoOyLxVzf7o56zA5AUtoQhMhg==", "Cc": "Heinrich Schuchardt <xypron.glpk@gmx.de>, u-boot@lists.denx.de", "Subject": "[U-Boot] [PATCH 07/23] efi_loader: simplify\n\tefi_install_protocol_interface", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "Use function efi_search_obj and efi_search_protocol\nto simplify the coding.\n\nDo away with efi_install_protocol_interface_ext.\nWe can use EFI_CALL for internal usage.\n\nSigned-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>\n---\n lib/efi_loader/efi_boottime.c | 76 ++++++++++++++++++-------------------------\n 1 file changed, 31 insertions(+), 45 deletions(-)", "diff": "diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c\nindex 9dae02daca..96cb1fa410 100644\n--- a/lib/efi_loader/efi_boottime.c\n+++ b/lib/efi_loader/efi_boottime.c\n@@ -482,9 +482,12 @@ static efi_status_t EFIAPI efi_install_protocol_interface(void **handle,\n \t\t\tefi_guid_t *protocol, int protocol_interface_type,\n \t\t\tvoid *protocol_interface)\n {\n-\tstruct list_head *lhandle;\n \tint i;\n \tefi_status_t r;\n+\tstruct efi_object *efiobj;\n+\n+\tEFI_ENTRY(\"%p, %p, %d, %p\", handle, protocol, protocol_interface_type,\n+\t\t protocol_interface);\n \n \tif (!handle || !protocol ||\n \t protocol_interface_type != EFI_NATIVE_INTERFACE) {\n@@ -497,54 +500,36 @@ static efi_status_t EFIAPI efi_install_protocol_interface(void **handle,\n \t\tr = EFI_OUT_OF_RESOURCES;\n \t\tgoto out;\n \t}\n+\n \t/* Find object. */\n-\tlist_for_each(lhandle, &efi_obj_list) {\n-\t\tstruct efi_object *efiobj;\n-\t\tefiobj = list_entry(lhandle, struct efi_object, link);\n+\tefiobj = efi_search_obj(*handle);\n+\tif (!efiobj) {\n+\t\tr = EFI_INVALID_PARAMETER;\n+\t\tgoto out;\n+\t}\n \n-\t\tif (efiobj->handle != *handle)\n-\t\t\tcontinue;\n-\t\t/* Check if protocol is already installed on the handle. */\n-\t\tfor (i = 0; i < ARRAY_SIZE(efiobj->protocols); i++) {\n-\t\t\tstruct efi_handler *handler = &efiobj->protocols[i];\n+\t/* Check if protocol is already installed on the handle. */\n+\tr = efi_search_protocol(*handle, protocol, NULL);\n+\tif (r == EFI_SUCCESS) {\n+\t\tr = EFI_INVALID_PARAMETER;\n+\t\tgoto out;\n+\t}\n \n-\t\t\tif (!handler->guid)\n-\t\t\t\tcontinue;\n-\t\t\tif (!guidcmp(handler->guid, protocol)) {\n-\t\t\t\tr = EFI_INVALID_PARAMETER;\n-\t\t\t\tgoto out;\n-\t\t\t}\n-\t\t}\n-\t\t/* Install protocol in first empty slot. */\n-\t\tfor (i = 0; i < ARRAY_SIZE(efiobj->protocols); i++) {\n-\t\t\tstruct efi_handler *handler = &efiobj->protocols[i];\n+\t/* Install protocol in first empty slot. */\n+\tfor (i = 0; i < ARRAY_SIZE(efiobj->protocols); i++) {\n+\t\tstruct efi_handler *handler = &efiobj->protocols[i];\n \n-\t\t\tif (handler->guid)\n-\t\t\t\tcontinue;\n+\t\tif (handler->guid)\n+\t\t\tcontinue;\n \n-\t\t\thandler->guid = protocol;\n-\t\t\thandler->protocol_interface = protocol_interface;\n-\t\t\tr = EFI_SUCCESS;\n-\t\t\tgoto out;\n-\t\t}\n-\t\tr = EFI_OUT_OF_RESOURCES;\n+\t\thandler->guid = protocol;\n+\t\thandler->protocol_interface = protocol_interface;\n+\t\tr = EFI_SUCCESS;\n \t\tgoto out;\n \t}\n-\tr = EFI_INVALID_PARAMETER;\n+\tr = EFI_OUT_OF_RESOURCES;\n out:\n-\treturn r;\n-}\n-\n-static efi_status_t EFIAPI efi_install_protocol_interface_ext(void **handle,\n-\t\t\tefi_guid_t *protocol, int protocol_interface_type,\n-\t\t\tvoid *protocol_interface)\n-{\n-\tEFI_ENTRY(\"%p, %p, %d, %p\", handle, protocol, protocol_interface_type,\n-\t\t protocol_interface);\n-\n-\treturn EFI_EXIT(efi_install_protocol_interface(handle, protocol,\n-\t\t\t\t\t\t protocol_interface_type,\n-\t\t\t\t\t\t protocol_interface));\n+\treturn EFI_EXIT(r);\n }\n \n static efi_status_t EFIAPI efi_reinstall_protocol_interface(void *handle,\n@@ -1115,9 +1100,10 @@ static efi_status_t EFIAPI efi_install_multiple_protocol_interfaces(\n \t\tif (!protocol)\n \t\t\tbreak;\n \t\tprotocol_interface = va_arg(argptr, void*);\n-\t\tr = efi_install_protocol_interface(handle, protocol,\n-\t\t\t\t\t\t EFI_NATIVE_INTERFACE,\n-\t\t\t\t\t\t protocol_interface);\n+\t\tr = EFI_CALL(efi_install_protocol_interface(\n+\t\t\t\t\t\thandle, protocol,\n+\t\t\t\t\t\tEFI_NATIVE_INTERFACE,\n+\t\t\t\t\t\tprotocol_interface));\n \t\tif (r != EFI_SUCCESS)\n \t\t\tbreak;\n \t\ti++;\n@@ -1263,7 +1249,7 @@ static const struct efi_boot_services efi_boot_services = {\n \t.signal_event = efi_signal_event_ext,\n \t.close_event = efi_close_event,\n \t.check_event = efi_check_event,\n-\t.install_protocol_interface = efi_install_protocol_interface_ext,\n+\t.install_protocol_interface = efi_install_protocol_interface,\n \t.reinstall_protocol_interface = efi_reinstall_protocol_interface,\n \t.uninstall_protocol_interface = efi_uninstall_protocol_interface_ext,\n \t.handle_protocol = efi_handle_protocol,\n", "prefixes": [ "U-Boot", "07/23" ] }