Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 806082,
    "url": "http://patchwork.ozlabs.org/api/patches/806082/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/sparclinux/patch/20170826061205.nkfvekwgzpfgfuhh@mwanda/",
    "project": {
        "id": 10,
        "url": "http://patchwork.ozlabs.org/api/projects/10/?format=api",
        "name": "Linux SPARC Development ",
        "link_name": "sparclinux",
        "list_id": "sparclinux.vger.kernel.org",
        "list_email": "sparclinux@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170826061205.nkfvekwgzpfgfuhh@mwanda>",
    "list_archive_url": null,
    "date": "2017-08-26T06:12:05",
    "name": "[sparc-next] sparc64: vcc: Check for IS_ERR() instead of NULL",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "d1c2e3e4c263e2a749b888ba4e9ebb2c9686bd61",
    "submitter": {
        "id": 9327,
        "url": "http://patchwork.ozlabs.org/api/people/9327/?format=api",
        "name": "Dan Carpenter",
        "email": "dan.carpenter@oracle.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/sparclinux/patch/20170826061205.nkfvekwgzpfgfuhh@mwanda/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/806082/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/806082/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<sparclinux-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=sparclinux-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xfSPG1dtqz9sRY\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 26 Aug 2017 16:12:34 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752182AbdHZGMc (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSat, 26 Aug 2017 02:12:32 -0400",
            "from aserp1040.oracle.com ([141.146.126.69]:39969 \"EHLO\n\taserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752179AbdHZGMb (ORCPT\n\t<rfc822; sparclinux@vger.kernel.org>); Sat, 26 Aug 2017 02:12:31 -0400",
            "from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id v7Q6CMTn012143\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Sat, 26 Aug 2017 06:12:23 GMT",
            "from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75])\n\tby userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v7Q6CMY2024632\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Sat, 26 Aug 2017 06:12:22 GMT",
            "from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14])\n\tby userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv7Q6CLA1026662; Sat, 26 Aug 2017 06:12:21 GMT",
            "from mwanda (/41.202.241.3)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Fri, 25 Aug 2017 23:12:20 -0700"
        ],
        "Date": "Sat, 26 Aug 2017 09:12:05 +0300",
        "From": "Dan Carpenter <dan.carpenter@oracle.com>",
        "To": "\"David S. Miller\" <davem@davemloft.net>, Jag Raman <jag.raman@oracle.com>",
        "Cc": "Greg Kroah-Hartman <gregkh@linuxfoundation.org>,\n\tJiri Slaby <jslaby@suse.com>, sparclinux@vger.kernel.org,\n\tkernel-janitors@vger.kernel.org",
        "Subject": "[PATCH sparc-next] sparc64: vcc: Check for IS_ERR() instead of NULL",
        "Message-ID": "<20170826061205.nkfvekwgzpfgfuhh@mwanda>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=us-ascii",
        "Content-Disposition": "inline",
        "X-Mailer": "git-send-email haha only kidding",
        "User-Agent": "NeoMutt/20170609 (1.8.3)",
        "X-Source-IP": "userv0022.oracle.com [156.151.31.74]",
        "Sender": "sparclinux-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<sparclinux.vger.kernel.org>",
        "X-Mailing-List": "sparclinux@vger.kernel.org"
    },
    "content": "The tty_alloc_driver() function never returns NULL, it returns error\npointers on error.\n\nFixes: ce808b746325 (\"sparc64: vcc: TTY driver initialization and cleanup\")\nSigned-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe sparclinux\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html",
    "diff": "diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c\nindex 5e608173b091..716729129e01 100644\n--- a/drivers/tty/vcc.c\n+++ b/drivers/tty/vcc.c\n@@ -1086,9 +1086,9 @@ static int vcc_tty_init(void)\n \tpr_info(\"VCC: %s\\n\", version);\n \n \tvcc_tty_driver = tty_alloc_driver(VCC_MAX_PORTS, VCC_TTY_FLAGS);\n-\tif (!vcc_tty_driver) {\n+\tif (IS_ERR(vcc_tty_driver)) {\n \t\tpr_err(\"VCC: TTY driver alloc failed\\n\");\n-\t\treturn -ENOMEM;\n+\t\treturn PTR_ERR(vcc_tty_driver);\n \t}\n \n \tvcc_tty_driver->driver_name = vcc_driver_name;\n",
    "prefixes": [
        "sparc-next"
    ]
}