Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806045/?format=api
{ "id": 806045, "url": "http://patchwork.ozlabs.org/api/patches/806045/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1503699492-61577-1-git-send-email-ukrishn@linux.vnet.ibm.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<1503699492-61577-1-git-send-email-ukrishn@linux.vnet.ibm.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/1503699492-61577-1-git-send-email-ukrishn@linux.vnet.ibm.com/", "date": "2017-08-25T22:18:12", "name": "[3/3] cxlflash: Fix vlun resize failure in the shrink path", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "089d19eaa341726bfac4422c60a14f4d9cf05286", "submitter": { "id": 67825, "url": "http://patchwork.ozlabs.org/api/people/67825/?format=api", "name": "Uma Krishnan", "email": "ukrishn@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1503699492-61577-1-git-send-email-ukrishn@linux.vnet.ibm.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/806045/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806045/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xfG1f3Dq3z9t3k\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 26 Aug 2017 08:24:54 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xfG1f1dzTzDqLv\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 26 Aug 2017 08:24:54 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xfFt53TqrzDrTM\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSat, 26 Aug 2017 08:18:21 +1000 (AEST)", "from pps.filterd (m0098421.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7PMDwm3073371\n\tfor <linuxppc-dev@lists.ozlabs.org>; Fri, 25 Aug 2017 18:18:19 -0400", "from e19.ny.us.ibm.com (e19.ny.us.ibm.com [129.33.205.209])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cjp41megc-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <linuxppc-dev@lists.ozlabs.org>; Fri, 25 Aug 2017 18:18:19 -0400", "from localhost\n\tby e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <linuxppc-dev@lists.ozlabs.org> from <ukrishn@linux.vnet.ibm.com>;\n\tFri, 25 Aug 2017 18:18:18 -0400", "from b01cxnp22034.gho.pok.ibm.com (9.57.198.24)\n\tby e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tFri, 25 Aug 2017 18:18:17 -0400", "from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com\n\t[9.57.199.111])\n\tby b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v7PMIGaF23134248; Fri, 25 Aug 2017 22:18:16 GMT", "from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id A6913AC03F;\n\tFri, 25 Aug 2017 18:18:39 -0400 (EDT)", "from p8tul1-build.aus.stglabs.ibm.com (unknown [9.3.141.206])\n\tby b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP id E97EEAC03A;\n\tFri, 25 Aug 2017 18:18:38 -0400 (EDT)" ], "From": "Uma Krishnan <ukrishn@linux.vnet.ibm.com>", "To": "linux-scsi@vger.kernel.org, James Bottomley <jejb@linux.vnet.ibm.com>,\n\t\"Martin K. Petersen\" <martin.petersen@oracle.com>,\n\t\"Matthew R. Ochs\" <mrochs@linux.vnet.ibm.com>,\n\t\"Manoj N. Kumar\" <manoj@linux.vnet.ibm.com>", "Subject": "[PATCH 3/3] cxlflash: Fix vlun resize failure in the shrink path", "Date": "Fri, 25 Aug 2017 17:18:12 -0500", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1503699440-61464-1-git-send-email-ukrishn@linux.vnet.ibm.com>", "References": "<1503699440-61464-1-git-send-email-ukrishn@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17082522-0056-0000-0000-000003BC79B5", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007611; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000225; SDB=6.00907628; UDB=6.00455029;\n\tIPR=6.00687827; \n\tBA=6.00005553; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016867;\n\tXFM=3.00000015; UTC=2017-08-25 22:18:18", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17082522-0057-0000-0000-000007F2AA0A", "Message-Id": "<1503699492-61577-1-git-send-email-ukrishn@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-25_06:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=2\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708250339", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "linuxppc-dev@lists.ozlabs.org,\n\tFrederic Barrat <fbarrat@linux.vnet.ibm.com>, \n\tAndrew Donnellan <andrew.donnellan@au1.ibm.com>,\n\tChristophe Lombard <clombard@linux.vnet.ibm.com>", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "The ioctl DK_CAPI_VLUN_RESIZE can fail if the allocated vlun size is\nreduced from almost maximum capacity and then increased again.\n\nThe shrink_lxt() routine is currently using the SISL_ASTATUS_MASK to mask\nthe higher 48 bits of the lxt entry. This is unnecessary and incorrect as\nit uses a mask designed for the asynchronous interrupt status register.\nWhen the 4 port support was added to cxlflash, the SISL_ASTATUS_MASK was\nupdated to reflect the status bits for all 4 ports. This change indirectly\naffected the shrink_lxt() code path.\n\nTo extract the base, simply shift the bits without masking.\n\nFixes: 565180723294 (\"scsi: cxlflash: SISlite updates to support 4 ports\")\n\nSigned-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>\n---\n drivers/scsi/cxlflash/vlun.c | 6 +-----\n 1 file changed, 1 insertion(+), 5 deletions(-)", "diff": "diff --git a/drivers/scsi/cxlflash/vlun.c b/drivers/scsi/cxlflash/vlun.c\nindex bdfb930..703bf1e 100644\n--- a/drivers/scsi/cxlflash/vlun.c\n+++ b/drivers/scsi/cxlflash/vlun.c\n@@ -694,11 +694,7 @@ static int shrink_lxt(struct afu *afu,\n \t/* Free LBAs allocated to freed chunks */\n \tmutex_lock(&blka->mutex);\n \tfor (i = delta - 1; i >= 0; i--) {\n-\t\t/* Mask the higher 48 bits before shifting, even though\n-\t\t * it is a noop\n-\t\t */\n-\t\taun = (lxt_old[my_new_size + i].rlba_base & SISL_ASTATUS_MASK);\n-\t\taun = (aun >> MC_CHUNK_SHIFT);\n+\t\taun = lxt_old[my_new_size + i].rlba_base >> MC_CHUNK_SHIFT;\n \t\tif (needs_ws)\n \t\t\twrite_same16(sdev, aun, MC_CHUNK_SIZE);\n \t\tba_free(&blka->ba_lun, aun);\n", "prefixes": [ "3/3" ] }