Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806043/?format=api
{ "id": 806043, "url": "http://patchwork.ozlabs.org/api/patches/806043/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1503699810-12803-2-git-send-email-isubramanian@apm.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503699810-12803-2-git-send-email-isubramanian@apm.com>", "list_archive_url": null, "date": "2017-08-25T22:23:29", "name": "[1/2] drivers: net: xgene: Correct probe sequence handling", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "79c2711248173dfac1a0eb6e0e53cd2bf74c2061", "submitter": { "id": 47568, "url": "http://patchwork.ozlabs.org/api/people/47568/?format=api", "name": "Iyappan Subramanian", "email": "isubramanian@apm.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1503699810-12803-2-git-send-email-isubramanian@apm.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/806043/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806043/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=apm.com header.i=@apm.com header.b=\"SSgYLZ8E\";\n\tdkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xfG0S6mTPz9t3k\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 26 Aug 2017 08:23:52 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S934857AbdHYWXv (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 25 Aug 2017 18:23:51 -0400", "from mail-pg0-f50.google.com ([74.125.83.50]:38282 \"EHLO\n\tmail-pg0-f50.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S933777AbdHYWXs (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 25 Aug 2017 18:23:48 -0400", "by mail-pg0-f50.google.com with SMTP id b8so5663368pgn.5\n\tfor <netdev@vger.kernel.org>; Fri, 25 Aug 2017 15:23:48 -0700 (PDT)", "from isubrama-dev.amcc.com ([206.80.4.98])\n\tby smtp.gmail.com with ESMTPSA id\n\tc80sm13889519pfj.26.2017.08.25.15.23.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 25 Aug 2017 15:23:46 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=apm.com; s=apm;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=TpAWZn2aLl6SBtbyAVvw6mlUIyJkdVqlBfZk/Sw02XU=;\n\tb=SSgYLZ8Exqf9kj1oERaLJHGz+l4NHwVvCU73x4Vc4//BMbNF1cdnS4s0Vv3WxZEtQA\n\t82F1HLSLOwPAcdbHKL2U8tuO6vuLFprLW4Q5S21ILJoRZwLqxsmOOI2lS5BZ9hK08qUm\n\t0uLR6ZJKFwdyzIGjhxL3+a8dzW+KOiQuwLABs=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=TpAWZn2aLl6SBtbyAVvw6mlUIyJkdVqlBfZk/Sw02XU=;\n\tb=NGmFvVgq3J0VcYGW4AvDmzMRrmgpAFsDDkpvAoGbMIq8Z0OIca/oBNNepAeiX11j5n\n\tSwl4MkekcrNgkU2S7XPRDWecUFHi9XNUJh8Mz0kxz3RxG2Tcy6PkwbFRkOXZTf32RTSZ\n\tB+T/d2yHgjL9KrbMd09tbLv8ZK9wc1Vza6PmtbhcAr9WHlsO/Z6kYTIuySAVpcfoPHq0\n\thhBzAuAzOQaxMyhUjzRP9PeZHAZBNerJTJW5dltFSf1KoIFX1+YfICDiCxF580LeMQVh\n\t+QFMNZLN8y6pnpRZuxPYD71UlcFR0D0Xb0T1Ai5epFg6cg0scnD0dohm46Bqe2D4XSWS\n\teIWA==", "X-Gm-Message-State": "AHYfb5iKl16nGDpzFCLchxM4iTszf2KQ7jEz8aOBOxGrhByVJYW4SUB8\n\tgUcygskxeaKiVQcE", "X-Received": "by 10.98.220.93 with SMTP id t90mr11380756pfg.158.1503699827977; \n\tFri, 25 Aug 2017 15:23:47 -0700 (PDT)", "From": "Iyappan Subramanian <isubramanian@apm.com>", "To": "davem@davemloft.net, netdev@vger.kernel.org", "Cc": "linux-arm-kernel@lists.infradead.org, dnelson@redhat.com,\n\tqnguyen@apm.com, patches@apm.com,\n\tIyappan Subramanian <isubramanian@apm.com>", "Subject": "[PATCH 1/2] drivers: net: xgene: Correct probe sequence handling", "Date": "Fri, 25 Aug 2017 15:23:29 -0700", "Message-Id": "<1503699810-12803-2-git-send-email-isubramanian@apm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1503699810-12803-1-git-send-email-isubramanian@apm.com>", "References": "<1503699810-12803-1-git-send-email-isubramanian@apm.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Quan Nguyen <qnguyen@apm.com>\n\nThe phy is connected at early stage of probe but not properly\ndisconnected if error occurs. This patch fixes the issue.\n\nAlso changing the return type of xgene_enet_check_phy_handle(),\nsince this function always returns success.\n\nSigned-off-by: Quan Nguyen <qnguyen@apm.com>\nSigned-off-by: Iyappan Subramanian <isubramanian@apm.com>\n---\n drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 27 ++++++++++++------------\n 1 file changed, 13 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c\nindex 1d307f2..6e253d9 100644\n--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c\n+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c\n@@ -1661,21 +1661,21 @@ static int xgene_enet_get_irqs(struct xgene_enet_pdata *pdata)\n \treturn 0;\n }\n \n-static int xgene_enet_check_phy_handle(struct xgene_enet_pdata *pdata)\n+static void xgene_enet_check_phy_handle(struct xgene_enet_pdata *pdata)\n {\n \tint ret;\n \n \tif (pdata->phy_mode == PHY_INTERFACE_MODE_XGMII)\n-\t\treturn 0;\n+\t\treturn;\n \n \tif (!IS_ENABLED(CONFIG_MDIO_XGENE))\n-\t\treturn 0;\n+\t\treturn;\n \n \tret = xgene_enet_phy_connect(pdata->ndev);\n \tif (!ret)\n \t\tpdata->mdio_driver = true;\n \n-\treturn 0;\n+\treturn;\n }\n \n static void xgene_enet_gpiod_get(struct xgene_enet_pdata *pdata)\n@@ -1779,10 +1779,6 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata)\n \tif (ret)\n \t\treturn ret;\n \n-\tret = xgene_enet_check_phy_handle(pdata);\n-\tif (ret)\n-\t\treturn ret;\n-\n \txgene_enet_gpiod_get(pdata);\n \n \tpdata->clk = devm_clk_get(&pdev->dev, NULL);\n@@ -2097,9 +2093,11 @@ static int xgene_enet_probe(struct platform_device *pdev)\n \t\tgoto err;\n \t}\n \n+\txgene_enet_check_phy_handle(pdata);\n+\n \tret = xgene_enet_init_hw(pdata);\n \tif (ret)\n-\t\tgoto err;\n+\t\tgoto err2;\n \n \tlink_state = pdata->mac_ops->link_state;\n \tif (pdata->phy_mode == PHY_INTERFACE_MODE_XGMII) {\n@@ -2117,29 +2115,30 @@ static int xgene_enet_probe(struct platform_device *pdev)\n \tspin_lock_init(&pdata->stats_lock);\n \tret = xgene_extd_stats_init(pdata);\n \tif (ret)\n-\t\tgoto err2;\n+\t\tgoto err1;\n \n \txgene_enet_napi_add(pdata);\n \tret = register_netdev(ndev);\n \tif (ret) {\n \t\tnetdev_err(ndev, \"Failed to register netdev\\n\");\n-\t\tgoto err2;\n+\t\tgoto err1;\n \t}\n \n \treturn 0;\n \n-err2:\n+err1:\n \t/*\n \t * If necessary, free_netdev() will call netif_napi_del() and undo\n \t * the effects of xgene_enet_napi_add()'s calls to netif_napi_add().\n \t */\n \n+\txgene_enet_delete_desc_rings(pdata);\n+\n+err2:\n \tif (pdata->mdio_driver)\n \t\txgene_enet_phy_disconnect(pdata);\n \telse if (phy_interface_mode_is_rgmii(pdata->phy_mode))\n \t\txgene_enet_mdio_remove(pdata);\n-err1:\n-\txgene_enet_delete_desc_rings(pdata);\n err:\n \tfree_netdev(ndev);\n \treturn ret;\n", "prefixes": [ "1/2" ] }