Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 806024,
    "url": "http://patchwork.ozlabs.org/api/patches/806024/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170825213957.4768-1-jakub.kicinski@netronome.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170825213957.4768-1-jakub.kicinski@netronome.com>",
    "list_archive_url": null,
    "date": "2017-08-25T21:39:57",
    "name": "[net-next] selftests/bpf: check the instruction dumps are populated",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "59ea6af73d5a4c4801c2be3da0c7bcf7d422fe20",
    "submitter": {
        "id": 67484,
        "url": "http://patchwork.ozlabs.org/api/people/67484/?format=api",
        "name": "Jakub Kicinski",
        "email": "jakub.kicinski@netronome.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170825213957.4768-1-jakub.kicinski@netronome.com/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/806024/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/806024/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=netronome-com.20150623.gappssmtp.com\n\theader.i=@netronome-com.20150623.gappssmtp.com\n\theader.b=\"ENDDz3j5\"; dkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xfF2M2Zwpz9sRY\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 26 Aug 2017 07:40:27 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S934756AbdHYVkZ (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 25 Aug 2017 17:40:25 -0400",
            "from mail-pg0-f48.google.com ([74.125.83.48]:34926 \"EHLO\n\tmail-pg0-f48.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932688AbdHYVkX (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 25 Aug 2017 17:40:23 -0400",
            "by mail-pg0-f48.google.com with SMTP id 63so5288730pgc.2\n\tfor <netdev@vger.kernel.org>; Fri, 25 Aug 2017 14:40:23 -0700 (PDT)",
            "from jkicinski-Precision-T1700.netronome.com ([75.53.12.129])\n\tby smtp.gmail.com with ESMTPSA id\n\tw66sm12937667pfi.63.2017.08.25.14.40.21\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 25 Aug 2017 14:40:22 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=netronome-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=R4vjESpUtjryOJNKYHPAJ0fljJrmNm0BCFHtrNHvAj8=;\n\tb=ENDDz3j5io3oyuh3XXfrqN7IEJCY50PWlnS3I3LU++sbYu/MglS4uSk8CoZi2Z8km/\n\tUv2ekcT7TQUr7uRSPDoVzA64+BCieEy3IaM76IVIq/uG65Zw59yCHUbGOnCHRqM9ZGuP\n\tVnXhaynHOKBnqK49o1ITxh6ie6vExLnDJRWvaayaL70IlYfU71Pe1/Q73NJ/fxIVp+D0\n\tsrzTqLgNDr3A4/sbUWbdsz7vXpdBd0v3rQNK0XcTPz2/0cdTQmXq4/RhQyY2FCgkgVoY\n\tzvNT4gy4NwcC2iWc3ok3w1oBlXt8xsENNvNGgiOkMoggIJqYIetwvhlZ62Ze5gYdkodF\n\tkojQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=R4vjESpUtjryOJNKYHPAJ0fljJrmNm0BCFHtrNHvAj8=;\n\tb=cCb7JJwWN3bc89aaEWh78qOAwADgVTz9pguzKuu4XPTgteVtNibTZYtshIFUxxx/hW\n\tBUl2Ynmx65zAl0fY9ellJCk4krWBzje1TNHunXvv/L6lGya8zjFqTD6l0WkfYn+PVsrE\n\tXptNRyN2l2mjRf2pfSPZQjR2SUiV11qzCuWu8iow79kYpV6Q0RBpxG7dkUPcsUkUTCP4\n\tmzTUBFi1TWgFdzvn9MMKPE6GlHres+bxZvPrqAqso7VP93WzRAcAknqKLMt0Iwacl+p9\n\tQmDP8MWHPRPZTnM2lAqxNgcTjo3Q7j5iQevTbh39Dc+WXZ98ufDtiE32sZbhhetFKU7v\n\tcKDA==",
        "X-Gm-Message-State": "AHYfb5gBVRGX/SsEW6X/N56UQ+mYMCXPCB0pILelDnu+18kJNvdv9JLh\n\tluVhMOuU7xwJtGw9L9M=",
        "X-Received": "by 10.99.114.29 with SMTP id n29mr10900306pgc.153.1503697222840; \n\tFri, 25 Aug 2017 14:40:22 -0700 (PDT)",
        "From": "Jakub Kicinski <jakub.kicinski@netronome.com>",
        "To": "netdev@vger.kernel.org",
        "Cc": "daniel@iogearbox.net, kafai@fb.com, oss-drivers@netronome.com,\n\tJakub Kicinski <jakub.kicinski@netronome.com>",
        "Subject": "[PATCH net-next] selftests/bpf: check the instruction dumps are\n\tpopulated",
        "Date": "Fri, 25 Aug 2017 14:39:57 -0700",
        "Message-Id": "<20170825213957.4768-1-jakub.kicinski@netronome.com>",
        "X-Mailer": "git-send-email 2.11.0",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "Add a basic test for checking whether kernel is populating\nthe jited and xlated BPF images.  It was used to confirm\nthe behaviour change from commit d777b2ddbecf (\"bpf: don't \nzero out the info struct in bpf_obj_get_info_by_fd()\"),\nwhich made bpf_obj_get_info_by_fd() usable for retrieving\nthe image dumps.\n\nSigned-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>\n---\n tools/testing/selftests/bpf/test_progs.c | 16 ++++++++++++----\n 1 file changed, 12 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c\nindex 1cb037803679..11ee25cea227 100644\n--- a/tools/testing/selftests/bpf/test_progs.c\n+++ b/tools/testing/selftests/bpf/test_progs.c\n@@ -279,7 +279,7 @@ static void test_bpf_obj_id(void)\n \t/* +1 to test for the info_len returned by kernel */\n \tstruct bpf_prog_info prog_infos[nr_iters + 1];\n \tstruct bpf_map_info map_infos[nr_iters + 1];\n-\tchar jited_insns[128], xlated_insns[128];\n+\tchar jited_insns[128], xlated_insns[128], zeros[128];\n \t__u32 i, next_id, info_len, nr_id_found, duration = 0;\n \tint sysctl_fd, jit_enabled = 0, err = 0;\n \t__u64 array_value;\n@@ -305,6 +305,7 @@ static void test_bpf_obj_id(void)\n \t\tobjs[i] = NULL;\n \n \t/* Check bpf_obj_get_info_by_fd() */\n+\tbzero(zeros, sizeof(zeros));\n \tfor (i = 0; i < nr_iters; i++) {\n \t\terr = bpf_prog_load(file, BPF_PROG_TYPE_SOCKET_FILTER,\n \t\t\t\t    &objs[i], &prog_fds[i]);\n@@ -318,6 +319,8 @@ static void test_bpf_obj_id(void)\n \t\t/* Check getting prog info */\n \t\tinfo_len = sizeof(struct bpf_prog_info) * 2;\n \t\tbzero(&prog_infos[i], info_len);\n+\t\tbzero(jited_insns, sizeof(jited_insns));\n+\t\tbzero(xlated_insns, sizeof(xlated_insns));\n \t\tprog_infos[i].jited_prog_insns = ptr_to_u64(jited_insns);\n \t\tprog_infos[i].jited_prog_len = sizeof(jited_insns);\n \t\tprog_infos[i].xlated_prog_insns = ptr_to_u64(xlated_insns);\n@@ -328,15 +331,20 @@ static void test_bpf_obj_id(void)\n \t\t\t  prog_infos[i].type != BPF_PROG_TYPE_SOCKET_FILTER ||\n \t\t\t  info_len != sizeof(struct bpf_prog_info) ||\n \t\t\t  (jit_enabled && !prog_infos[i].jited_prog_len) ||\n-\t\t\t  !prog_infos[i].xlated_prog_len,\n+\t\t\t  (jit_enabled &&\n+\t\t\t   !memcmp(jited_insns, zeros, sizeof(zeros))) ||\n+\t\t\t  !prog_infos[i].xlated_prog_len ||\n+\t\t\t  !memcmp(xlated_insns, zeros, sizeof(zeros)),\n \t\t\t  \"get-prog-info(fd)\",\n-\t\t\t  \"err %d errno %d i %d type %d(%d) info_len %u(%lu) jit_enabled %d jited_prog_len %u xlated_prog_len %u\\n\",\n+\t\t\t  \"err %d errno %d i %d type %d(%d) info_len %u(%lu) jit_enabled %d jited_prog_len %u xlated_prog_len %u jited_prog %d xlated_prog %d\\n\",\n \t\t\t  err, errno, i,\n \t\t\t  prog_infos[i].type, BPF_PROG_TYPE_SOCKET_FILTER,\n \t\t\t  info_len, sizeof(struct bpf_prog_info),\n \t\t\t  jit_enabled,\n \t\t\t  prog_infos[i].jited_prog_len,\n-\t\t\t  prog_infos[i].xlated_prog_len))\n+\t\t\t  prog_infos[i].xlated_prog_len,\n+\t\t\t  !!memcmp(jited_insns, zeros, sizeof(zeros)),\n+\t\t\t  !!memcmp(xlated_insns, zeros, sizeof(zeros))))\n \t\t\tgoto done;\n \n \t\tmap_fds[i] = bpf_find_map(__func__, objs[i], \"test_map_id\");\n",
    "prefixes": [
        "net-next"
    ]
}