Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806016/?format=api
{ "id": 806016, "url": "http://patchwork.ozlabs.org/api/patches/806016/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170825202714.64ivixeindjph3z6@mwanda/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170825202714.64ivixeindjph3z6@mwanda>", "list_archive_url": null, "date": "2017-08-25T20:27:14", "name": "[net-next] bpf: fix oops on allocation failure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "48a92fc1cf5015f607b77fbfa1a768d170130bb2", "submitter": { "id": 9327, "url": "http://patchwork.ozlabs.org/api/people/9327/?format=api", "name": "Dan Carpenter", "email": "dan.carpenter@oracle.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170825202714.64ivixeindjph3z6@mwanda/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/806016/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806016/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xfCQd6X4mz9sNv\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 26 Aug 2017 06:27:53 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1758598AbdHYU1w (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 25 Aug 2017 16:27:52 -0400", "from aserp1040.oracle.com ([141.146.126.69]:40386 \"EHLO\n\taserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1758576AbdHYU1t (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 25 Aug 2017 16:27:49 -0400", "from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id v7PKRV8c012861\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Fri, 25 Aug 2017 20:27:31 GMT", "from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235])\n\tby userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv7PKRUOg011927\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Fri, 25 Aug 2017 20:27:31 GMT", "from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20])\n\tby aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tv7PKRUoR030504; Fri, 25 Aug 2017 20:27:30 GMT", "from mwanda (/41.202.241.62)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Fri, 25 Aug 2017 13:27:29 -0700" ], "Date": "Fri, 25 Aug 2017 23:27:14 +0300", "From": "Dan Carpenter <dan.carpenter@oracle.com>", "To": "Alexei Starovoitov <ast@kernel.org>,\n\tJohn Fastabend <john.fastabend@gmail.com>", "Cc": "Daniel Borkmann <daniel@iogearbox.net>, netdev@vger.kernel.org,\n\tkernel-janitors@vger.kernel.org", "Subject": "[PATCH net-next] bpf: fix oops on allocation failure", "Message-ID": "<20170825202714.64ivixeindjph3z6@mwanda>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "X-Mailer": "git-send-email haha only kidding", "User-Agent": "NeoMutt/20170609 (1.8.3)", "X-Source-IP": "userv0022.oracle.com [156.151.31.74]", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "\"err\" is set to zero if bpf_map_area_alloc() fails so it means we return\nERR_PTR(0) which is NULL. The caller, find_and_alloc_map(), is not\nexpecting NULL returns and will oops.\n\nFixes: 174a79ff9515 (\"bpf: sockmap with sk redirect support\")\nSigned-off-by: Dan Carpenter <dan.carpenter@oracle.com>", "diff": "diff --git a/kernel/bpf/sockmap.c b/kernel/bpf/sockmap.c\nindex 78b2bb9370ac..a11b9f52ea4a 100644\n--- a/kernel/bpf/sockmap.c\n+++ b/kernel/bpf/sockmap.c\n@@ -497,6 +497,7 @@ static struct bpf_map *sock_map_alloc(union bpf_attr *attr)\n \tif (err)\n \t\tgoto free_stab;\n \n+\terr = -ENOMEM;\n \tstab->sock_map = bpf_map_area_alloc(stab->map.max_entries *\n \t\t\t\t\t sizeof(struct sock *),\n \t\t\t\t\t stab->map.numa_node);\n", "prefixes": [ "net-next" ] }