Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/805959/?format=api
{ "id": 805959, "url": "http://patchwork.ozlabs.org/api/patches/805959/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/1503677551-5085-3-git-send-email-yamada.masahiro@socionext.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503677551-5085-3-git-send-email-yamada.masahiro@socionext.com>", "list_archive_url": null, "date": "2017-08-25T16:12:31", "name": "[U-Boot,2/2] mtd: nand: denali_dt: add a DT driver", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ce462deb21f73c201db4fe51d721270d7d83b161", "submitter": { "id": 65882, "url": "http://patchwork.ozlabs.org/api/people/65882/?format=api", "name": "Masahiro Yamada", "email": "yamada.masahiro@socionext.com" }, "delegate": { "id": 38701, "url": "http://patchwork.ozlabs.org/api/users/38701/?format=api", "username": "masahir0y", "first_name": "Masahiro", "last_name": "Yamada", "email": "yamada.m@jp.panasonic.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/1503677551-5085-3-git-send-email-yamada.masahiro@socionext.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/805959/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/805959/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"n9G0OZWf\"; dkim-atps=neutral" ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xf5nv58y9z9sMN\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 26 Aug 2017 02:14:11 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid 4EBDAC21F82; Fri, 25 Aug 2017 16:13:31 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 793A1C21F70;\n\tFri, 25 Aug 2017 16:13:14 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 41637C21F64; Fri, 25 Aug 2017 16:13:09 +0000 (UTC)", "from conuserg-09.nifty.com (conuserg-09.nifty.com [210.131.2.76])\n\tby lists.denx.de (Postfix) with ESMTPS id 64F74C21F6B\n\tfor <u-boot@lists.denx.de>; Fri, 25 Aug 2017 16:13:08 +0000 (UTC)", "from grover.sesame (FL1-122-131-185-176.osk.mesh.ad.jp\n\t[122.131.185.176]) (authenticated)\n\tby conuserg-09.nifty.com with ESMTP id v7PGCg5q016083;\n\tSat, 26 Aug 2017 01:12:43 +0900" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=T_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0", "DKIM-Filter": "OpenDKIM Filter v2.10.3 conuserg-09.nifty.com v7PGCg5q016083", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1503677564;\n\tbh=cAiWHZs7RG5CRnB6dHM44EH/AtwgR7dNXK6YT1Rbhms=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=n9G0OZWfwQ6ltZ3ST6qVwA8AkqYdFmw9iAjQzu03CHCeDDsw2Y+QYnkYRJvtGzak8\n\tbwYSPFve5/y7zAWeZt7KrL7J+gGFSjWl05Z6EJ2HbN3r469aGppxQYt8bDBGg8cTn2\n\tUITJ3KtCAJQj0NkhFovyZINRpfx0xEemOY19MczhoxX4s9r6ZhwP/o0Ooq8H5sKpPd\n\tYkqOnfAXgeVCWakhISSMJwNrCj1A2S9mdaF9/LpKYtCH/U9oAepTD2a17BUEW4KYHn\n\tcsWXFogTedsxRDaLE9Ejw8TPkWAeV0GTBvhPeVjAj0onmFlW+7YOZJS5/1Zwo39NtK\n\tR4aEsRy2cz9vw==", "X-Nifty-SrcIP": "[122.131.185.176]", "From": "Masahiro Yamada <yamada.masahiro@socionext.com>", "To": "u-boot@lists.denx.de", "Date": "Sat, 26 Aug 2017 01:12:31 +0900", "Message-Id": "<1503677551-5085-3-git-send-email-yamada.masahiro@socionext.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1503677551-5085-1-git-send-email-yamada.masahiro@socionext.com>", "References": "<1503677551-5085-1-git-send-email-yamada.masahiro@socionext.com>", "Cc": "Scott Wood <oss@buserror.net>, Scott Wood <scottwood@freescale.com>", "Subject": "[U-Boot] [PATCH 2/2] mtd: nand: denali_dt: add a DT driver", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "A patch for NAND uclass support was proposed about half a year:\nhttps://patchwork.ozlabs.org/patch/722282/\n\nIt was not merged and I do not see on-going work for this.\n\nWithout DM-based probing, we need to set up pinctrl etc. in an ad-hoc\nway and give lots of crappy CONFIG options for base addresses and\nproperties, which are supposed to be specified by DT. This is painful.\n\nThis commit just provides a probe hook to retrieve \"reg\" from DT and\nallocate private data in a DM manner. This DT driver is not essentially\na NAND driver, in fact it is (ab)using UCLASS_MISC. Once UCLASS_NAND is\nsupported, it would be possible to migrate to it.\n\nSigned-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>\n---\n\n drivers/mtd/nand/Kconfig | 7 +++++\n drivers/mtd/nand/Makefile | 1 +\n drivers/mtd/nand/denali.c | 4 ++-\n drivers/mtd/nand/denali.h | 2 ++\n drivers/mtd/nand/denali_dt.c | 67 ++++++++++++++++++++++++++++++++++++++++++++\n 5 files changed, 80 insertions(+), 1 deletion(-)\n create mode 100644 drivers/mtd/nand/denali_dt.c", "diff": "diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig\nindex 71d678fc66b5..85b26d608851 100644\n--- a/drivers/mtd/nand/Kconfig\n+++ b/drivers/mtd/nand/Kconfig\n@@ -16,6 +16,13 @@ config NAND_DENALI\n \thelp\n \t Enable support for the Denali NAND controller.\n \n+config NAND_DENALI_DT\n+\tbool \"Support Denali NAND controller as a DT device\"\n+\tdepends on NAND_DENALI && OF_CONTROL && DM\n+\thelp\n+\t Enable the driver for NAND flash on platforms using a Denali NAND\n+\t controller as a DT device.\n+\n config SYS_NAND_DENALI_64BIT\n \tbool \"Use 64-bit variant of Denali NAND controller\"\n \tdepends on NAND_DENALI\ndiff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile\nindex c3d4a996f37f..9f7d9d6ff7ae 100644\n--- a/drivers/mtd/nand/Makefile\n+++ b/drivers/mtd/nand/Makefile\n@@ -44,6 +44,7 @@ obj-$(CONFIG_NAND_ATMEL) += atmel_nand.o\n obj-$(CONFIG_NAND_ARASAN) += arasan_nfc.o\n obj-$(CONFIG_NAND_DAVINCI) += davinci_nand.o\n obj-$(CONFIG_NAND_DENALI) += denali.o\n+obj-$(CONFIG_NAND_DENALI_DT) += denali_dt.o\n obj-$(CONFIG_NAND_FSL_ELBC) += fsl_elbc_nand.o\n obj-$(CONFIG_NAND_FSL_IFC) += fsl_ifc_nand.o\n obj-$(CONFIG_NAND_FSL_UPM) += fsl_upm.o\ndiff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c\nindex 18280b0b2fe8..47cf37d1d9b7 100644\n--- a/drivers/mtd/nand/denali.c\n+++ b/drivers/mtd/nand/denali.c\n@@ -1175,7 +1175,7 @@ static void denali_hw_init(struct denali_nand_info *denali)\n \n static struct nand_ecclayout nand_oob;\n \n-static int denali_init(struct denali_nand_info *denali)\n+int denali_init(struct denali_nand_info *denali)\n {\n \tstruct mtd_info *mtd = nand_to_mtd(&denali->nand);\n \tint ret;\n@@ -1273,6 +1273,7 @@ fail:\n \treturn ret;\n }\n \n+#ifndef CONFIG_NAND_DENALI_DT\n static int __board_nand_init(void)\n {\n \tstruct denali_nand_info *denali;\n@@ -1296,3 +1297,4 @@ void board_nand_init(void)\n \tif (__board_nand_init() < 0)\n \t\tpr_warn(\"Failed to initialize Denali NAND controller.\\n\");\n }\n+#endif\ndiff --git a/drivers/mtd/nand/denali.h b/drivers/mtd/nand/denali.h\nindex 0e098bddf11d..694bce53a955 100644\n--- a/drivers/mtd/nand/denali.h\n+++ b/drivers/mtd/nand/denali.h\n@@ -464,4 +464,6 @@ struct denali_nand_info {\n \tuint32_t max_banks;\n };\n \n+int denali_init(struct denali_nand_info *denali);\n+\n #endif /* __DENALI_H__ */\ndiff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c\nnew file mode 100644\nindex 000000000000..6a987c5b7880\n--- /dev/null\n+++ b/drivers/mtd/nand/denali_dt.c\n@@ -0,0 +1,67 @@\n+/*\n+ * Copyright (C) 2017 Socionext Inc.\n+ * Author: Masahiro Yamada <yamada.masahiro@socionext.com>\n+ *\n+ * SPDX-License-Identifier:\tGPL-2.0+\n+ */\n+\n+#include <common.h>\n+#include <dm.h>\n+#include <linux/io.h>\n+#include <linux/ioport.h>\n+\n+#include \"denali.h\"\n+\n+static const struct udevice_id denali_nand_dt_ids[] = {\n+\t{\n+\t\t.compatible = \"altr,socfpga-denali-nand\",\n+\t},\n+\t{\n+\t\t.compatible = \"socionext,uniphier-denali-nand-v5a\",\n+\t},\n+\t{\n+\t\t.compatible = \"socionext,uniphier-denali-nand-v5b\",\n+\t},\n+\t{ /* sentinel */ }\n+};\n+\n+static int denali_dt_probe(struct udevice *dev)\n+{\n+\tstruct denali_nand_info *denali = dev_get_priv(dev);\n+\tstruct resource res;\n+\tint ret;\n+\n+\tret = dev_read_resource_byname(dev, \"denali_reg\", &res);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tdenali->flash_reg = devm_ioremap(dev, res.start, resource_size(&res));\n+\n+\tret = dev_read_resource_byname(dev, \"nand_data\", &res);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tdenali->flash_mem = devm_ioremap(dev, res.start, resource_size(&res));\n+\n+\treturn denali_init(denali);\n+}\n+\n+U_BOOT_DRIVER(denali_nand_dt) = {\n+\t.name = \"denali-nand-dt\",\n+\t.id = UCLASS_MISC,\n+\t.of_match = denali_nand_dt_ids,\n+\t.probe = denali_dt_probe,\n+\t.priv_auto_alloc_size = sizeof(struct denali_nand_info),\n+};\n+\n+void board_nand_init(void)\n+{\n+\tstruct udevice *dev;\n+\tint ret;\n+\n+\tret = uclass_get_device_by_driver(UCLASS_MISC,\n+\t\t\t\t\t DM_GET_DRIVER(denali_nand_dt),\n+\t\t\t\t\t &dev);\n+\tif (ret)\n+\t\tprintf(\"Failed to initialize Denali NAND controller.\\n\");\n+}\n", "prefixes": [ "U-Boot", "2/2" ] }