Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 805858,
    "url": "http://patchwork.ozlabs.org/api/patches/805858/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/150366627224.16965.12554507587831320156.stgit@firesoul/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<150366627224.16965.12554507587831320156.stgit@firesoul>",
    "list_archive_url": null,
    "date": "2017-08-25T13:04:32",
    "name": "net: missing call of trace_napi_poll in busy_poll_stop",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "448de5d55d083c665f432eb5fa32804e463c8328",
    "submitter": {
        "id": 13625,
        "url": "http://patchwork.ozlabs.org/api/people/13625/?format=api",
        "name": "Jesper Dangaard Brouer",
        "email": "brouer@redhat.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/150366627224.16965.12554507587831320156.stgit@firesoul/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/805858/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/805858/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com",
            "ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=brouer@redhat.com"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xf1bD1835z9sPm\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 25 Aug 2017 23:04:39 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755912AbdHYNEh (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 25 Aug 2017 09:04:37 -0400",
            "from mx1.redhat.com ([209.132.183.28]:57796 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1755340AbdHYNEg (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tFri, 25 Aug 2017 09:04:36 -0400",
            "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id BB3CE61462\n\tfor <netdev@vger.kernel.org>; Fri, 25 Aug 2017 13:04:36 +0000 (UTC)",
            "from firesoul.localdomain (ovpn-200-32.brq.redhat.com\n\t[10.40.200.32])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 72B7380E67;\n\tFri, 25 Aug 2017 13:04:33 +0000 (UTC)",
            "from [192.168.5.1] (localhost [IPv6:::1])\n\tby firesoul.localdomain (Postfix) with ESMTP id 595FE300011C6;\n\tFri, 25 Aug 2017 15:04:32 +0200 (CEST)"
        ],
        "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com BB3CE61462",
        "Subject": "[PATCH] net: missing call of trace_napi_poll in busy_poll_stop",
        "From": "Jesper Dangaard Brouer <brouer@redhat.com>",
        "To": "netdev@vger.kernel.org",
        "Cc": "Jesper Dangaard Brouer <brouer@redhat.com>",
        "Date": "Fri, 25 Aug 2017 15:04:32 +0200",
        "Message-ID": "<150366627224.16965.12554507587831320156.stgit@firesoul>",
        "User-Agent": "StGit/0.17.1-dirty",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=\"utf-8\"",
        "Content-Transfer-Encoding": "7bit",
        "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12",
        "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tFri, 25 Aug 2017 13:04:36 +0000 (UTC)",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "Noticed that busy_poll_stop() also invoke the drivers napi->poll()\nfunction pointer, but didn't have an associated call to trace_napi_poll()\nlike all other call sites.\n\nSigned-off-by: Jesper Dangaard Brouer <brouer@redhat.com>\n---\n net/core/dev.c |    1 +\n 1 file changed, 1 insertion(+)",
    "diff": "diff --git a/net/core/dev.c b/net/core/dev.c\nindex 270b54754821..a24d2fb691ed 100644\n--- a/net/core/dev.c\n+++ b/net/core/dev.c\n@@ -5319,6 +5319,7 @@ static void busy_poll_stop(struct napi_struct *napi, void *have_poll_lock)\n \t * Ideally, a new ndo_busy_poll_stop() could avoid another round.\n \t */\n \trc = napi->poll(napi, BUSY_POLL_BUDGET);\n+\ttrace_napi_poll(napi, rc, BUSY_POLL_BUDGET);\n \tnetpoll_poll_unlock(have_poll_lock);\n \tif (rc == BUSY_POLL_BUDGET)\n \t\t__napi_schedule(napi);\n",
    "prefixes": []
}