Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/805821/?format=api
{ "id": 805821, "url": "http://patchwork.ozlabs.org/api/patches/805821/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170825103340.op3uphrv3eyeutiz@mwanda/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20170825103340.op3uphrv3eyeutiz@mwanda>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20170825103340.op3uphrv3eyeutiz@mwanda/", "date": "2017-08-25T10:33:40", "name": "powerpc/44x: mask and shift to zero bug", "commit_ref": "8d046759f6ad75824fdf7b9c9a3da0272ea9ea92", "pull_url": null, "state": "accepted", "archived": false, "hash": "5efc21c57e3736aaaf368ff227a5d962d15cedec", "submitter": { "id": 9327, "url": "http://patchwork.ozlabs.org/api/people/9327/?format=api", "name": "Dan Carpenter", "email": "dan.carpenter@oracle.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170825103340.op3uphrv3eyeutiz@mwanda/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/805821/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/805821/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xdyGq4xYfz9sDB\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 25 Aug 2017 20:35:15 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xdyGq428pzDrXP\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 25 Aug 2017 20:35:15 +1000 (AEST)", "from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xdyFh2hZNzDrKj\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tFri, 25 Aug 2017 20:34:16 +1000 (AEST)", "from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2)\n\twith ESMTP id v7PAXu5N017820\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Fri, 25 Aug 2017 10:33:56 GMT", "from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])\n\tby aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv7PAXt7i016975\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Fri, 25 Aug 2017 10:33:55 GMT", "from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14])\n\tby aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv7PAXscH012603; Fri, 25 Aug 2017 10:33:55 GMT", "from mwanda (/41.202.241.62) by default (Oracle Beehive Gateway\n\tv4.0) with ESMTP ; Fri, 25 Aug 2017 03:33:53 -0700" ], "Date": "Fri, 25 Aug 2017 13:33:40 +0300", "From": "Dan Carpenter <dan.carpenter@oracle.com>", "To": "Benjamin Herrenschmidt <benh@kernel.crashing.org>,\n\tMatthias Fuchs <matthias.fuchs@esd-electronics.com>", "Subject": "[PATCH] powerpc/44x: mask and shift to zero bug", "Message-ID": "<20170825103340.op3uphrv3eyeutiz@mwanda>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "X-Mailer": "git-send-email haha only kidding", "User-Agent": "NeoMutt/20170609 (1.8.3)", "X-Source-IP": "aserv0021.oracle.com [141.146.126.233]", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org, Paul Mackerras <paulus@samba.org>,\n\tlinuxppc-dev@lists.ozlabs.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "My static checker complains that 0x00001800 >> 13 is zero. Looking at\nthe context, it seems like a copy and paste bug from the line below and\nprobably 0x3 << 13 or 0x00006000 was intended.\n\nFixes: 2af59f7d5c3e (\"[POWERPC] 4xx: Add 405GPr and 405EP support in boot wrapper\")\nSigned-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n---\nNot tested!", "diff": "diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c\nindex 9d3bd4c45a24..f7da65169124 100644\n--- a/arch/powerpc/boot/4xx.c\n+++ b/arch/powerpc/boot/4xx.c\n@@ -564,7 +564,7 @@ void ibm405gp_fixup_clocks(unsigned int sys_clk, unsigned int ser_clk)\n \t\tfbdv = 16;\n \tcbdv = ((pllmr & 0x00060000) >> 17) + 1; /* CPU:PLB */\n \topdv = ((pllmr & 0x00018000) >> 15) + 1; /* PLB:OPB */\n-\tppdv = ((pllmr & 0x00001800) >> 13) + 1; /* PLB:PCI */\n+\tppdv = ((pllmr & 0x00006000) >> 13) + 1; /* PLB:PCI */\n \tepdv = ((pllmr & 0x00001800) >> 11) + 2; /* PLB:EBC */\n \tudiv = ((cpc0_cr0 & 0x3e) >> 1) + 1;\n \n", "prefixes": [] }