Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/805043/?format=api
{ "id": 805043, "url": "http://patchwork.ozlabs.org/api/patches/805043/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/7c2934cbc0d787eda6f740327449d7e6e3becd9a.1503277387.git.christophe.leroy@c-s.fr/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<7c2934cbc0d787eda6f740327449d7e6e3becd9a.1503277387.git.christophe.leroy@c-s.fr>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/7c2934cbc0d787eda6f740327449d7e6e3becd9a.1503277387.git.christophe.leroy@c-s.fr/", "date": "2017-08-23T14:54:36", "name": "[3/4] powerpc/32: optimise memset()", "commit_ref": "7bf6057b962016eee57bc76295f80a26f90172f7", "pull_url": null, "state": "accepted", "archived": false, "hash": "0361cd53c51c4ae9413a153e7ebd9f5d5dc96e8c", "submitter": { "id": 5234, "url": "http://patchwork.ozlabs.org/api/people/5234/?format=api", "name": "Christophe Leroy", "email": "christophe.leroy@c-s.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/7c2934cbc0d787eda6f740327449d7e6e3becd9a.1503277387.git.christophe.leroy@c-s.fr/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/805043/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/805043/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xcrKc4Nz5z9s9Y\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 24 Aug 2017 01:03:48 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xcrKc28bnzDqlN\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 24 Aug 2017 01:03:48 +1000 (AEST)", "from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xcr740RMszDqZ1\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tThu, 24 Aug 2017 00:54:39 +1000 (AEST)", "from localhost (mailhub1-int [192.168.12.234])\n\tby localhost (Postfix) with ESMTP id 3xcr6n6dL8z9ttFQ;\n\tWed, 23 Aug 2017 16:54:25 +0200 (CEST)", "from pegase1.c-s.fr ([192.168.12.234])\n\tby localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id aF7pWbqCQLSP; Wed, 23 Aug 2017 16:54:25 +0200 (CEST)", "from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192])\n\tby pegase1.c-s.fr (Postfix) with ESMTP id 3xcr6n62C9z9ttBy;\n\tWed, 23 Aug 2017 16:54:25 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n\tby messagerie.si.c-s.fr (Postfix) with ESMTP id CB93C8B80C;\n\tWed, 23 Aug 2017 16:54:36 +0200 (CEST)", "from messagerie.si.c-s.fr ([127.0.0.1])\n\tby localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new,\n\tport 10023)\n\twith ESMTP id 7XIolaqBH41I; Wed, 23 Aug 2017 16:54:36 +0200 (CEST)", "from po15668-vm-win7.idsi0.si.c-s.fr (po15451.idsi0.si.c-s.fr\n\t[172.25.231.1])\n\tby messagerie.si.c-s.fr (Postfix) with ESMTP id A82568B802;\n\tWed, 23 Aug 2017 16:54:36 +0200 (CEST)", "by po15668-vm-win7.idsi0.si.c-s.fr (Postfix, from userid 0)\n\tid 9A01B679CE; Wed, 23 Aug 2017 16:54:36 +0200 (CEST)" ], "X-Virus-Scanned": [ "Debian amavisd-new at c-s.fr", "amavisd-new at c-s.fr" ], "Message-Id": "<7c2934cbc0d787eda6f740327449d7e6e3becd9a.1503277387.git.christophe.leroy@c-s.fr>", "In-Reply-To": "<cover.1503277387.git.christophe.leroy@c-s.fr>", "References": "<cover.1503277387.git.christophe.leroy@c-s.fr>", "From": "Christophe Leroy <christophe.leroy@c-s.fr>", "Subject": "[PATCH 3/4] powerpc/32: optimise memset()", "To": "Benjamin Herrenschmidt <benh@kernel.crashing.org>,\n\tPaul Mackerras <paulus@samba.org>,\n\tMichael Ellerman <mpe@ellerman.id.au>, Scott Wood <oss@buserror.net>", "Date": "Wed, 23 Aug 2017 16:54:36 +0200 (CEST)", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "There is no need to extend the set value to an int when the length\nis lower than 4 as in that case we only do byte stores.\nWe can therefore immediately branch to the part handling it.\nBy separating it from the normal case, we are able to eliminate\na few actions on the destination pointer.\n\nSigned-off-by: Christophe Leroy <christophe.leroy@c-s.fr>\n---\n arch/powerpc/lib/copy_32.S | 21 ++++++++++++++-------\n 1 file changed, 14 insertions(+), 7 deletions(-)", "diff": "diff --git a/arch/powerpc/lib/copy_32.S b/arch/powerpc/lib/copy_32.S\nindex a3ffeac69eca..05aaee20590f 100644\n--- a/arch/powerpc/lib/copy_32.S\n+++ b/arch/powerpc/lib/copy_32.S\n@@ -91,17 +91,17 @@ EXPORT_SYMBOL(memset16)\n * replaced by a nop once cache is active. This is done in machine_init()\n */\n _GLOBAL(memset)\n+\tcmplwi\t0,r5,4\n+\tblt\t7f\n+\n \trlwimi\tr4,r4,8,16,23\n \trlwimi\tr4,r4,16,0,15\n \n-\taddi\tr6,r3,-4\n-\tcmplwi\t0,r5,4\n-\tblt\t7f\n-\tstwu\tr4,4(r6)\n+\tstw\tr4,0(r3)\n \tbeqlr\n-\tandi.\tr0,r6,3\n+\tandi.\tr0,r3,3\n \tadd\tr5,r0,r5\n-\tsubf\tr6,r0,r6\n+\tsubf\tr6,r0,r3\n \tcmplwi\t0,r4,0\n \tbne\t2f\t/* Use normal procedure if r4 is not zero */\n _GLOBAL(memset_nocache_branch)\n@@ -132,13 +132,20 @@ _GLOBAL(memset_nocache_branch)\n 1:\tstwu\tr4,4(r6)\n \tbdnz\t1b\n 6:\tandi.\tr5,r5,3\n-7:\tcmpwi\t0,r5,0\n \tbeqlr\n \tmtctr\tr5\n \taddi\tr6,r6,3\n 8:\tstbu\tr4,1(r6)\n \tbdnz\t8b\n \tblr\n+\n+7:\tcmpwi\t0,r5,0\n+\tbeqlr\n+\tmtctr\tr5\n+\taddi\tr6,r3,-1\n+9:\tstbu\tr4,1(r6)\n+\tbdnz\t9b\n+\tblr\n EXPORT_SYMBOL(memset)\n \n /*\n", "prefixes": [ "3/4" ] }