Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/804958/?format=api
{ "id": 804958, "url": "http://patchwork.ozlabs.org/api/patches/804958/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20170823115459.2058-1-hch@lst.de/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170823115459.2058-1-hch@lst.de>", "list_archive_url": null, "date": "2017-08-23T11:54:59", "name": "PCI/msi: don't warn on irq_create_affinity_masks NULL return", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c8d9bbdd3bae4be76ab3a176724de40b4b80a267", "submitter": { "id": 82, "url": "http://patchwork.ozlabs.org/api/people/82/?format=api", "name": "Christoph Hellwig", "email": "hch@lst.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20170823115459.2058-1-hch@lst.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/804958/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/804958/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"MCsLAGKp\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xcm7v5T3gz9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 23 Aug 2017 21:55:07 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753846AbdHWLzH (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 23 Aug 2017 07:55:07 -0400", "from bombadil.infradead.org ([65.50.211.133]:58271 \"EHLO\n\tbombadil.infradead.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753768AbdHWLzG (ORCPT\n\t<rfc822; linux-pci@vger.kernel.org>); Wed, 23 Aug 2017 07:55:06 -0400", "from 80-109-164-210.cable.dynamic.surfer.at ([80.109.164.210]\n\thelo=localhost)\n\tby bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dkUFS-0001x3-96; Wed, 23 Aug 2017 11:55:02 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=bombadil.20170209;\n\th=Message-Id:Date:Subject:Cc:To:From:\n\tSender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:\n\tContent-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:\n\tResent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id:\n\tList-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=Dw29mQOlkQA2WBkTx8NM14PwQLmjkTNbUM/JnajGCHk=;\n\tb=MCsLAGKpjzdCClYPFp5D6yQwb\n\tdGihIkWk0HPGCowBJurckhsd/yP7AjL66eU5QqBTC89b4MHD1+/9qIYIXqoM3fOuYNr2RJ6BOWoUM\n\t79A1E9mwWGpdvvyEKS41DzsIi6Im0eZyTFm4fDi8h3NrcO5sf6kkN+0OCEmZcBK8ByygVhFYJRMGH\n\t0zWsqaw4oGAAT2lmscxc3AenYE1+6IEFAD8jTcINEXIrqr7AY7xpYQWd8ww+2pWewHcjpXSl1bKB4\n\tH26+MSPHJ3LKxGtj8jFJIuHbnBq86MvaunarTJeYPeRxoGyMtOpomqErtPJMzae3IVwdEpZn0xZ1c\n\tv6TTjRAmA==;", "From": "Christoph Hellwig <hch@lst.de>", "To": "helgaas@kernel.org", "Cc": "davem@davemloft.net, mroos@linux.ee, linux-pci@vger.kernel.org", "Subject": "[PATCH] PCI/msi: don't warn on irq_create_affinity_masks NULL return", "Date": "Wed, 23 Aug 2017 13:54:59 +0200", "Message-Id": "<20170823115459.2058-1-hch@lst.de>", "X-Mailer": "git-send-email 2.11.0", "X-SRS-Rewrite": "SMTP reverse-path rewritten from <hch@infradead.org> by\n\tbombadil.infradead.org. See http://www.infradead.org/rpr.html", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" }, "content": "irq_create_affinity_masks can easily return NULL when there are not\nenough \"free\" vectors available to spread, while the memory allocation\nfailure for the CPU masks not only is unlikely, but also relatively\nharmless as the system will work just fine except for non-optimally\nspread vectors. Thus remove the warnings.\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\n---\n drivers/pci/msi.c | 13 +++----------\n 1 file changed, 3 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c\nindex 253d92409bb3..2225afc1cbbb 100644\n--- a/drivers/pci/msi.c\n+++ b/drivers/pci/msi.c\n@@ -538,12 +538,9 @@ msi_setup_entry(struct pci_dev *dev, int nvec, const struct irq_affinity *affd)\n \tstruct msi_desc *entry;\n \tu16 control;\n \n-\tif (affd) {\n+\tif (affd)\n \t\tmasks = irq_create_affinity_masks(nvec, affd);\n-\t\tif (!masks)\n-\t\t\tdev_err(&dev->dev, \"can't allocate MSI affinity masks for %d vectors\\n\",\n-\t\t\t\tnvec);\n-\t}\n+\n \n \t/* MSI Entry Initialization */\n \tentry = alloc_msi_entry(&dev->dev, nvec, masks);\n@@ -679,12 +676,8 @@ static int msix_setup_entries(struct pci_dev *dev, void __iomem *base,\n \tstruct msi_desc *entry;\n \tint ret, i;\n \n-\tif (affd) {\n+\tif (affd)\n \t\tmasks = irq_create_affinity_masks(nvec, affd);\n-\t\tif (!masks)\n-\t\t\tdev_err(&dev->dev, \"can't allocate MSI-X affinity masks for %d vectors\\n\",\n-\t\t\t\tnvec);\n-\t}\n \n \tfor (i = 0, curmsk = masks; i < nvec; i++) {\n \t\tentry = alloc_msi_entry(&dev->dev, 1, curmsk);\n", "prefixes": [] }