Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/804853/?format=api
{ "id": 804853, "url": "http://patchwork.ozlabs.org/api/patches/804853/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/20170823072123.18769-7-stewart@linux.vnet.ibm.com/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170823072123.18769-7-stewart@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-08-23T07:21:16", "name": "[06/13] hdata: Reduce 'struct HDIF_array_hdr' alignment to 4 bytes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "59c8a2d5d6ad08b5265baa93c28234581476fa27", "submitter": { "id": 48041, "url": "http://patchwork.ozlabs.org/api/people/48041/?format=api", "name": "Stewart Smith", "email": "stewart@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/20170823072123.18769-7-stewart@linux.vnet.ibm.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/804853/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/804853/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xcf6j4Dbvz9sNd\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 23 Aug 2017 17:23:41 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xcf6j0XC1zDrKb\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 23 Aug 2017 17:23:41 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xcf4G3GT4zDqkc\n\tfor <skiboot@lists.ozlabs.org>; Wed, 23 Aug 2017 17:21:34 +1000 (AEST)", "from pps.filterd (m0098413.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7N7LDjn135542\n\tfor <skiboot@lists.ozlabs.org>; Wed, 23 Aug 2017 03:21:32 -0400", "from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2ch542gfp6-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Wed, 23 Aug 2017 03:21:31 -0400", "from localhost\n\tby e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <stewart@linux.vnet.ibm.com>;\n\tWed, 23 Aug 2017 01:21:31 -0600", "from b03cxnp07029.gho.boulder.ibm.com (9.17.130.16)\n\tby e32.co.us.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 23 Aug 2017 01:21:29 -0600", "from b03ledav006.gho.boulder.ibm.com\n\t(b03ledav006.gho.boulder.ibm.com [9.17.130.237])\n\tby b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7N7LSgC10092894; Wed, 23 Aug 2017 00:21:28 -0700", "from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id B4082C6037;\n\tWed, 23 Aug 2017 01:21:28 -0600 (MDT)", "from birb.localdomain (unknown [9.83.2.72])\n\tby b03ledav006.gho.boulder.ibm.com (Postfix) with SMTP id 17666C6042; \n\tWed, 23 Aug 2017 01:21:27 -0600 (MDT)", "by birb.localdomain (Postfix, from userid 1000)\n\tid 6E9C8332AFC; Wed, 23 Aug 2017 17:21:24 +1000 (AEST)" ], "From": "Stewart Smith <stewart@linux.vnet.ibm.com>", "To": "skiboot@lists.ozlabs.org", "Date": "Wed, 23 Aug 2017 17:21:16 +1000", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170823072123.18769-1-stewart@linux.vnet.ibm.com>", "References": "<20170823072123.18769-1-stewart@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17082307-0004-0000-0000-000012CFE588", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007595; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000223; SDB=6.00906370; UDB=6.00454276;\n\tIPR=6.00686571; \n\tBA=6.00005550; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016821;\n\tXFM=3.00000015; UTC=2017-08-23 07:21:29", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17082307-0005-0000-0000-000080D28799", "Message-Id": "<20170823072123.18769-7-stewart@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-23_02:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708230108", "Subject": "[Skiboot] [PATCH 06/13] hdata: Reduce 'struct HDIF_array_hdr'\n\talignment to 4 bytes", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "UBSan threw up the following:\nhdata/test/../hdif.c:96:9: runtime error: member access within misaligned address 0x7f9ad8b02c18 for type 'const struct HDIF_array_hdr', which requires 16 byte alignment\n0x7f9ad8b02c18: note: pointer points here\n 00 00 00 00 00 00 00 10 00 00 00 08 00 00 00 14 00 00 00 14 00 00 00 20 00 00 00 00 80 03 ff ff\n ^\n\nReal data we're parsing doesn't enforce that alignment requirement,\nso we shouldn't rely on it.\n\nSigned-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>\n---\n hdata/hdif.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/hdata/hdif.h b/hdata/hdif.h\nindex ef03522aca8b..22345b368eca 100644\n--- a/hdata/hdif.h\n+++ b/hdata/hdif.h\n@@ -44,7 +44,7 @@ struct HDIF_array_hdr {\n \t__be32\tecnt;\n \t__be32\tesize;\n \t__be32\teactsz;\n-} __packed __align(0x10);\n+} __packed __align(0x4);\n \n struct HDIF_child_ptr {\n \t__be32\toffset;\n", "prefixes": [ "06/13" ] }