Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/804624/?format=api
{ "id": 804624, "url": "http://patchwork.ozlabs.org/api/patches/804624/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170822105754.29486-11-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170822105754.29486-11-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-08-22T10:57:52", "name": "[next,S78-V8,10/12] i40e: fix handling of vf_states variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8a5d9c638b8f564de036dfba1af85f0059ecddfd", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170822105754.29486-11-alice.michael@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/804624/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/804624/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xcKgq2Q5Kz9t1m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 23 Aug 2017 05:02:47 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8396488E9A;\n\tTue, 22 Aug 2017 19:02:45 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SEOaKokIyqO3; Tue, 22 Aug 2017 19:02:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6C7F788C03;\n\tTue, 22 Aug 2017 19:02:44 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 93C071C078A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Aug 2017 19:02:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8C86D87E17\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Aug 2017 19:02:40 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VBXe3tS1alfx for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Aug 2017 19:02:39 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id BA8C587E05\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Aug 2017 19:02:39 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga105.fm.intel.com with ESMTP; 22 Aug 2017 12:02:39 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga005.jf.intel.com with ESMTP; 22 Aug 2017 12:02:38 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.41,413,1498546800\"; d=\"scan'208\";a=\"140827635\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Tue, 22 Aug 2017 06:57:52 -0400", "Message-Id": "<20170822105754.29486-11-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20170822105754.29486-1-alice.michael@intel.com>", "References": "<20170822105754.29486-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S78-V8 10/12] i40e: fix handling of\n\tvf_states variable", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alan Brady <alan.brady@intel.com>\n\nCurrently we inappropriately clear the vf_states variable with a null\nassignment. This is problematic because we should be using atomic\nbitops on this variable and we don't actually want to clear all the\nflags. We should just clear the ones we know we want to clear.\nAdditionally remove the I40E_VF_STATE_FCOEENA bit because it is no\nlonger being used.\n\nSigned-off-by: Alan Brady <alan.brady@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 5 ++++-\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h | 1 -\n 2 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 5b30192..e51fa2d 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -876,7 +876,8 @@ static void i40e_free_vf_res(struct i40e_vf *vf)\n \t}\n \t/* reset some of the state variables keeping track of the resources */\n \tvf->num_queue_pairs = 0;\n-\tvf->vf_states = 0;\n+\tclear_bit(I40E_VF_STATE_MC_PROMISC, &vf->vf_states);\n+\tclear_bit(I40E_VF_STATE_UC_PROMISC, &vf->vf_states);\n }\n \n /**\n@@ -1583,6 +1584,8 @@ static int i40e_vc_get_vf_resources_msg(struct i40e_vf *vf, u8 *msg)\n \t (vf->driver_caps & VIRTCHNL_VF_OFFLOAD_IWARP)) {\n \t\tvfres->vf_cap_flags |= VIRTCHNL_VF_OFFLOAD_IWARP;\n \t\tset_bit(I40E_VF_STATE_IWARPENA, &vf->vf_states);\n+\t} else {\n+\t\tclear_bit(I40E_VF_STATE_IWARPENA, &vf->vf_states);\n \t}\n \n \tif (vf->driver_caps & VIRTCHNL_VF_OFFLOAD_RSS_PF) {\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h\nindex 5ea42ad..5efc4f9 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h\n@@ -56,7 +56,6 @@ enum i40e_vf_states {\n \tI40E_VF_STATE_INIT = 0,\n \tI40E_VF_STATE_ACTIVE,\n \tI40E_VF_STATE_IWARPENA,\n-\tI40E_VF_STATE_FCOEENA,\n \tI40E_VF_STATE_DISABLED,\n \tI40E_VF_STATE_MC_PROMISC,\n \tI40E_VF_STATE_UC_PROMISC,\n", "prefixes": [ "next", "S78-V8", "10/12" ] }