Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/804247/?format=api
{ "id": 804247, "url": "http://patchwork.ozlabs.org/api/patches/804247/?format=api", "web_url": "http://patchwork.ozlabs.org/project/petitboot/patch/20170822040414.11485-1-sam@mendozajonas.com/", "project": { "id": 53, "url": "http://patchwork.ozlabs.org/api/projects/53/?format=api", "name": "Petitboot development", "link_name": "petitboot", "list_id": "petitboot.lists.ozlabs.org", "list_email": "petitboot@lists.ozlabs.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170822040414.11485-1-sam@mendozajonas.com>", "list_archive_url": null, "date": "2017-08-22T04:04:13", "name": "[1/2] discover/ipmi: Open devnode with O_CLOEXEC", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d0547acc8f8ccbe80b67557df112799c0a3c3daa", "submitter": { "id": 68013, "url": "http://patchwork.ozlabs.org/api/people/68013/?format=api", "name": "Sam Mendoza-Jonas", "email": "sam@mendozajonas.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/petitboot/patch/20170822040414.11485-1-sam@mendozajonas.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/804247/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/804247/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<petitboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "petitboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "petitboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xbxlW488Jz9t2S\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 22 Aug 2017 14:04:39 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xbxlV6KqDzDqh9\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 22 Aug 2017 14:04:38 +1000 (AEST)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xbxlM08WKzDqXp\n\tfor <petitboot@lists.ozlabs.org>;\n\tTue, 22 Aug 2017 14:04:30 +1000 (AEST)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n\tby mailout.nyi.internal (Postfix) with ESMTP id C7E7620D43;\n\tTue, 22 Aug 2017 00:04:27 -0400 (EDT)", "from frontend2 ([10.202.2.161])\n\tby compute2.internal (MEProxy); Tue, 22 Aug 2017 00:04:27 -0400", "from v4.ozlabs.ibm.com (unknown [122.99.82.10])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 9DB89249CD;\n\tTue, 22 Aug 2017 00:04:26 -0400 (EDT)" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=mendozajonas.com header.i=@mendozajonas.com\n\theader.b=\"JIrB2y/s\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"gUXRI8QQ\"; \n\tdkim-atps=neutral", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=mendozajonas.com header.i=@mendozajonas.com\n\theader.b=\"JIrB2y/s\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"gUXRI8QQ\"; \n\tdkim-atps=neutral", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=mendozajonas.com header.i=@mendozajonas.com\n\theader.b=\"JIrB2y/s\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"gUXRI8QQ\"; dkim-atps=neutral" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmendozajonas.com; h=cc:date:from:message-id:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=odau73\n\tK14YLVQGxneScd6LE57jR5QvKtx6xh4grWUI4=; b=JIrB2y/sbPbN6oqr6weIxQ\n\tf6yKA2iBPi3n9jsNkeDAwZcFj3hGY7A4HZPpLHwfCbtu9gsw8V6N811uJwsNNkmv\n\tXZepm1fYhWN/WEm0c47A6N46fHqJvrrvoqspVBKRkj+mWljKcOUcA2ODBa1pgliT\n\tcdrRW1wqF7dnC/mewjx6VM7bEsivLWhO+uCA2JBNXipUpMeUxjoH9Ds7H6BNQ8Us\n\tF24zrYGZ336TrOht16noDPVcXOGj4Cvr0fEWsr4viia3I+bHg+uMu2m9udhMlpXS\n\tHULZTNl/AstfuobGGO1JWmpbId2MrfBJRkq7rLDqjT6QdUuJRe92dv07WPazTFnQ\n\t==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:date:from:message-id:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=odau73\n\tK14YLVQGxneScd6LE57jR5QvKtx6xh4grWUI4=; b=gUXRI8QQzG//cuEU5eurIE\n\t0lNuX2tL6fgxoXRSiZ5O3bJMM4yOyMqGQCTG6wEFSBYsivFGzSlj270Nwl2+KiCY\n\tQ6LoyN4eNb3l21wCpoW4ZJIA/qfaNIRh/A0SpJjTOLAczi/WP7zV4/QKuGOFRcvj\n\tM7swcgIdWffcmpyBqne4VA1rP6vOcGyFb1If30wEdMd7lHXTEM5/JS5LM9hQgmz/\n\tiH6hyNHpqi6L0cKj7iKB4IeCkaYniWDwuJPuUXCxl+Gu2xkbCSeqIE4QIcgXuqpr\n\t/rpp8yrR/bvEETnNzXzYZ6cC6oM5aseKs3nQp1FV11HaQB9KHt8h3v9RUn+QJJ0g\n\t==" ], "X-ME-Sender": "<xms:S62bWSQvcA7joYT43EyRNWIrnSrCmGCk7WrnEJ5wcXX_K7F5VoAlag>", "X-Sasl-enc": "xy+3LOTslxYXT60t5LakOFyaV3BPPByzF0UJiBDL1dC2 1503374667", "From": "Samuel Mendoza-Jonas <sam@mendozajonas.com>", "To": "petitboot@lists.ozlabs.org", "Subject": "[PATCH 1/2] discover/ipmi: Open devnode with O_CLOEXEC", "Date": "Tue, 22 Aug 2017 14:04:13 +1000", "Message-Id": "<20170822040414.11485-1-sam@mendozajonas.com>", "X-Mailer": "git-send-email 2.14.0", "X-BeenThere": "petitboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Petitboot bootloader development <petitboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/petitboot>,\n\t<mailto:petitboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/petitboot/>", "List-Post": "<mailto:petitboot@lists.ozlabs.org>", "List-Help": "<mailto:petitboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/petitboot>,\n\t<mailto:petitboot-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Samuel Mendoza-Jonas <sam@mendozajonas.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "petitboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Petitboot\"\n\t<petitboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "The IPMI device node is kept open for the life of the platform - include\nthe O_CLOEXEC flag so it is not kept open for child processes.\n\nSigned-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>\n---\n discover/ipmi.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/discover/ipmi.c b/discover/ipmi.c\nindex 2aaf114..d652e9f 100644\n--- a/discover/ipmi.c\n+++ b/discover/ipmi.c\n@@ -201,7 +201,7 @@ struct ipmi *ipmi_open(void *ctx)\n \tstruct ipmi *ipmi;\n \tint fd;\n \n-\tfd = open(ipmi_devnode, O_RDWR);\n+\tfd = open(ipmi_devnode, O_RDWR | O_CLOEXEC);\n \tif (fd < 0) {\n \t\tpb_log(\"IPMI: can't open IPMI device %s: %m\\n\", ipmi_devnode);\n \t\treturn NULL;\n", "prefixes": [ "1/2" ] }