Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/803755/?format=api
{ "id": 803755, "url": "http://patchwork.ozlabs.org/api/patches/803755/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170820155312.831-1-christophe.jaillet@wanadoo.fr/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20170820155312.831-1-christophe.jaillet@wanadoo.fr>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20170820155312.831-1-christophe.jaillet@wanadoo.fr/", "date": "2017-08-20T15:53:12", "name": "[1/2] soc/fsl/qe: Fix a potential NULL pointer dereference in an error handling path", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "d8401c823debe8fcfe01646958090693dbaec708", "submitter": { "id": 66309, "url": "http://patchwork.ozlabs.org/api/people/66309/?format=api", "name": "Christophe JAILLET", "email": "christophe.jaillet@wanadoo.fr" }, "delegate": { "id": 1707, "url": "http://patchwork.ozlabs.org/api/users/1707/?format=api", "username": "scottwood", "first_name": "Scott", "last_name": "Wood", "email": "scottwood@freescale.com" }, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170820155312.831-1-christophe.jaillet@wanadoo.fr/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/803755/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/803755/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xb1bX6cr4z9sRg\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 21 Aug 2017 01:54:32 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xb1bX5klGzDrK5\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 21 Aug 2017 01:54:32 +1000 (AEST)", "from smtp.smtpout.orange.fr (smtp11.smtpout.orange.fr\n\t[80.12.242.133])\n\t(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xb1ZG52SgzDqb5\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tMon, 21 Aug 2017 01:53:25 +1000 (AEST)", "from localhost.localdomain ([90.21.44.83]) by mwinf5d46 with ME\n\tid zTtF1v0011ngAYy03TtFfQ; Sun, 20 Aug 2017 17:53:19 +0200" ], "X-ME-Helo": "localhost.localdomain", "X-ME-Auth": "Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI=", "X-ME-Date": "Sun, 20 Aug 2017 17:53:19 +0200", "X-ME-IP": "90.21.44.83", "From": "Christophe JAILLET <christophe.jaillet@wanadoo.fr>", "To": "qiang.zhao@nxp.com,\n\tleoyang.li@nxp.com", "Subject": "[PATCH 1/2] soc/fsl/qe: Fix a potential NULL pointer dereference in\n\tan error handling path", "Date": "Sun, 20 Aug 2017 17:53:12 +0200", "Message-Id": "<20170820155312.831-1-christophe.jaillet@wanadoo.fr>", "X-Mailer": "git-send-email 2.11.0", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org,\n\tChristophe JAILLET <christophe.jaillet@wanadoo.fr>,\n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "If 'of_find_device_by_node()' fails at line 153, a NULL pointer\ndereference (pdev) will occur in the error handling path.\n\nJust remove the 'devm_iounmap()' call from the error handling path. The\ncorresponding is managed, there is no need to release explicitly here.\n\nFixes: 35ef1c20fdb2 (\"fsl/qe: Add QE TDM lib\")\nSigned-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>\n---\nThis patch is only a guess that sounds logical to me.\n\nI propose to remove this 'devm_iounmap' mainly because of its name (if it\nis managed, why should be manually handle it here ?)\n---\n drivers/soc/fsl/qe/qe_tdm.c | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/drivers/soc/fsl/qe/qe_tdm.c b/drivers/soc/fsl/qe/qe_tdm.c\nindex f744c214f680..6b9647fee512 100644\n--- a/drivers/soc/fsl/qe/qe_tdm.c\n+++ b/drivers/soc/fsl/qe/qe_tdm.c\n@@ -174,7 +174,6 @@ int ucc_of_parse_tdm(struct device_node *np, struct ucc_tdm *utdm,\n \treturn ret;\n \n err_miss_siram_property:\n-\tdevm_iounmap(&pdev->dev, utdm->si_regs);\n \treturn ret;\n }\n EXPORT_SYMBOL(ucc_of_parse_tdm);\n", "prefixes": [ "1/2" ] }