Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/803555/?format=api
{ "id": 803555, "url": "http://patchwork.ozlabs.org/api/patches/803555/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/CADLLry4Cdbdy3+gOpHrDhqbHhUdhWgGgWLeN-1MnuurbhS=ZfA@mail.gmail.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<CADLLry4Cdbdy3+gOpHrDhqbHhUdhWgGgWLeN-1MnuurbhS=ZfA@mail.gmail.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/CADLLry4Cdbdy3+gOpHrDhqbHhUdhWgGgWLeN-1MnuurbhS=ZfA@mail.gmail.com/", "date": "2017-08-19T07:58:09", "name": "[5/5] Use __func__ instead of function name", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "13a0e37915c4bf3b135f0677f9a0c38c2f7937b4", "submitter": { "id": 72193, "url": "http://patchwork.ozlabs.org/api/people/72193/?format=api", "name": "Austin Kim", "email": "austindh.kim@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/CADLLry4Cdbdy3+gOpHrDhqbHhUdhWgGgWLeN-1MnuurbhS=ZfA@mail.gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/803555/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/803555/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xZHPy18ltz9sNV\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 19 Aug 2017 21:13:42 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xZHPx6xSxzDqr6\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 19 Aug 2017 21:13:41 +1000 (AEST)", "from mail-pf0-x242.google.com (mail-pf0-x242.google.com\n\t[IPv6:2607:f8b0:400e:c00::242])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xZC4N1zSxzDqlD\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSat, 19 Aug 2017 17:58:12 +1000 (AEST)", "by mail-pf0-x242.google.com with SMTP id j83so728431pfe.1\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSat, 19 Aug 2017 00:58:12 -0700 (PDT)", "by 10.100.180.80 with HTTP; Sat, 19 Aug 2017 00:58:09 -0700 (PDT)" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"PKZyTleV\"; dkim-atps=neutral", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"PKZyTleV\"; dkim-atps=neutral", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"PKZyTleV\"; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=drzwYXePmdeV9ubRsy7XEOEL5P6UiK1Upkt1fG5/iBU=;\n\tb=PKZyTleVvzhQIA8zJAGp8XZeGNsnOZqwQu9ZAOmQWlv2YfaAlkIiaVbs6gIOJWsd4C\n\tuOX0fveHWnrGns0OIeo9aYRNZGov+b8Ahtx8410+gcGzytrSB8AadVmCRCFmcJMkzstC\n\trQxNNkWuY5w4rMZaOCLI3wTsf/in0G3BvhLi6cSX9kUEncx3YBT/c9RIHJ/qCcD9PXch\n\tkAcG6hkosqnMLk7ueE1MEUUztM2iDydAVPo44vlMYzxelidaCPa7N7CI/aQc3O57UWLo\n\tQqQP5iKsNd1y7nJjlJ4xUjnAZx9ofyBq92PMyKC67BP5zWo/Si40q/DqfiD/9WviEgdl\n\tR0GQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=drzwYXePmdeV9ubRsy7XEOEL5P6UiK1Upkt1fG5/iBU=;\n\tb=teVIw5bXfMAxZ7OJG/8P1E4FScBKGCyJXVfzJYiGVOk9h50FAyX1mgypiiZPQ+7xi6\n\teCeon+zReSleueG39/9fXJ+id3/wiDXnQJuNwF0KUyo9NjZzEexqQqr+RqQEX79SM/XR\n\t/+E615cjA8xZYuXVqfNv4dpWlcvK86v7UlP/j6nPmVsWXI8/U2RXUb7BPAk8ZH5ZtvV/\n\tElmXyPnb+y+eN6W07y9J08w7n6zxvhP+7hMQ308qS9Hn2XB4YIXo+tvgXrmw1vMM5YS1\n\t8l2cqRlScyCr+OIWMOcSmaKOXZNfgVs76QUN48AutSKVLezGYpj1AXrniJoZl4msJnNH\n\t4c7w==", "X-Gm-Message-State": "AHYfb5hdCC5xtdTr4epQcYhi6bo3xLpqGZXoanGNxm2qUb0eof/FvkjG\n\thxj2i29bew12e/V20dDQSAWob53zWA==", "X-Received": "by 10.84.132.73 with SMTP id 67mr12384936ple.407.1503129490432; \n\tSat, 19 Aug 2017 00:58:10 -0700 (PDT)", "MIME-Version": "1.0", "In-Reply-To": "<20170729072433.13194-6-sz.lin@moxa.com>", "References": "<20170729072433.13194-1-sz.lin@moxa.com>\n\t<20170729072433.13194-6-sz.lin@moxa.com>", "From": "=?UTF-8?B?6rmA64+Z7ZiE?= <austindh.kim@gmail.com>", "Date": "Sat, 19 Aug 2017 16:58:09 +0900", "Message-ID": "<CADLLry4Cdbdy3+gOpHrDhqbHhUdhWgGgWLeN-1MnuurbhS=ZfA@mail.gmail.com>", "Subject": "Re: [PATCH 5/5] Use __func__ instead of function name", "To": "SZ Lin <sz.lin@moxa.com>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Mailman-Approved-At": "Sat, 19 Aug 2017 21:12:19 +1000", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "ashleydlai@gmail.com, linux-kernel@vger.kernel.org,\n\tjarkko.sakkinen@linux.intel.com, jgunthorpe@obsidianresearch.com,\n\ttpmdd-devel@lists.sourceforge.net, paulus@samba.org, peterhuewe@gmx.de,\n\tlinuxppc-dev@lists.ozlabs.org, tpmdd@selhorst.ne", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "I guess below code would be better idea to gather more debug information.\n memcpy((void *)ibmvtpm->rtce_buf, (void *)buf, count);\n crq.valid = (u8)IBMVTPM_VALID_CMD;\n@@ -150,8 +155,9 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip,\nu8 *buf, size_t count)\n\n rc = ibmvtpm_send_crq(ibmvtpm->vdev, be64_to_cpu(word[0]),\n be64_to_cpu(word[1]));\n+\n if (rc != H_SUCCESS) {\n- dev_err(ibmvtpm->dev, \"tpm_ibmvtpm_send failed rc=%d\\n\", rc);\n+ dev_err(ibmvtpm->dev, \"%s failed rc=%d at %d\n\\n\",__func__, rc, __LINE__);\n rc = 0;\n } else\n rc = count;\n\n2017-07-29 16:24 GMT+09:00 SZ Lin <sz.lin@moxa.com>:\n> Fix following checkpatch.pl warning:\n> WARNING: Prefer using '\"%s...\", __func__' to using\n> the function's name, in a string\n>\n> Signed-off-by: SZ Lin <sz.lin@moxa.com>\n> ---\n> drivers/char/tpm/tpm_ibmvtpm.c | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n>\n> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c\n> index e75a674b44ac..2d33acc43e25 100644\n> --- a/drivers/char/tpm/tpm_ibmvtpm.c\n> +++ b/drivers/char/tpm/tpm_ibmvtpm.c\n> @@ -151,7 +151,7 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip, u8 *buf, size_t count)\n> rc = ibmvtpm_send_crq(ibmvtpm->vdev, be64_to_cpu(word[0]),\n> be64_to_cpu(word[1]));\n> if (rc != H_SUCCESS) {\n> - dev_err(ibmvtpm->dev, \"tpm_ibmvtpm_send failed rc=%d\\n\", rc);\n> + dev_err(ibmvtpm->dev, \"%s failed rc=%d\\n\", __func__, rc);\n> rc = 0;\n> ibmvtpm->tpm_processing_cmd = false;\n> } else\n> @@ -193,7 +193,7 @@ static int ibmvtpm_crq_get_rtce_size(struct ibmvtpm_dev *ibmvtpm)\n> cpu_to_be64(buf[1]));\n> if (rc != H_SUCCESS)\n> dev_err(ibmvtpm->dev,\n> - \"ibmvtpm_crq_get_rtce_size failed rc=%d\\n\", rc);\n> + \"%s failed rc=%d\\n\", __func__, rc);\n>\n> return rc;\n> }\n> @@ -221,7 +221,7 @@ static int ibmvtpm_crq_get_version(struct ibmvtpm_dev *ibmvtpm)\n> cpu_to_be64(buf[1]));\n> if (rc != H_SUCCESS)\n> dev_err(ibmvtpm->dev,\n> - \"ibmvtpm_crq_get_version failed rc=%d\\n\", rc);\n> + \"%s failed rc=%d\\n\", __func__, rc);\n>\n> return rc;\n> }\n> @@ -241,7 +241,7 @@ static int ibmvtpm_crq_send_init_complete(struct ibmvtpm_dev *ibmvtpm)\n> rc = ibmvtpm_send_crq(ibmvtpm->vdev, INIT_CRQ_COMP_CMD, 0);\n> if (rc != H_SUCCESS)\n> dev_err(ibmvtpm->dev,\n> - \"ibmvtpm_crq_send_init_complete failed rc=%d\\n\", rc);\n> + \"%s rc=%d\\n\", __func__, rc);\n>\n> return rc;\n> }\n> @@ -261,7 +261,7 @@ static int ibmvtpm_crq_send_init(struct ibmvtpm_dev *ibmvtpm)\n> rc = ibmvtpm_send_crq(ibmvtpm->vdev, INIT_CRQ_CMD, 0);\n> if (rc != H_SUCCESS)\n> dev_err(ibmvtpm->dev,\n> - \"ibmvtpm_crq_send_init failed rc=%d\\n\", rc);\n> + \"%s failed rc=%d\\n\", __func__, rc);\n>\n> return rc;\n> }\n> @@ -351,7 +351,7 @@ static int tpm_ibmvtpm_suspend(struct device *dev)\n> cpu_to_be64(buf[1]));\n> if (rc != H_SUCCESS)\n> dev_err(ibmvtpm->dev,\n> - \"tpm_ibmvtpm_suspend failed rc=%d\\n\", rc);\n> + \"%s failed rc=%d\\n\", __func__, rc);\n>\n> return rc;\n> }\n> --\n> 2.13.3\n>", "diff": "diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c\nindex 643bba7..0aae785 100644\n--- a/drivers/char/tpm/tpm_ibmvtpm.c\n+++ b/drivers/char/tpm/tpm_ibmvtpm.c\n@@ -141,6 +141,11 @@ static int tpm_ibmvtpm_send(struct tpm_chip\n*chip, u8 *buf, size_t count)\n return -EIO;\n }\n\n+ if (!buf) {\n+ dev_err(ibmvtpm->dev, \"%s buf null at %d \\n\",__func__,\nrc, __LINE__);\n+ return 0;\n+ }\n+\n spin_lock(&ibmvtpm->rtce_lock);\n", "prefixes": [ "5/5" ] }