Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/803450/?format=api
{ "id": 803450, "url": "http://patchwork.ozlabs.org/api/patches/803450/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170818224802.6099.62913.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170818224802.6099.62913.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2017-08-18T22:48:02", "name": "ixgbe: add error checks when initializing the PHY", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1f211f302ea7cc9e55d92a4a7f5fe5d67f9b312a", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170818224802.6099.62913.stgit@localhost6.localdomain6/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/803450/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/803450/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xYysv2jKhz9s8P\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 19 Aug 2017 08:48:17 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 71F8088155;\n\tFri, 18 Aug 2017 22:48:15 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FguxRVbMySl4; Fri, 18 Aug 2017 22:48:11 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3C05C8813A;\n\tFri, 18 Aug 2017 22:48:11 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 80BA11C4116\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Aug 2017 22:48:09 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 779B12E42D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Aug 2017 22:48:09 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KDkZa6b7gt8G for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Aug 2017 22:48:08 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby silver.osuosl.org (Postfix) with ESMTPS id BB6B82D99B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Aug 2017 22:48:08 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Aug 2017 15:48:08 -0700", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.177.78])\n\tby fmsmga001.fm.intel.com with ESMTP; 18 Aug 2017 15:48:08 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.41,393,1498546800\"; d=\"scan'208\";\n\ta=\"1184426643\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 18 Aug 2017 15:48:02 -0700", "Message-ID": "<20170818224802.6099.62913.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: add error checks when initializing\n\tthe PHY", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Ignoring errors when attempting to identify the PHY can lead to a crash.\nSpecifically in the case of FW controlled PHYs where the PHY read/write\noperations are set to NULL.\n\nRemoved redundant comment.\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex 11c0378..1974f8f 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -3292,6 +3292,9 @@ static s32 ixgbe_init_phy_ops_X550em(struct ixgbe_hw *hw)\n \n \t/* Identify the PHY or SFP module */\n \tret_val = phy->ops.identify(hw);\n+\tif (ret_val == IXGBE_ERR_SFP_NOT_SUPPORTED ||\n+\t ret_val == IXGBE_ERR_PHY_ADDR_INVALID)\n+\t\treturn ret_val;\n \n \t/* Setup function pointers based on detected hardware */\n \tixgbe_init_mac_link_ops_X550em(hw);\n@@ -3494,9 +3497,10 @@ static s32 ixgbe_reset_hw_X550em(struct ixgbe_hw *hw)\n \tixgbe_clear_tx_pending(hw);\n \n \t/* PHY ops must be identified and initialized prior to reset */\n-\n-\t/* Identify PHY and related function pointers */\n \tstatus = hw->phy.ops.init(hw);\n+\tif (status == IXGBE_ERR_SFP_NOT_SUPPORTED ||\n+\t status == IXGBE_ERR_PHY_ADDR_INVALID)\n+\t\treturn status;\n \n \t/* start the external PHY */\n \tif (hw->phy.type == ixgbe_phy_x550em_ext_t) {\n", "prefixes": [] }