Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/803392/?format=api
{ "id": 803392, "url": "http://patchwork.ozlabs.org/api/patches/803392/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1503037265-11144-3-git-send-email-dingtianhong@huawei.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503037265-11144-3-git-send-email-dingtianhong@huawei.com>", "list_archive_url": null, "date": "2017-08-18T06:21:05", "name": "[v3,net,2/2] net: ixgbe: Use new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1077ebf063b817d9cf7a98fecd4e63a3ade8de72", "submitter": { "id": 24129, "url": "http://patchwork.ozlabs.org/api/people/24129/?format=api", "name": "Ding Tianhong", "email": "dingtianhong@huawei.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1503037265-11144-3-git-send-email-dingtianhong@huawei.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/803392/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/803392/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xYvDH5CCsz9t3C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 19 Aug 2017 06:03:59 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id AC73430CE3;\n\tFri, 18 Aug 2017 20:03:57 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zwJ8NIovF1-X; Fri, 18 Aug 2017 20:03:55 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 169CB30314;\n\tFri, 18 Aug 2017 20:03:55 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id D840C1C4120\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Aug 2017 06:21:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D06A78A2DF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Aug 2017 06:21:29 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wRNFNZGXjIgQ for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Aug 2017 06:21:28 +0000 (UTC)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id F335A8A2DB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Aug 2017 06:21:27 +0000 (UTC)", "from 172.30.72.60 (EHLO DGGEMS413-HUB.china.huawei.com)\n\t([172.30.72.60])\n\tby dggrg05-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id DFM12718; Fri, 18 Aug 2017 14:21:23 +0800 (CST)", "from localhost (10.177.23.32) by DGGEMS413-HUB.china.huawei.com\n\t(10.3.19.213) with Microsoft SMTP Server id 14.3.301.0;\n\tFri, 18 Aug 2017 14:21:12 +0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Ding Tianhong <dingtianhong@huawei.com>", "To": "<davem@davemloft.net>, <jeffrey.t.kirsher@intel.com>,\n\t<keescook@chromium.org>, <linux-kernel@vger.kernel.org>,\n\t<sparclinux@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,\n\t<alexander.duyck@gmail.com>, <netdev@vger.kernel.org>,\n\t<linuxarm@huawei.com>", "Date": "Fri, 18 Aug 2017 14:21:05 +0800", "Message-ID": "<1503037265-11144-3-git-send-email-dingtianhong@huawei.com>", "X-Mailer": "git-send-email 1.8.5.2.msysgit.0", "In-Reply-To": "<1503037265-11144-1-git-send-email-dingtianhong@huawei.com>", "References": "<1503037265-11144-1-git-send-email-dingtianhong@huawei.com>", "MIME-Version": "1.0", "X-Originating-IP": "[10.177.23.32]", "X-CFilter-Loop": "Reflected", "X-Mirapoint-Virus-RAPID-Raw": "score=unknown(0),\n\trefid=str=0001.0A020203.59968763.00D7, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32", "X-Mirapoint-Loop-Id": "5a3097fc7cc18c79f2dffba5c9431f73", "X-Mailman-Approved-At": "Fri, 18 Aug 2017 20:03:52 +0000", "Cc": "Ding Tianhong <dingtianhong@huawei.com>", "Subject": "[Intel-wired-lan] [PATCH v3 net 2/2] net: ixgbe: Use new\n\tPCI_DEV_FLAGS_NO_RELAXED_ORDERING flag", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The ixgbe driver use the compile check to determine if it can\nsend TLPs to Root Port with the Relaxed Ordering Attribute set,\nthis is too inconvenient, now the new flag PCI_DEV_FLAGS_NO_RELAXED_ORDERING\nhas been added to the kernel and we could check the bit4 in the PCIe\nDevice Control register to determine whether we should use the Relaxed\nOrdering Attributes or not, so use this new way in the ixgbe driver.\n\nSigned-off-by: Ding Tianhong <dingtianhong@huawei.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c | 22 ----------------------\n drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 19 -------------------\n 2 files changed, 41 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c\nindex 523f9d0..8a32eb7 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c\n@@ -175,31 +175,9 @@ static s32 ixgbe_init_phy_ops_82598(struct ixgbe_hw *hw)\n **/\n static s32 ixgbe_start_hw_82598(struct ixgbe_hw *hw)\n {\n-#ifndef CONFIG_SPARC\n-\tu32 regval;\n-\tu32 i;\n-#endif\n \ts32 ret_val;\n \n \tret_val = ixgbe_start_hw_generic(hw);\n-\n-#ifndef CONFIG_SPARC\n-\t/* Disable relaxed ordering */\n-\tfor (i = 0; ((i < hw->mac.max_tx_queues) &&\n-\t (i < IXGBE_DCA_MAX_QUEUES_82598)); i++) {\n-\t\tregval = IXGBE_READ_REG(hw, IXGBE_DCA_TXCTRL(i));\n-\t\tregval &= ~IXGBE_DCA_TXCTRL_DESC_WRO_EN;\n-\t\tIXGBE_WRITE_REG(hw, IXGBE_DCA_TXCTRL(i), regval);\n-\t}\n-\n-\tfor (i = 0; ((i < hw->mac.max_rx_queues) &&\n-\t (i < IXGBE_DCA_MAX_QUEUES_82598)); i++) {\n-\t\tregval = IXGBE_READ_REG(hw, IXGBE_DCA_RXCTRL(i));\n-\t\tregval &= ~(IXGBE_DCA_RXCTRL_DATA_WRO_EN |\n-\t\t\t IXGBE_DCA_RXCTRL_HEAD_WRO_EN);\n-\t\tIXGBE_WRITE_REG(hw, IXGBE_DCA_RXCTRL(i), regval);\n-\t}\n-#endif\n \tif (ret_val)\n \t\treturn ret_val;\n \ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\nindex d4933d2..96c324f 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n@@ -350,25 +350,6 @@ s32 ixgbe_start_hw_gen2(struct ixgbe_hw *hw)\n \t}\n \tIXGBE_WRITE_FLUSH(hw);\n \n-#ifndef CONFIG_SPARC\n-\t/* Disable relaxed ordering */\n-\tfor (i = 0; i < hw->mac.max_tx_queues; i++) {\n-\t\tu32 regval;\n-\n-\t\tregval = IXGBE_READ_REG(hw, IXGBE_DCA_TXCTRL_82599(i));\n-\t\tregval &= ~IXGBE_DCA_TXCTRL_DESC_WRO_EN;\n-\t\tIXGBE_WRITE_REG(hw, IXGBE_DCA_TXCTRL_82599(i), regval);\n-\t}\n-\n-\tfor (i = 0; i < hw->mac.max_rx_queues; i++) {\n-\t\tu32 regval;\n-\n-\t\tregval = IXGBE_READ_REG(hw, IXGBE_DCA_RXCTRL(i));\n-\t\tregval &= ~(IXGBE_DCA_RXCTRL_DATA_WRO_EN |\n-\t\t\t IXGBE_DCA_RXCTRL_HEAD_WRO_EN);\n-\t\tIXGBE_WRITE_REG(hw, IXGBE_DCA_RXCTRL(i), regval);\n-\t}\n-#endif\n \treturn 0;\n }\n \n", "prefixes": [ "v3", "net", "2/2" ] }