Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/803027/?format=api
{ "id": 803027, "url": "http://patchwork.ozlabs.org/api/patches/803027/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/1503029477-31179-1-git-send-email-alistair@popple.id.au/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503029477-31179-1-git-send-email-alistair@popple.id.au>", "list_archive_url": null, "date": "2017-08-18T04:11:17", "name": "hw/npu2-hw-procedures.c: Update PHY_RESET procedure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e5cbab8dc2aa096cac0a14cfa04d5f99547c3986", "submitter": { "id": 24781, "url": "http://patchwork.ozlabs.org/api/people/24781/?format=api", "name": "Alistair Popple", "email": "alistair@popple.id.au" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/1503029477-31179-1-git-send-email-alistair@popple.id.au/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/803027/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/803027/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xYV5J0TCCz9sN5\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 18 Aug 2017 14:11:32 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xYV5H5s48zDrKh\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 18 Aug 2017 14:11:31 +1000 (AEST)", "from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xYV555wgkzDrDf\n\tfor <skiboot@lists.ozlabs.org>; Fri, 18 Aug 2017 14:11:21 +1000 (AEST)", "from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3xYV554jKjz9sN5;\n\tFri, 18 Aug 2017 14:11:21 +1000 (AEST)" ], "From": "Alistair Popple <alistair@popple.id.au>", "To": "skiboot@lists.ozlabs.org", "Date": "Fri, 18 Aug 2017 14:11:17 +1000", "Message-Id": "<1503029477-31179-1-git-send-email-alistair@popple.id.au>", "X-Mailer": "git-send-email 2.1.4", "Subject": "[Skiboot] [PATCH] hw/npu2-hw-procedures.c: Update PHY_RESET\n\tprocedure", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Alistair Popple <alistair@popple.id.au>, arbab@linux.vnet.ibm.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "Newer versions of Hostboot will have various clocks powered down by default\nto save power. Therefore we need to power them up before accessing the OBUS\nPHY.\n\nSigned-off-by: Alistair Popple <alistair@popple.id.au>\n---\n\nStewart,\n\nReza wants to test this before we merge it so best to wait for his\nreviewed/tested-by first. Thanks!\n\n- Alistair\n\nhw/npu2-hw-procedures.c | 11 +++++++++++\n 1 file changed, 11 insertions(+)", "diff": "diff --git a/hw/npu2-hw-procedures.c b/hw/npu2-hw-procedures.c\nindex de70009..c9e7673 100644\n--- a/hw/npu2-hw-procedures.c\n+++ b/hw/npu2-hw-procedures.c\n@@ -87,6 +87,11 @@ struct npu2_phy_reg NPU2_PHY_RX_HIST_MIN_EYE_WIDTH\t= {0x24e, 54, 8};\n struct npu2_phy_reg NPU2_PHY_RX_HIST_MIN_EYE_WIDTH_LANE\t= {0x24e, 49, 5};\n struct npu2_phy_reg NPU2_PHY_RX_HIST_MIN_EYE_WIDTH_VALID= {0x24e, 48, 1};\n \n+struct npu2_phy_reg NPU2_PHY_RX_CLKDIST_PDWN\t\t= {0x204, 48, 3};\n+struct npu2_phy_reg NPU2_PHY_RX_IREF_PDWN\t\t= {0x230, 54, 1};\n+struct npu2_phy_reg NPU2_PHY_TX_CLKDIST_PDWN\t\t= {0x305, 48, 3};\n+struct npu2_phy_reg NPU2_PHY_RX_CTL_DATASM_CLKDIST_PDWN = {0x2e0, 60, 1};\n+\n #define NPU2_PHY_REG(scom_base, reg, lane)\t\t\t\t\t\\\n \tSETFIELD(PPC_BITMASK(27, 31), ((reg)->offset << 42) | scom_base, lane)\n \n@@ -252,6 +257,12 @@ static uint32_t phy_reset(struct npu2_dev *ndev)\n {\n \tint lane;\n \n+\t/* Power on clocks */\n+\tphy_write(ndev, &NPU2_PHY_RX_CLKDIST_PDWN, 0);\n+\tphy_write(ndev, &NPU2_PHY_RX_IREF_PDWN, 1);\n+\tphy_write(ndev, &NPU2_PHY_TX_CLKDIST_PDWN, 0);\n+\tphy_write(ndev, &NPU2_PHY_RX_CTL_DATASM_CLKDIST_PDWN, 0);\n+\n \tFOR_EACH_LANE(ndev, lane)\n \t\tphy_write_lane(ndev, &NPU2_PHY_RX_RUN_LANE, lane, 0);\n \n", "prefixes": [] }