Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/802472/?format=api
{ "id": 802472, "url": "http://patchwork.ozlabs.org/api/patches/802472/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/150296405502.16167.9720405534691757130.stgit@anamdev.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<150296405502.16167.9720405534691757130.stgit@anamdev.jf.intel.com>", "list_archive_url": null, "date": "2017-08-17T10:00:55", "name": "[v2,2/6,net-next] net: i40e: Add macro for PF reset bit", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "04b2dd1f3ad03b75ebcf7010ab6ffd28c1058b21", "submitter": { "id": 68504, "url": "http://patchwork.ozlabs.org/api/people/68504/?format=api", "name": "Nambiar, Amritha", "email": "amritha.nambiar@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/150296405502.16167.9720405534691757130.stgit@anamdev.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/802472/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/802472/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xY1vz3YHgz9sRV\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 17 Aug 2017 20:01:51 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C1A8388F3F;\n\tThu, 17 Aug 2017 10:01:49 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VyMu8h-C-Yva; Thu, 17 Aug 2017 10:01:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A709288F3C;\n\tThu, 17 Aug 2017 10:01:48 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id A34611C072D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 17 Aug 2017 10:01:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 9CFF730B10\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 17 Aug 2017 10:01:47 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jZ7x5rArBZAI for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 17 Aug 2017 10:01:46 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTPS id A30E430B11\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 17 Aug 2017 10:01:46 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Aug 2017 03:01:45 -0700", "from anamdev.jf.intel.com ([10.166.29.110])\n\tby orsmga002.jf.intel.com with ESMTP; 17 Aug 2017 03:01:45 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.41,387,1498546800\"; d=\"scan'208\";a=\"124679301\"", "From": "Amritha Nambiar <amritha.nambiar@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Thu, 17 Aug 2017 03:00:55 -0700", "Message-ID": "<150296405502.16167.9720405534691757130.stgit@anamdev.jf.intel.com>", "In-Reply-To": "<150296373549.16167.14331445560838257351.stgit@anamdev.jf.intel.com>", "References": "<150296373549.16167.14331445560838257351.stgit@anamdev.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH v2 2/6] [net-next]net: i40e: Add macro for\n\tPF reset bit", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Introduce a macro for the bit setting the PF reset flag and\nupdate its usages. This makes it easier to use this flag\nin functions to be introduced in future without encountering\ncheckpatch issues related to alignment and line over 80\ncharacters.\n\nSigned-off-by: Amritha Nambiar <amritha.nambiar@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e.h | 2 ++\n drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 3 +--\n drivers/net/ethernet/intel/i40e/i40e_main.c | 9 ++++-----\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 5 ++---\n 4 files changed, 9 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex 890508f..0e53838 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -157,6 +157,8 @@ enum i40e_state_t {\n \t__I40E_STATE_SIZE__,\n };\n \n+#define I40E_PF_RESET_FLAG\tBIT_ULL(__I40E_PF_RESET_REQUESTED)\n+\n /* VSI state flags */\n enum i40e_vsi_state_t {\n \t__I40E_VSI_DOWN,\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\nindex 8f326f8..b46117e 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n@@ -798,8 +798,7 @@ static ssize_t i40e_dbg_command_write(struct file *filp,\n \t\t */\n \t\tif (!(pf->flags & I40E_FLAG_VEB_MODE_ENABLED)) {\n \t\t\tpf->flags |= I40E_FLAG_VEB_MODE_ENABLED;\n-\t\t\ti40e_do_reset_safe(pf,\n-\t\t\t\t\t BIT_ULL(__I40E_PF_RESET_REQUESTED));\n+\t\t\ti40e_do_reset_safe(pf, I40E_PF_RESET_FLAG);\n \t\t}\n \n \t\tvsi = i40e_vsi_setup(pf, I40E_VSI_VMDQ2, vsi_seid, 0);\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex d2ca98f..9392c5a 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -5753,7 +5753,7 @@ int i40e_vsi_open(struct i40e_vsi *vsi)\n err_setup_tx:\n \ti40e_vsi_free_tx_resources(vsi);\n \tif (vsi == pf->vsi[pf->lan_vsi])\n-\t\ti40e_do_reset(pf, BIT_ULL(__I40E_PF_RESET_REQUESTED), true);\n+\t\ti40e_do_reset(pf, I40E_PF_RESET_FLAG, true);\n \n \treturn err;\n }\n@@ -5881,7 +5881,7 @@ void i40e_do_reset(struct i40e_pf *pf, u32 reset_flags, bool lock_acquired)\n \t\twr32(&pf->hw, I40E_GLGEN_RTRIG, val);\n \t\ti40e_flush(&pf->hw);\n \n-\t} else if (reset_flags & BIT_ULL(__I40E_PF_RESET_REQUESTED)) {\n+\t} else if (reset_flags & I40E_PF_RESET_FLAG) {\n \n \t\t/* Request a PF Reset\n \t\t *\n@@ -9209,7 +9209,7 @@ static int i40e_set_features(struct net_device *netdev,\n \tneed_reset = i40e_set_ntuple(pf, features);\n \n \tif (need_reset)\n-\t\ti40e_do_reset(pf, BIT_ULL(__I40E_PF_RESET_REQUESTED), true);\n+\t\ti40e_do_reset(pf, I40E_PF_RESET_FLAG, true);\n \n \treturn 0;\n }\n@@ -9461,8 +9461,7 @@ static int i40e_ndo_bridge_setlink(struct net_device *dev,\n \t\t\t\tpf->flags |= I40E_FLAG_VEB_MODE_ENABLED;\n \t\t\telse\n \t\t\t\tpf->flags &= ~I40E_FLAG_VEB_MODE_ENABLED;\n-\t\t\ti40e_do_reset(pf, BIT_ULL(__I40E_PF_RESET_REQUESTED),\n-\t\t\t\t true);\n+\t\t\ti40e_do_reset(pf, I40E_PF_RESET_FLAG, true);\n \t\t\tbreak;\n \t\t}\n \t}\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex e156096..92fe06d 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1400,8 +1400,7 @@ int i40e_pci_sriov_configure(struct pci_dev *pdev, int num_vfs)\n \tif (num_vfs) {\n \t\tif (!(pf->flags & I40E_FLAG_VEB_MODE_ENABLED)) {\n \t\t\tpf->flags |= I40E_FLAG_VEB_MODE_ENABLED;\n-\t\t\ti40e_do_reset_safe(pf,\n-\t\t\t\t\t BIT_ULL(__I40E_PF_RESET_REQUESTED));\n+\t\t\ti40e_do_reset_safe(pf, I40E_PF_RESET_FLAG);\n \t\t}\n \t\treturn i40e_pci_sriov_enable(pdev, num_vfs);\n \t}\n@@ -1409,7 +1408,7 @@ int i40e_pci_sriov_configure(struct pci_dev *pdev, int num_vfs)\n \tif (!pci_vfs_assigned(pf->pdev)) {\n \t\ti40e_free_vfs(pf);\n \t\tpf->flags &= ~I40E_FLAG_VEB_MODE_ENABLED;\n-\t\ti40e_do_reset_safe(pf, BIT_ULL(__I40E_PF_RESET_REQUESTED));\n+\t\ti40e_do_reset_safe(pf, I40E_PF_RESET_FLAG);\n \t} else {\n \t\tdev_warn(&pdev->dev, \"Unable to free VFs because some are assigned to VMs.\\n\");\n \t\treturn -EINVAL;\n", "prefixes": [ "v2", "2/6", "net-next" ] }