Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/801656/?format=api
{ "id": 801656, "url": "http://patchwork.ozlabs.org/api/patches/801656/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1502812794-452204-1-git-send-email-shannon.nelson@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1502812794-452204-1-git-send-email-shannon.nelson@oracle.com>", "list_archive_url": null, "date": "2017-08-15T15:59:54", "name": "[net-next] ixgbe: restore normal RSS after last macvlan offload is removed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b8b557cee10ac49488b82e3dc3641342a8c20f8e", "submitter": { "id": 70766, "url": "http://patchwork.ozlabs.org/api/people/70766/?format=api", "name": "Shannon Nelson", "email": "shannon.nelson@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1502812794-452204-1-git-send-email-shannon.nelson@oracle.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/801656/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/801656/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xWxwq5S5yz9t2y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 16 Aug 2017 01:58:51 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A11F486C77;\n\tTue, 15 Aug 2017 15:58:49 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CJ8kctK8BQVR; Tue, 15 Aug 2017 15:58:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D349186739;\n\tTue, 15 Aug 2017 15:58:48 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 16B4D1C411F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 15 Aug 2017 15:58:48 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 018D086739\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 15 Aug 2017 15:58:48 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JkIYIxg-Yl2J for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 15 Aug 2017 15:58:47 +0000 (UTC)", "from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 4DB3086688\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 15 Aug 2017 15:58:47 +0000 (UTC)", "from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id v7FFwgp8001205\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 15 Aug 2017 15:58:42 GMT", "from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72])\n\tby userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v7FFwgZP030430\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 15 Aug 2017 15:58:42 GMT", "from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18])\n\tby userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tv7FFwg3h029133; Tue, 15 Aug 2017 15:58:42 GMT", "from sln75.us.oracle.com (/10.147.27.211)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Tue, 15 Aug 2017 08:58:41 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Shannon Nelson <shannon.nelson@oracle.com>", "To": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "Date": "Tue, 15 Aug 2017 08:59:54 -0700", "Message-Id": "<1502812794-452204-1-git-send-email-shannon.nelson@oracle.com>", "X-Mailer": "git-send-email 1.7.1", "X-Source-IP": "userv0022.oracle.com [156.151.31.74]", "Cc": "davem@davemloft.net", "Subject": "[Intel-wired-lan] [PATCH net-next] ixgbe: restore normal RSS after\n\tlast macvlan offload is removed", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Just like when the last VF is removed, we need to restore normal\noperations after the last macvlan offload is removed, else we\nget stuck in single queue operations.\n\nTo test:\nethtool -l eth1 # note the number of queues in use, ~= cpus\n\nethtool -K eth1 l2-fwd-offload on\nip link add mv1 link eth1 type macvlan mode bridge\nip link set dev mv1 up\nip link del mv1\n\nethtool -l eth1 # are we back to the same # of queues, or stuck on 1?\n\nSigned-off-by: Shannon Nelson <shannon.nelson@oracle.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 11 +++++++++++\n 1 files changed, 11 insertions(+), 0 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 0f867dc..cedaf1c 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -9728,6 +9728,17 @@ static void ixgbe_fwd_del(struct net_device *pdev, void *priv)\n \tlimit = find_last_bit(&adapter->fwd_bitmask, 32);\n \tadapter->ring_feature[RING_F_VMDQ].limit = limit + 1;\n \tixgbe_fwd_ring_down(fwd_adapter->netdev, fwd_adapter);\n+\n+\t/* go back to full RSS if we're done with our VMQs */\n+\tif (adapter->ring_feature[RING_F_VMDQ].limit == 1) {\n+\t\tint rss = min_t(int, ixgbe_max_rss_indices(adapter),\n+\t\t\t\tnum_online_cpus());\n+\n+\t\tadapter->flags &= ~IXGBE_FLAG_VMDQ_ENABLED;\n+\t\tadapter->flags &= ~IXGBE_FLAG_SRIOV_ENABLED;\n+\t\tadapter->ring_feature[RING_F_RSS].limit = rss;\n+\t}\n+\n \tixgbe_setup_tc(pdev, netdev_get_num_tc(pdev));\n \tnetdev_dbg(pdev, \"pool %i:%i queues %i:%i VSI bitmask %lx\\n\",\n \t\t fwd_adapter->pool, adapter->num_rx_pools,\n", "prefixes": [ "net-next" ] }