Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/800713/?format=api
{ "id": 800713, "url": "http://patchwork.ozlabs.org/api/patches/800713/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170811181458.30776-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170811181458.30776-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2017-08-11T18:14:58", "name": "fm10k: fix mis-ordered parameters in declaration for .ndo_set_vf_bw", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fa4392e998cd240ab71f09aa865941deca78edf7", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170811181458.30776-1-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/800713/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/800713/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xTY7x2RqCz9sRg\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 12 Aug 2017 04:15:08 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6E6968802B;\n\tFri, 11 Aug 2017 18:15:07 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zqyFE51wrhFW; Fri, 11 Aug 2017 18:15:05 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 82B8288025;\n\tFri, 11 Aug 2017 18:15:05 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 446B21C0521\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Aug 2017 18:15:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 3AA8530AB2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Aug 2017 18:15:02 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id BojkbQCoJyxB for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Aug 2017 18:15:01 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby silver.osuosl.org (Postfix) with ESMTPS id B0C5D30A8E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Aug 2017 18:15:01 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Aug 2017 11:15:01 -0700", "from jekeller-desk.amr.corp.intel.com ([134.134.177.230])\n\tby fmsmga006.fm.intel.com with ESMTP; 11 Aug 2017 11:15:00 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.41,358,1498546800\"; d=\"scan'208\";a=\"139267059\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Fri, 11 Aug 2017 11:14:58 -0700", "Message-Id": "<20170811181458.30776-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.14.0.rc1.251.g593d8d6362ce", "Subject": "[Intel-wired-lan] [PATCH] fm10k: fix mis-ordered parameters in\n\tdeclaration for .ndo_set_vf_bw", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "We've had support for setting both a minimum and maximum bandwidth via\n.ndo_set_vf_bw since commit 883a9ccbae56 (\"fm10k: Add support for SR-IOV\nto driver\", 2014-09-20).\n\nLikely because we do not support minimum rates, the declaration\nmis-ordered the \"unused\" parameter, which causes warnings when analyzed\nwith cppcheck.\n\nFix this warning by properly declaring the min_rate and max_rate\nvariables in the declaration and definition (rather than using\n\"unused\"). Also rename \"rate\" to max_rate so as to clarify that we only\nsupport setting the maximum rate.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k.h | 4 ++--\n drivers/net/ethernet/intel/fm10k/fm10k_iov.c | 9 +++++----\n 2 files changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k.h b/drivers/net/ethernet/intel/fm10k/fm10k.h\nindex 40856bc0f3b9..46973fb234c5 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k.h\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k.h\n@@ -562,8 +562,8 @@ s32 fm10k_iov_update_pvid(struct fm10k_intfc *interface, u16 glort, u16 pvid);\n int fm10k_ndo_set_vf_mac(struct net_device *netdev, int vf_idx, u8 *mac);\n int fm10k_ndo_set_vf_vlan(struct net_device *netdev,\n \t\t\t int vf_idx, u16 vid, u8 qos, __be16 vlan_proto);\n-int fm10k_ndo_set_vf_bw(struct net_device *netdev, int vf_idx, int rate,\n-\t\t\tint unused);\n+int fm10k_ndo_set_vf_bw(struct net_device *netdev, int vf_idx,\n+\t\t\tint __always_unused min_rate, int max_rate);\n int fm10k_ndo_get_vf_config(struct net_device *netdev,\n \t\t\t int vf_idx, struct ifla_vf_info *ivi);\n \ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_iov.c b/drivers/net/ethernet/intel/fm10k/fm10k_iov.c\nindex 7e53521667b8..dafcf8f96b44 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_iov.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_iov.c\n@@ -613,7 +613,7 @@ int fm10k_ndo_set_vf_vlan(struct net_device *netdev, int vf_idx, u16 vid,\n }\n \n int fm10k_ndo_set_vf_bw(struct net_device *netdev, int vf_idx,\n-\t\t\tint __always_unused unused, int rate)\n+\t\t\tint __always_unused min_rate, int max_rate)\n {\n \tstruct fm10k_intfc *interface = netdev_priv(netdev);\n \tstruct fm10k_iov_data *iov_data = interface->iov_data;\n@@ -624,14 +624,15 @@ int fm10k_ndo_set_vf_bw(struct net_device *netdev, int vf_idx,\n \t\treturn -EINVAL;\n \n \t/* rate limit cannot be less than 10Mbs or greater than link speed */\n-\tif (rate && ((rate < FM10K_VF_TC_MIN) || rate > FM10K_VF_TC_MAX))\n+\tif (max_rate &&\n+\t ((max_rate < FM10K_VF_TC_MIN) || max_rate > FM10K_VF_TC_MAX))\n \t\treturn -EINVAL;\n \n \t/* store values */\n-\tiov_data->vf_info[vf_idx].rate = rate;\n+\tiov_data->vf_info[vf_idx].rate = max_rate;\n \n \t/* update hardware configuration */\n-\thw->iov.ops.configure_tc(hw, vf_idx, rate);\n+\thw->iov.ops.configure_tc(hw, vf_idx, max_rate);\n \n \treturn 0;\n }\n", "prefixes": [] }