Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/800712/?format=api
{ "id": 800712, "url": "http://patchwork.ozlabs.org/api/patches/800712/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170811181437.30509-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170811181437.30509-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2017-08-11T18:14:37", "name": "fm10k: prefer %s and __func__ for diagnostic prints", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "03e9f1f9847dc9b0c3aea2e4e51c702727a4e9ab", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170811181437.30509-1-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/800712/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/800712/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xTY7V1QJKz9sRg\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 12 Aug 2017 04:14:46 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A176188FDD;\n\tFri, 11 Aug 2017 18:14:44 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8fwaJLY4-Fam; Fri, 11 Aug 2017 18:14:43 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D434088FAF;\n\tFri, 11 Aug 2017 18:14:43 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2016A1C0521\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Aug 2017 18:14:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 17DD230AB2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Aug 2017 18:14:43 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WH+upEk+I2Rd for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Aug 2017 18:14:42 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 432D230A8E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Aug 2017 18:14:42 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Aug 2017 11:14:39 -0700", "from jekeller-desk.amr.corp.intel.com ([134.134.177.230])\n\tby fmsmga005.fm.intel.com with ESMTP; 11 Aug 2017 11:14:39 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.41,358,1498546800\"; d=\"scan'208\";a=\"138626388\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Fri, 11 Aug 2017 11:14:37 -0700", "Message-Id": "<20170811181437.30509-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.14.0.rc1.251.g593d8d6362ce", "Subject": "[Intel-wired-lan] [PATCH] fm10k: prefer %s and __func__ for\n\tdiagnostic prints", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Don't hardcode the function names in the diagnostic output when these\nreset related routines fail. Instead, use %s and __func__ so that future\nrefactors don't need to change the print outs.\n\nAdditionally, while we are here, add missing function header comments\nfor the new reset_prepare and reset_done function handlers.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 18 ++++++++++++++++--\n 1 file changed, 16 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex 3c79e6707cec..ba9d038f22e8 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -2588,11 +2588,18 @@ static void fm10k_io_resume(struct pci_dev *pdev)\n \n \tif (err)\n \t\tdev_warn(&pdev->dev,\n-\t\t\t \"fm10k_io_resume failed: %d\\n\", err);\n+\t\t\t \"%s failed: %d\\n\", __func__, err);\n \telse\n \t\tnetif_device_attach(netdev);\n }\n \n+/**\n+ * fm10k_io_reset_prepare - called when PCI function is about to be reset\n+ * @pdev: Pointer to PCI device\n+ *\n+ * This callback is called when the PCI function is about to be reset,\n+ * allowing the device driver to prepare for it.\n+ */\n static void fm10k_io_reset_prepare(struct pci_dev *pdev)\n {\n \t/* warn incase we have any active VF devices */\n@@ -2602,6 +2609,13 @@ static void fm10k_io_reset_prepare(struct pci_dev *pdev)\n \tfm10k_prepare_suspend(pci_get_drvdata(pdev));\n }\n \n+/**\n+ * fm10k_io_reset_done - called when PCI function has finished resetting\n+ * @pdev: Pointer to PCI device\n+ *\n+ * This callback is called just after the PCI function is reset, such as via\n+ * /sys/class/net/<enpX>/device/reset or similar.\n+ */\n static void fm10k_io_reset_done(struct pci_dev *pdev)\n {\n \tstruct fm10k_intfc *interface = pci_get_drvdata(pdev);\n@@ -2609,7 +2623,7 @@ static void fm10k_io_reset_done(struct pci_dev *pdev)\n \n \tif (err) {\n \t\tdev_warn(&pdev->dev,\n-\t\t\t \"fm10k_io_reset_notify failed: %d\\n\", err);\n+\t\t\t \"%s failed: %d\\n\", __func__, err);\n \t\tnetif_device_detach(interface->netdev);\n \t}\n }\n", "prefixes": [] }