Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/800635/?format=api
{ "id": 800635, "url": "http://patchwork.ozlabs.org/api/patches/800635/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/83d6fcab6a180d7006c8eb396c9aa3169dc6a84d.1502468221.git.joe@perches.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<83d6fcab6a180d7006c8eb396c9aa3169dc6a84d.1502468221.git.joe@perches.com>", "list_archive_url": null, "date": "2017-08-11T16:17:15", "name": "fm10k: Fix misuse of net_ratelimit()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cbb7a7e505819e4ec3900f3becab48df2891561c", "submitter": { "id": 771, "url": "http://patchwork.ozlabs.org/api/people/771/?format=api", "name": "Joe Perches", "email": "joe@perches.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/83d6fcab6a180d7006c8eb396c9aa3169dc6a84d.1502468221.git.joe@perches.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/800635/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/800635/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xTVX80x0gz9t2h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 12 Aug 2017 02:17:27 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id A6E0F30A86;\n\tFri, 11 Aug 2017 16:17:25 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YeqP3p5xVwCy; Fri, 11 Aug 2017 16:17:22 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7B60C30A83;\n\tFri, 11 Aug 2017 16:17:22 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2FA431C26D0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Aug 2017 16:17:21 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1FD2289F66\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Aug 2017 16:17:21 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hjym9N5rlyEt for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Aug 2017 16:17:20 +0000 (UTC)", "from smtprelay.hostedemail.com (smtprelay0133.hostedemail.com\n\t[216.40.44.133])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 0681389F65\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Aug 2017 16:17:19 +0000 (UTC)", "from filter.hostedemail.com (clb03-v110.bra.tucows.net\n\t[216.40.38.60])\n\tby smtprelay08.hostedemail.com (Postfix) with ESMTP id D8277182CED5B; \n\tFri, 11 Aug 2017 16:17:18 +0000 (UTC)", "from joe-laptop.perches.com (unknown [47.151.132.55])\n\t(Authenticated sender: joe@perches.com)\n\tby omf07.hostedemail.com (Postfix) with ESMTPA;\n\tFri, 11 Aug 2017 16:17:17 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "X-Session-Marker": "6A6F6540706572636865732E636F6D", "X-Spam-Summary": "2, 0, 0, , d41d8cd98f00b204, joe@perches.com, :::::::,\n\tRULES_HIT:41:355:379:541:800:960:973:988:989:1260:1345:1437:1534:1540:1568:1711:1714:1730:1747:1777:1792:2393:2559:2562:3138:3139:3140:3141:3142:3865:4321:5007:6119:6261:10004:10848:11026:11473:11657:11658:11914:12043:12438:12555:12679:12895:13069:13311:13357:14181:14384:14394:14721:21080:21627:30054:30055,\n\t0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5, Netcheck:none,\n\tDomainCache:0, MSF:not bulk, SPF:, MSBL:0, DNSBL:none,\n\tCustom_rules:0:0:0, LFtime:1, LUA_SUMMARY:none", "X-HE-Tag": "mist65_22a3f3eeb1817", "X-Filterd-Recvd-Size": "1556", "From": "Joe Perches <joe@perches.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Fri, 11 Aug 2017 09:17:15 -0700", "Message-Id": "<83d6fcab6a180d7006c8eb396c9aa3169dc6a84d.1502468221.git.joe@perches.com>", "X-Mailer": "git-send-email 2.10.0.rc2.1.g053435c", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] fm10k: Fix misuse of net_ratelimit()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Correct the backward logic using !net_ratelimit()\n\nMiscellanea:\n\no Add a blank line before the error return label\n\nSigned-off-by: Joe Perches <joe@perches.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_main.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\nindex 9dffaba85ae6..489d8032e2f2 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n@@ -806,9 +806,10 @@ static int fm10k_tso(struct fm10k_ring *tx_ring,\n \ttx_desc->mss = cpu_to_le16(skb_shinfo(skb)->gso_size);\n \n \treturn 1;\n+\n err_vxlan:\n \ttx_ring->netdev->features &= ~NETIF_F_GSO_UDP_TUNNEL;\n-\tif (!net_ratelimit())\n+\tif (net_ratelimit())\n \t\tnetdev_err(tx_ring->netdev,\n \t\t\t \"TSO requested for unsupported tunnel, disabling offload\\n\");\n \treturn -1;\n", "prefixes": [] }