Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/800/?format=api
{ "id": 800, "url": "http://patchwork.ozlabs.org/api/patches/800/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20080921202057.GB25052@2ka.mipt.ru/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20080921202057.GB25052@2ka.mipt.ru>", "list_archive_url": null, "date": "2008-09-21T20:20:57", "name": "Mark IPW2100 as BROKEN: Fatal interrupt. Scheduling firmware restart.", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "4a7e2a486bddc2829f86feb61885cf64fed9f814", "submitter": { "id": 225, "url": "http://patchwork.ozlabs.org/api/people/225/?format=api", "name": "Evgeniy Polyakov", "email": "johnpol@2ka.mipt.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20080921202057.GB25052@2ka.mipt.ru/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/800/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/800/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 84DC8DDEEF\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 22 Sep 2008 06:24:47 +1000 (EST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752407AbYIUUYk (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSun, 21 Sep 2008 16:24:40 -0400", "(majordomo@vger.kernel.org) by vger.kernel.org id S1752413AbYIUUYj\n\t(ORCPT <rfc822; netdev-outgoing>); Sun, 21 Sep 2008 16:24:39 -0400", "from relay.2ka.mipt.ru ([194.85.80.65]:40999 \"EHLO 2ka.mipt.ru\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752192AbYIUUYh (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tSun, 21 Sep 2008 16:24:37 -0400", "from 2ka.mipt.ru (localhost [127.0.0.1])\n\tby 2ka.mipt.ru (8.14.1/8.14.1) with ESMTP id m8LKKwRv009341;\n\tMon, 22 Sep 2008 00:20:58 +0400", "(from johnpol@localhost)\n\tby 2ka.mipt.ru (8.14.1/8.12.1/Submit) id m8LKKv7Y009328;\n\tMon, 22 Sep 2008 00:20:57 +0400" ], "Date": "Mon, 22 Sep 2008 00:20:57 +0400", "From": "Evgeniy Polyakov <johnpol@2ka.mipt.ru>", "To": "Arjan van de Ven <arjan@infradead.org>", "Cc": "Johannes Berg <johannes@sipsolutions.net>, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, ipw2100-devel@lists.sourceforge.net,\n\tlinux-wireless@vger.kernel.org, yi.zhu@intel.com,\n\treinette.chatre@intel.com, jgarzik@pobox.com,\n\tlinville@tuxdriver.com, davem@davemloft.net", "Subject": "Re: Mark IPW2100 as BROKEN: Fatal interrupt. Scheduling firmware\n\trestart.", "Message-ID": "<20080921202057.GB25052@2ka.mipt.ru>", "References": "<20080921172316.GA6306@2ka.mipt.ru>\n\t<20080921110422.1d010b96@infradead.org>\n\t<20080921182835.GA11473@2ka.mipt.ru>\n\t<20080921113513.16677c4e@infradead.org>\n\t<20080921190050.GA20484@2ka.mipt.ru>\n\t<1222024444.3023.53.camel@johannes.berg>\n\t<20080921193809.GA8735@2ka.mipt.ru>\n\t<20080921124332.67ddc13a@infradead.org>", "Mime-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<20080921124332.67ddc13a@infradead.org>", "User-Agent": "Mutt/1.5.9i", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "On Sun, Sep 21, 2008 at 12:43:32PM -0700, Arjan van de Ven (arjan@infradead.org) wrote:\n> > @@ -3174,6 +3176,10 @@ static void ipw2100_irq_tasklet(struct\n> > ipw2100_priv *priv) if (inta & IPW2100_INTA_FATAL_ERROR) {\n> > \t\tprintk(KERN_WARNING DRV_NAME\n> > \t\t \": Fatal interrupt. Scheduling firmware\n> > restart.\\n\");\n> > +\t\tWARN_ON(1);\n> > +\n> > +\t\tBUG_ON(ipw2100_max_fatal_ints-- <= 0);\n> \n> BUG_ON in interrupt context is just extremely hostile, since it means\n> the box is dead.\n>\n> also I would suggest using WARN_ON_ONCE() \n\nWell, I actually wanted to have a bug there because of it, but now I\nthink that annoying repeated warning is enough to bring attention to the\nproblem by putting bug information into some magic special place called\nkerneloops collection.\n\nConsider for inclusing for the upcoming kernel to get wider\nnotifications. Yes, it is not a bugfix, I know.", "diff": "diff --git a/drivers/net/wireless/ipw2100.c b/drivers/net/wireless/ipw2100.c\nindex 19a401c..6599211 100644\n--- a/drivers/net/wireless/ipw2100.c\n+++ b/drivers/net/wireless/ipw2100.c\n@@ -206,6 +206,9 @@ MODULE_PARM_DESC(disable, \"manually disable the radio (default 0 [radio on])\");\n \n static u32 ipw2100_debug_level = IPW_DL_NONE;\n \n+static int ipw2100_max_fatal_ints = 10;\n+module_param(ipw2100_max_fatal_ints, int, 0644);\n+\n #ifdef CONFIG_IPW2100_DEBUG\n #define IPW_DEBUG(level, message...) \\\n do { \\\n@@ -3174,6 +3177,9 @@ static void ipw2100_irq_tasklet(struct ipw2100_priv *priv)\n \tif (inta & IPW2100_INTA_FATAL_ERROR) {\n \t\tprintk(KERN_WARNING DRV_NAME\n \t\t \": Fatal interrupt. Scheduling firmware restart.\\n\");\n+\n+\t\tWARN_ON(ipw2100_max_fatal_ints-- >= 0);\n+\n \t\tpriv->inta_other++;\n \t\twrite_register(dev, IPW_REG_INTA, IPW2100_INTA_FATAL_ERROR);\n \n", "prefixes": [] }